From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 214511B2DA for ; Fri, 19 Jan 2018 17:41:30 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jan 2018 08:41:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,382,1511856000"; d="scan'208";a="167514486" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.77]) by orsmga004.jf.intel.com with SMTP; 19 Jan 2018 08:41:27 -0800 Received: by (sSMTP sendmail emulation); Fri, 19 Jan 2018 16:41:26 +0000 Date: Fri, 19 Jan 2018 16:41:26 +0000 From: Bruce Richardson To: Pavan Nikhilesh Cc: jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com, dev@dpdk.org, thomas@monjalon.net Message-ID: <20180119164126.GC16980@bricha3-MOBL3.ger.corp.intel.com> References: <20180119131508.7768-1-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180119131508.7768-1-pbhagavatula@caviumnetworks.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH] build: add support for vendor specific ARM cross builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 16:41:31 -0000 On Fri, Jan 19, 2018 at 06:45:08PM +0530, Pavan Nikhilesh wrote: > Add various vendor specific cross build targets. > This can be verified by using linaro toolchain and running > > meson build --cross-file config/arm/arch64_armv8__cross > "arch64-armv8"? I thought we were standardizing on "arm64" as the naming here, or alternatively I think it should be "aarch64", right? In terms of file naming, do we want to have a file extension on these files. I wondering if we want to change "_cross" to ".cross" for instance. The basic example in the meson docs uses a .txt extension but that looks weird to me. No strong opinion on my end, just looking for any other ideas. > In future more cross build targets can be added. Yes, good idea. Is config/ the best place to hold these, or should we have a separate cross-build folder? I quite like having them in config like you have done, but wondering if anyone disagrees? > > Signed-off-by: Pavan Nikhilesh > --- > config/arm/arch64_armv8_generic_cross | 10 +++++++ > config/arm/arch64_armv8_thunderx_cross | 13 +++++++++ > config/arm/meson.build | 52 +++++++++++++++++++--------------- > 3 files changed, 52 insertions(+), 23 deletions(-) > create mode 100644 config/arm/arch64_armv8_generic_cross > create mode 100644 config/arm/arch64_armv8_thunderx_cross > Adding Thomas on CC as he always has opinions on file locations and naming. /Bruce