DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] build: add support for vendor specific ARM cross builds
@ 2018-01-19 13:15 Pavan Nikhilesh
  2018-01-19 16:41 ` Bruce Richardson
  2018-01-22 13:14 ` [dpdk-dev] [PATCH v2] " Pavan Nikhilesh
  0 siblings, 2 replies; 10+ messages in thread
From: Pavan Nikhilesh @ 2018-01-19 13:15 UTC (permalink / raw)
  To: jerin.jacob, bruce.richardson, harry.van.haaren; +Cc: dev, Pavan Nikhilesh

Add various vendor specific cross build targets.
This can be verified by using linaro toolchain and running

	meson build --cross-file config/arm/arch64_armv8_<cpu>_cross

In future more cross build targets can be added.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
 config/arm/arch64_armv8_generic_cross  | 10 +++++++
 config/arm/arch64_armv8_thunderx_cross | 13 +++++++++
 config/arm/meson.build                 | 52 +++++++++++++++++++---------------
 3 files changed, 52 insertions(+), 23 deletions(-)
 create mode 100644 config/arm/arch64_armv8_generic_cross
 create mode 100644 config/arm/arch64_armv8_thunderx_cross

diff --git a/config/arm/arch64_armv8_generic_cross b/config/arm/arch64_armv8_generic_cross
new file mode 100644
index 000000000..3b4d3c469
--- /dev/null
+++ b/config/arm/arch64_armv8_generic_cross
@@ -0,0 +1,10 @@
+[binaries]
+c = 'aarch64-linux-gnu-gcc'
+cpp = 'aarch64-linux-gnu-cpp'
+ar = 'aarch64-linux-gnu-gcc-ar'
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8-a'
+endian = 'little'
diff --git a/config/arm/arch64_armv8_thunderx_cross b/config/arm/arch64_armv8_thunderx_cross
new file mode 100644
index 000000000..7ff34af74
--- /dev/null
+++ b/config/arm/arch64_armv8_thunderx_cross
@@ -0,0 +1,13 @@
+[binaries]
+c = 'aarch64-linux-gnu-gcc'
+cpp = 'aarch64-linux-gnu-cpp'
+ar = 'aarch64-linux-gnu-gcc-ar'
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8-a'
+endian = 'little'
+
+[properties]
+implementor_id = '0x43'
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 62af5e68a..79e453997 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -34,6 +34,8 @@ else
 	dpdk_conf.set('RTE_ARCH_ARM64', 1)
 	dpdk_conf.set('RTE_ARCH_64', 1)
 
+	machine = []
+	cmd_output = []
 	if not meson.is_cross_build()
 		# The script returns ['Implementor', 'Variant', 'Architecture',
 		# 'Primary Part number', 'Revision']
@@ -46,31 +48,35 @@ else
 			machine_args = [] # Clear previous machine args
 			cmd_output = cmd.stdout().strip().split(' ')
 			machine = get_variable('impl_' + cmd_output[0])
-			message('Implementor : ' + machine[0])
+		endif
+	else
+		impl_id = meson.get_cross_property('implementor_id', 'generic')
+		machine = get_variable('impl_' + impl_id, 'generic')
+	endif
 
-			foreach flag: machine[1]
-				dpdk_conf.set(flag[0], flag[1])
+	if machine != 'generic'
+		message('Implementor : ' + machine[0])
+		foreach flag: machine[1]
+			dpdk_conf.set(flag[0], flag[1])
+		endforeach
+		# Primary part number based mcpu flags are supported
+		# for gcc versions > 7
+		if cc.version().version_compare('<7.0') or cmd_output.length() == 0
+			foreach marg: machine[2]
+				if marg[0] == 'default'
+					foreach f: marg[1]
+						machine_args += f
+					endforeach
+				endif
+			endforeach
+		else
+			foreach marg: machine[2]
+				if marg[0] == cmd_output[3]
+					foreach f: marg[1]
+						machine_args += f
+					endforeach
+				endif
 			endforeach
-
-			# Primary part number based mcpu flags are supported
-			# for gcc versions > 7
-			if cc.version().version_compare('<7.0')
-				foreach marg: machine[2]
-					if marg[0] == 'default'
-						foreach f: marg[1]
-							machine_args += f
-						endforeach
-					endif
-				endforeach
-			else
-				foreach marg: machine[2]
-					if marg[0] == cmd_output[3]
-						foreach f: marg[1]
-							machine_args += f
-						endforeach
-					endif
-				endforeach
-			endif
 		endif
 	endif
 endif
-- 
2.14.1

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] build: add support for vendor specific ARM cross builds
  2018-01-19 13:15 [dpdk-dev] [PATCH] build: add support for vendor specific ARM cross builds Pavan Nikhilesh
@ 2018-01-19 16:41 ` Bruce Richardson
  2018-01-19 17:26   ` Pavan Nikhilesh
  2018-01-22 13:14 ` [dpdk-dev] [PATCH v2] " Pavan Nikhilesh
  1 sibling, 1 reply; 10+ messages in thread
From: Bruce Richardson @ 2018-01-19 16:41 UTC (permalink / raw)
  To: Pavan Nikhilesh; +Cc: jerin.jacob, harry.van.haaren, dev, thomas

On Fri, Jan 19, 2018 at 06:45:08PM +0530, Pavan Nikhilesh wrote:
> Add various vendor specific cross build targets.
> This can be verified by using linaro toolchain and running
> 
> 	meson build --cross-file config/arm/arch64_armv8_<cpu>_cross
> 

"arch64-armv8"? I thought we were standardizing on "arm64" as the naming
here, or alternatively I think it should be "aarch64", right?

In terms of file naming, do we want to have a file extension on these
files. I wondering if we want to change "_cross" to ".cross" for
instance. The basic example in the meson docs uses a .txt extension but
that looks weird to me. No strong opinion on my end, just looking for
any other ideas.

> In future more cross build targets can be added.

Yes, good idea. Is config/<arch> the best place to hold these, or should
we have a separate cross-build folder? I quite like having them in
config like you have done, but wondering if anyone disagrees?

> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
>  config/arm/arch64_armv8_generic_cross  | 10 +++++++
>  config/arm/arch64_armv8_thunderx_cross | 13 +++++++++
>  config/arm/meson.build                 | 52 +++++++++++++++++++---------------
>  3 files changed, 52 insertions(+), 23 deletions(-)
>  create mode 100644 config/arm/arch64_armv8_generic_cross
>  create mode 100644 config/arm/arch64_armv8_thunderx_cross
> 

Adding Thomas on CC as he always has opinions on file locations and
naming.

/Bruce

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] build: add support for vendor specific ARM cross builds
  2018-01-19 16:41 ` Bruce Richardson
@ 2018-01-19 17:26   ` Pavan Nikhilesh
  2018-01-19 17:35     ` Bruce Richardson
  0 siblings, 1 reply; 10+ messages in thread
From: Pavan Nikhilesh @ 2018-01-19 17:26 UTC (permalink / raw)
  To: Bruce Richardson, jerin.jacob, harry.van.haaren, thomas; +Cc: dev

On Fri, Jan 19, 2018 at 04:41:26PM +0000, Bruce Richardson wrote:
> On Fri, Jan 19, 2018 at 06:45:08PM +0530, Pavan Nikhilesh wrote:
> > Add various vendor specific cross build targets.
> > This can be verified by using linaro toolchain and running
> >
> > 	meson build --cross-file config/arm/arch64_armv8_<cpu>_cross
> >
>
> "arch64-armv8"? I thought we were standardizing on "arm64" as the naming
> here, or alternatively I think it should be "aarch64", right?
>

Currently, make uses "arm64-<platform>" as the naming convention.
I think either "arm64-<plat>" is better as we can easily represent
"arm-<plat>" (v7).

> In terms of file naming, do we want to have a file extension on these
> files. I wondering if we want to change "_cross" to ".cross" for
> instance. The basic example in the meson docs uses a .txt extension but
> that looks weird to me. No strong opinion on my end, just looking for
> any other ideas.
>
> > In future more cross build targets can be added.
>
> Yes, good idea. Is config/<arch> the best place to hold these, or should
> we have a separate cross-build folder? I quite like having them in
> config like you have done, but wondering if anyone disagrees?
>

I split this patch out from the other series specifically so that we could
discuss and agree upon common name/path etc. :-).

Thanks,
Pavan
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> >  config/arm/arch64_armv8_generic_cross  | 10 +++++++
> >  config/arm/arch64_armv8_thunderx_cross | 13 +++++++++
> >  config/arm/meson.build                 | 52 +++++++++++++++++++---------------
> >  3 files changed, 52 insertions(+), 23 deletions(-)
> >  create mode 100644 config/arm/arch64_armv8_generic_cross
> >  create mode 100644 config/arm/arch64_armv8_thunderx_cross
> >
>
> Adding Thomas on CC as he always has opinions on file locations and
> naming.
>
> /Bruce

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] build: add support for vendor specific ARM cross builds
  2018-01-19 17:26   ` Pavan Nikhilesh
@ 2018-01-19 17:35     ` Bruce Richardson
  2018-01-22 12:38       ` Jerin Jacob
  0 siblings, 1 reply; 10+ messages in thread
From: Bruce Richardson @ 2018-01-19 17:35 UTC (permalink / raw)
  To: Pavan Nikhilesh; +Cc: jerin.jacob, harry.van.haaren, thomas, dev

On Fri, Jan 19, 2018 at 10:56:08PM +0530, Pavan Nikhilesh wrote:
> On Fri, Jan 19, 2018 at 04:41:26PM +0000, Bruce Richardson wrote:
> > On Fri, Jan 19, 2018 at 06:45:08PM +0530, Pavan Nikhilesh wrote:
> > > Add various vendor specific cross build targets.
> > > This can be verified by using linaro toolchain and running
> > >
> > > 	meson build --cross-file config/arm/arch64_armv8_<cpu>_cross
> > >
> >
> > "arch64-armv8"? I thought we were standardizing on "arm64" as the naming
> > here, or alternatively I think it should be "aarch64", right?
> >
> 
> Currently, make uses "arm64-<platform>" as the naming convention.
> I think either "arm64-<plat>" is better as we can easily represent
> "arm-<plat>" (v7).
> 
Yes, keep it consistent with "make" names to avoid confusion.

> > In terms of file naming, do we want to have a file extension on these
> > files. I wondering if we want to change "_cross" to ".cross" for
> > instance. The basic example in the meson docs uses a .txt extension but
> > that looks weird to me. No strong opinion on my end, just looking for
> > any other ideas.
> >
> > > In future more cross build targets can be added.
> >
> > Yes, good idea. Is config/<arch> the best place to hold these, or should
> > we have a separate cross-build folder? I quite like having them in
> > config like you have done, but wondering if anyone disagrees?
> >
> 
> I split this patch out from the other series specifically so that we could
> discuss and agree upon common name/path etc. :-).

Good idea. If no discussion or objection I'll take your patch as-is
(with arm64 filenames) and we can always move/rename files later.

> 
> Thanks, Pavan
> > >
> > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > > --- config/arm/arch64_armv8_generic_cross  | 10 +++++++
> > > config/arm/arch64_armv8_thunderx_cross | 13 +++++++++
> > > config/arm/meson.build                 | 52
> > > +++++++++++++++++++--------------- 3 files changed, 52
> > > insertions(+), 23 deletions(-) create mode 100644
> > > config/arm/arch64_armv8_generic_cross create mode 100644
> > > config/arm/arch64_armv8_thunderx_cross
> > >
> >
> > Adding Thomas on CC as he always has opinions on file locations and
> > naming.
> >
> > /Bruce

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] build: add support for vendor specific ARM cross builds
  2018-01-19 17:35     ` Bruce Richardson
@ 2018-01-22 12:38       ` Jerin Jacob
  0 siblings, 0 replies; 10+ messages in thread
From: Jerin Jacob @ 2018-01-22 12:38 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: Pavan Nikhilesh, harry.van.haaren, thomas, dev

-----Original Message-----
> Date: Fri, 19 Jan 2018 17:35:57 +0000
> From: Bruce Richardson <bruce.richardson@intel.com>
> To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> CC: jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com,
>  thomas@monjalon.net, dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] build: add support for vendor specific ARM
>  cross builds
> User-Agent: Mutt/1.9.1 (2017-09-22)
> 
> On Fri, Jan 19, 2018 at 10:56:08PM +0530, Pavan Nikhilesh wrote:
> > On Fri, Jan 19, 2018 at 04:41:26PM +0000, Bruce Richardson wrote:
> > > On Fri, Jan 19, 2018 at 06:45:08PM +0530, Pavan Nikhilesh wrote:
> > > > Add various vendor specific cross build targets.
> > > > This can be verified by using linaro toolchain and running
> > > >
> > > > 	meson build --cross-file config/arm/arch64_armv8_<cpu>_cross
> > > >
> > >
> > > "arch64-armv8"? I thought we were standardizing on "arm64" as the naming
> > > here, or alternatively I think it should be "aarch64", right?
> > >
> > 
> > Currently, make uses "arm64-<platform>" as the naming convention.
> > I think either "arm64-<plat>" is better as we can easily represent
> > "arm-<plat>" (v7).
> > 
> Yes, keep it consistent with "make" names to avoid confusion.

+1 to keep it consistent with "make" names.

> 
> > > In terms of file naming, do we want to have a file extension on these
> > > files. I wondering if we want to change "_cross" to ".cross" for
> > > instance. The basic example in the meson docs uses a .txt extension but
> > > that looks weird to me. No strong opinion on my end, just looking for
> > > any other ideas.
> > >
> > > > In future more cross build targets can be added.
> > >
> > > Yes, good idea. Is config/<arch> the best place to hold these, or should
> > > we have a separate cross-build folder? I quite like having them in
> > > config like you have done, but wondering if anyone disagrees?
> > >
> > 
> > I split this patch out from the other series specifically so that we could
> > discuss and agree upon common name/path etc. :-).
> 
> Good idea. If no discussion or objection I'll take your patch as-is
> (with arm64 filenames) and we can always move/rename files later.
> 
> > 
> > Thanks, Pavan
> > > >
> > > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > > > --- config/arm/arch64_armv8_generic_cross  | 10 +++++++
> > > > config/arm/arch64_armv8_thunderx_cross | 13 +++++++++
> > > > config/arm/meson.build                 | 52
> > > > +++++++++++++++++++--------------- 3 files changed, 52
> > > > insertions(+), 23 deletions(-) create mode 100644
> > > > config/arm/arch64_armv8_generic_cross create mode 100644
> > > > config/arm/arch64_armv8_thunderx_cross
> > > >
> > >
> > > Adding Thomas on CC as he always has opinions on file locations and
> > > naming.
> > >
> > > /Bruce

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-dev] [PATCH v2] build: add support for vendor specific ARM cross builds
  2018-01-19 13:15 [dpdk-dev] [PATCH] build: add support for vendor specific ARM cross builds Pavan Nikhilesh
  2018-01-19 16:41 ` Bruce Richardson
@ 2018-01-22 13:14 ` Pavan Nikhilesh
  2018-01-22 13:40   ` Jerin Jacob
  2018-01-22 14:12   ` Bruce Richardson
  1 sibling, 2 replies; 10+ messages in thread
From: Pavan Nikhilesh @ 2018-01-22 13:14 UTC (permalink / raw)
  To: jerin.jacob, bruce.richardson, harry.van.haaren, herbert.guan,
	hemant.agrawal
  Cc: dev, Pavan Nikhilesh

Add various vendor specific cross build targets.
This can be verified by using linaro toolchain and running

	meson build --cross-file config/arm/arch64_armv8_<cpu>_cross

In future more cross build targets can be added.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---

 v2 Changes:
 - rename cross file names.
 - redo machine args selection logic.

 config/arm/arm64_armv8_linuxapp_gcc    | 10 ++++++++++
 config/arm/arm64_thunderx_linuxapp_gcc | 13 +++++++++++++
 config/arm/meson.build                 |  3 +++
 3 files changed, 26 insertions(+)
 create mode 100644 config/arm/arm64_armv8_linuxapp_gcc
 create mode 100644 config/arm/arm64_thunderx_linuxapp_gcc

diff --git a/config/arm/arm64_armv8_linuxapp_gcc b/config/arm/arm64_armv8_linuxapp_gcc
new file mode 100644
index 000000000..3b4d3c469
--- /dev/null
+++ b/config/arm/arm64_armv8_linuxapp_gcc
@@ -0,0 +1,10 @@
+[binaries]
+c = 'aarch64-linux-gnu-gcc'
+cpp = 'aarch64-linux-gnu-cpp'
+ar = 'aarch64-linux-gnu-gcc-ar'
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8-a'
+endian = 'little'
diff --git a/config/arm/arm64_thunderx_linuxapp_gcc b/config/arm/arm64_thunderx_linuxapp_gcc
new file mode 100644
index 000000000..7ff34af74
--- /dev/null
+++ b/config/arm/arm64_thunderx_linuxapp_gcc
@@ -0,0 +1,13 @@
+[binaries]
+c = 'aarch64-linux-gnu-gcc'
+cpp = 'aarch64-linux-gnu-cpp'
+ar = 'aarch64-linux-gnu-gcc-ar'
+
+[host_machine]
+system = 'linux'
+cpu_family = 'aarch64'
+cpu = 'armv8-a'
+endian = 'little'
+
+[properties]
+implementor_id = '0x43'
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 212b94499..a5bfb9610 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -59,6 +59,9 @@ else
 		endif
 		# Set to generic if variable is not found
 		machine = get_variable('impl_' + cmd_output[0], 'generic')
+	else
+		impl_id = meson.get_cross_property('implementor_id', 'generic')
+		machine = get_variable('impl_' + impl_id)
 	endif

 	if machine == 'generic'
--
2.16.0

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH v2] build: add support for vendor specific ARM cross builds
  2018-01-22 13:14 ` [dpdk-dev] [PATCH v2] " Pavan Nikhilesh
@ 2018-01-22 13:40   ` Jerin Jacob
  2018-01-22 14:49     ` Pavan Nikhilesh
  2018-01-22 14:12   ` Bruce Richardson
  1 sibling, 1 reply; 10+ messages in thread
From: Jerin Jacob @ 2018-01-22 13:40 UTC (permalink / raw)
  To: Pavan Nikhilesh
  Cc: bruce.richardson, harry.van.haaren, herbert.guan, hemant.agrawal, dev

-----Original Message-----
> Date: Mon, 22 Jan 2018 18:44:50 +0530
> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> To: jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com,
>  harry.van.haaren@intel.com, herbert.guan@arm.com, hemant.agrawal@nxp.com
> Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH v2] build: add support for vendor specific ARM
>  cross builds
> X-Mailer: git-send-email 2.14.1
> 
> Add various vendor specific cross build targets.
> This can be verified by using linaro toolchain and running
> 
> 	meson build --cross-file config/arm/arch64_armv8_<cpu>_cross

Looks like git comment is _not_ updated. i.e comment is not sync with filename.

IMO, it will useful to update the existing meson build document for the
cross build procedure.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH v2] build: add support for vendor specific ARM cross builds
  2018-01-22 13:14 ` [dpdk-dev] [PATCH v2] " Pavan Nikhilesh
  2018-01-22 13:40   ` Jerin Jacob
@ 2018-01-22 14:12   ` Bruce Richardson
  2018-01-22 14:26     ` Pavan Nikhilesh
  1 sibling, 1 reply; 10+ messages in thread
From: Bruce Richardson @ 2018-01-22 14:12 UTC (permalink / raw)
  To: Pavan Nikhilesh
  Cc: jerin.jacob, harry.van.haaren, herbert.guan, hemant.agrawal, dev

On Mon, Jan 22, 2018 at 06:44:50PM +0530, Pavan Nikhilesh wrote:
> Add various vendor specific cross build targets.
> This can be verified by using linaro toolchain and running
> 
> 	meson build --cross-file config/arm/arch64_armv8_<cpu>_cross
> 
> In future more cross build targets can be added.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---

Does this need to be merged into the set to add ARM compilation support
in order to fix the cross-compile build?

/Bruce

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH v2] build: add support for vendor specific ARM cross builds
  2018-01-22 14:12   ` Bruce Richardson
@ 2018-01-22 14:26     ` Pavan Nikhilesh
  0 siblings, 0 replies; 10+ messages in thread
From: Pavan Nikhilesh @ 2018-01-22 14:26 UTC (permalink / raw)
  To: Bruce Richardson, jerin.jacob, harry.van.haaren, herbert.guan,
	hemant.agrawal
  Cc: dev

On Mon, Jan 22, 2018 at 02:12:05PM +0000, Bruce Richardson wrote:
> On Mon, Jan 22, 2018 at 06:44:50PM +0530, Pavan Nikhilesh wrote:
> > Add various vendor specific cross build targets.
> > This can be verified by using linaro toolchain and running
> >
> > 	meson build --cross-file config/arm/arch64_armv8_<cpu>_cross
> >
> > In future more cross build targets can be added.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
>
> Does this need to be merged into the set to add ARM compilation support
> in order to fix the cross-compile build?
>

Yup, this patch as to go after applying the ARM compilation support patches.

> /Bruce

Regards,
Pavan.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH v2] build: add support for vendor specific ARM cross builds
  2018-01-22 13:40   ` Jerin Jacob
@ 2018-01-22 14:49     ` Pavan Nikhilesh
  0 siblings, 0 replies; 10+ messages in thread
From: Pavan Nikhilesh @ 2018-01-22 14:49 UTC (permalink / raw)
  To: Jerin Jacob, bruce.richardson, harry.van.haaren, herbert.guan,
	hemant.agrawal
  Cc: dev

On Mon, Jan 22, 2018 at 07:10:53PM +0530, Jerin Jacob wrote:
> -----Original Message-----
> > Date: Mon, 22 Jan 2018 18:44:50 +0530
> > From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > To: jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com,
> >  harry.van.haaren@intel.com, herbert.guan@arm.com, hemant.agrawal@nxp.com
> > Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH v2] build: add support for vendor specific ARM
> >  cross builds
> > X-Mailer: git-send-email 2.14.1
> >
> > Add various vendor specific cross build targets.
> > This can be verified by using linaro toolchain and running
> >
> > 	meson build --cross-file config/arm/arch64_armv8_<cpu>_cross
>
> Looks like git comment is _not_ updated. i.e comment is not sync with filename.

Yup missed it, now that naming and directory structure is agreed upon will
merge this patch with other set and send a v6.

>
> IMO, it will useful to update the existing meson build document for the
> cross build procedure.
>
Will update the documentation and send it as a patch in the next series.

Thanks,
Pavan.

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2018-01-22 14:50 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-19 13:15 [dpdk-dev] [PATCH] build: add support for vendor specific ARM cross builds Pavan Nikhilesh
2018-01-19 16:41 ` Bruce Richardson
2018-01-19 17:26   ` Pavan Nikhilesh
2018-01-19 17:35     ` Bruce Richardson
2018-01-22 12:38       ` Jerin Jacob
2018-01-22 13:14 ` [dpdk-dev] [PATCH v2] " Pavan Nikhilesh
2018-01-22 13:40   ` Jerin Jacob
2018-01-22 14:49     ` Pavan Nikhilesh
2018-01-22 14:12   ` Bruce Richardson
2018-01-22 14:26     ` Pavan Nikhilesh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).