From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 523757CD8 for ; Mon, 22 Jan 2018 08:28:49 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id j21so7587908wmh.1 for ; Sun, 21 Jan 2018 23:28:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=qHvWqYQHN96FYKP9i7OVrrHzpUnzdbFbxLn4glCc7es=; b=ZL5afgR60KLEF1XMF1EZYXF05iWf6U6WyQjD2RFGV9HbUTlXFo0sh/kSn8bWbS7rnt 4wIii9yjeEAABr/hfxdetdbW5kZiSZzadqCJwg3cKs9j/YJeXHvmMIAfAcf2xUU/FUL0 iyaQFxLvzUurN3xLlFpd3KqsOoLimFovNHxGo2Ud3PNlicZwbhub0Mgvd5dAjKpCYbIt dEO5u3Ns8UhwohJ6EnXKe7jkl24gz5+nsCK8PSsD579buj2TvevM5r8dChVpz8/RI9y5 AHA8dKCaiWh+AAmpxKBqrQHLAmuAB9T/TikkQn2kPm3/Wa63a1jMh5ARdC20SIHxXINU yv/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=qHvWqYQHN96FYKP9i7OVrrHzpUnzdbFbxLn4glCc7es=; b=ZysdhvyeS/6g+U/eb0lOYF2/XtuebWJ3cYLPAO7CYCnylvR+mcWaE5AbOrxKwsSD1T 2GgRrHPxSnX9zVxg2qr+xZiX4Y6zXfCnOrac4kWkDEX43Yn9BiRpIu6sZABdCiPsy2G0 BQDjA1jTnKShqJszBMAyuT55c6sBOPfhj4olx52jopjfHLimq455WvmwmIF9yxWjqnmf zWIJoFa8R+V14slPPxfVvRW2XfnUZZSc6bfeqb07toDW5IumD4JWnPNnaZzIGqr1a+Gs FQMx3F96UvQogkgxoVe8jOXJ+GOaUk1vGbGb4NbCi9tIfo7LnW+NdGOYDL58aLyRxAMZ q9hg== X-Gm-Message-State: AKwxytf8Zl5COp/darPtC+SjIDxU7fcZGGJRx7j8Ab8NXhleD0Vhg2TP UcBNY16zQBgsrWfVvZTI+fl4jA== X-Google-Smtp-Source: AH8x224l/d5W6n1i0TtKpbiNUSPhWSap57zoDJYho2aJna+JNtREjkEQnLO7WwUx3xydt7gIHpP6yQ== X-Received: by 10.80.208.197 with SMTP id g5mr11986219edf.216.1516606129028; Sun, 21 Jan 2018 23:28:49 -0800 (PST) Received: from localhost (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id a16sm11949414edd.19.2018.01.21.23.28.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Jan 2018 23:28:48 -0800 (PST) Date: Mon, 22 Jan 2018 08:28:47 +0100 From: Tomasz Duszynski To: "Singh, Jasvinder" Cc: "Dumitrescu, Cristian" , Tomasz Duszynski , "dev@dpdk.org" , "Lu, Wenzhuo" , "Wu, Jingjing" Message-ID: <20180122072847.GA20881@sh.semihalf.local> References: <1515678563-13424-1-git-send-email-tdu@semihalf.com> <3EB4FA525960D640B5BDFFD6A3D891267BAFBFA4@IRSMSX108.ger.corp.intel.com> <54CBAA185211B4429112C315DA58FF6D332C7149@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <54CBAA185211B4429112C315DA58FF6D332C7149@IRSMSX103.ger.corp.intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 07:28:49 -0000 On Fri, Jan 12, 2018 at 01:07:34PM +0000, Singh, Jasvinder wrote: > > > > -----Original Message----- > > From: Dumitrescu, Cristian > > Sent: Thursday, January 11, 2018 6:34 PM > > To: Tomasz Duszynski ; dev@dpdk.org > > Cc: Lu, Wenzhuo ; Wu, Jingjing > > ; Singh, Jasvinder > > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions > > table > > > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski > > > Sent: Thursday, January 11, 2018 1:49 PM > > > To: dev@dpdk.org > > > Cc: Lu, Wenzhuo ; Wu, Jingjing > > > ; Tomasz Duszynski > > > Subject: [dpdk-dev] [PATCH] app/testpmd: add meter to the actions > > > table > > > > > > Since METER action is supported by the testpmd application suitable > > > entry should exist in flow actions information table. > > > > > > Without that testpmd will return error on adding a new flow to the > > > list of flows attached to a given port. > > > > > > Signed-off-by: Tomasz Duszynski > > > --- > > > app/test-pmd/config.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index > > > 0a84481..4ad19fb 100644 > > > --- a/app/test-pmd/config.c > > > +++ b/app/test-pmd/config.c > > > @@ -1038,6 +1038,7 @@ static const struct { > > > MK_FLOW_ACTION(RSS, sizeof(struct rte_flow_action_rss)), /* > > > +queue[] */ > > > MK_FLOW_ACTION(PF, 0), > > > MK_FLOW_ACTION(VF, sizeof(struct rte_flow_action_vf)), > > > + MK_FLOW_ACTION(METER, sizeof(struct rte_flow_action_meter)), > > > }; > > > > > > /** Compute storage space needed by action configuration. */ > > > -- > > > 2.7.4 > > > > Adding Jasvinder to this thread. > > The above change looks fine to me. > > Acked-by: Jasvinder Singh Since I cannot see any objections can you pick up this one? -- - Tomasz Duszy=C5=84ski