Re: [dpdk-dev] [PATCH v8 2/3] ring: introduce new header file to include common functions

[Stephen Hemminger <stephen@networkplumber.org>]

On Fri, 19 Jan 2018 16:47:36 +0000
Hemant Agrawal <hemant.agrawal@nxp.com> wrote:

> Hi Olivier,
> 
> > On Fri, Jan 19, 2018 at 07:45:30PM +0530, Hemant Agrawal wrote:  
> > > Hi Jia,
> > >
> > > On 1/17/2018 9:33 AM, Jia He wrote:  
> > > > Move the common part of rte_ring.h into rte_ring_generic.h.
> > > > Move the memory barrier part into update_tail().
> > > >
> > > > No functional changes here.
> > > >
> > > > Signed-off-by: Jia He <jia.he@hxt-semitech.com>
> > > > Suggested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > > Suggested-by: Ananyev Konstantin <konstantin.ananyev@intel.com>
> > > > Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > > Acked-by: Olivier Matz <olivier.matz@6wind.com>
> > > > ---
> > > > diff --git a/lib/librte_ring/rte_ring_generic.h
> > > > b/lib/librte_ring/rte_ring_generic.h
> > > > new file mode 100644
> > > > index 0000000..01f2cae
> > > > --- /dev/null
> > > > +++ b/lib/librte_ring/rte_ring_generic.h
> > > > @@ -0,0 +1,202 @@
> > > > +/*-
> > > > + *   Copyright(c) 2017 Intel Corporation. All rights reserved.
> > > > + *   All rights reserved.
> > > > + *
> > > > + *   SPDX-License-Identifier: BSD-3-Clause  
> > >
> > > The SPDX should be first line. See other files for Intel or NXP.  
> 
> [Hemant] Don't add SPDX to this file. 
>  This file is not BSD-3 licensed.  Please keep the full text as in the original file.


If it can't be BSD-3 licensed, then it needs to be removed. Mixing licenses is a real problem