From: Olivier Matz <olivier.matz@6wind.com>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: DPDK <dev@dpdk.org>
Subject: Re: [dpdk-dev] mbuf vlan_tci validity unclear
Date: Mon, 22 Jan 2018 13:51:09 +0100 [thread overview]
Message-ID: <20180122125109.6i66nim3qm2xxt3j@platinum> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35B41D73@smartserver.smartshare.dk>
Hi Morten,
On Wed, Jan 17, 2018 at 10:20:53PM +0100, Morten Brørup wrote:
> In rte_mbuf.h, the description of the PKT_RX_VLAN flag (lines 93-94) says that
> mbuf->vlan_tci contains the VLAN TCI if the flag is set; however, the
> description of the vlan_tci field (line 513) says that the
> PKT_RX_VLAN_STRIPPED flag must be set for it to be valid.
>
> Which one is it? And will someone please update the comments in rte_mbuf.h
> accordingly.
Thanks for spotting this, I will send a patch to fix it.
PKT_RX_VLAN means that mbuf->vlan_tci is valid.
And PKT_RX_VLAN_STRIPPED implies that PKT_RX_VLAN is set too.
next prev parent reply other threads:[~2018-01-22 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 21:20 Morten Brørup
2018-01-22 12:51 ` Olivier Matz [this message]
2018-01-29 9:36 ` [dpdk-dev] [PATCH] mbuf: fix API documentation regarding VLAN flags Olivier Matz
2018-01-29 16:24 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122125109.6i66nim3qm2xxt3j@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).