From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by dpdk.org (Postfix) with ESMTP id D932DFFA for ; Mon, 22 Jan 2018 22:48:56 +0100 (CET) Received: by mail-pf0-f194.google.com with SMTP id b25so8107228pfd.9 for ; Mon, 22 Jan 2018 13:48:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=l3XDt3PIQlWd8/HpFnqGV1a5WP6bDdrsEkrj5xDkI94=; b=eS7WvJjmV8L8bpIlnLVmSmbnsNXUUlP2Rmuk8F+ZvcLE46F6rgD0780DZu5JTmH7SQ Qb1pKsubmbSJ9+4VlhAKlw5Fqn1VPA9tWhRkhsmjUNz04WsSXLhfzZgO6/2QMfL12158 FRuFvl03lY0bFGvRjG/prrbnMn9tLiGNGDmmh9BbX8cDSlseTmQ080wdWfjrelrBgsvp umwcdjsECujZBAy9vlBwQZKd+O1WIO3pagZ5+XBRbEQYVpr0rFzf/Tmmpahwrp/J2+pV 8/YtLOSnoSh2aVkGjIKt9x0MLpaSSMwKjPfbzmNpcwfZgETnIinjOpgJSUuVQtco5q4M f1eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=l3XDt3PIQlWd8/HpFnqGV1a5WP6bDdrsEkrj5xDkI94=; b=TR7K6CZDZKoVtTB/nKEOawnBYRKahSdoZJiCOHpnmwk5EtG8dfVDZsrxr8gBo5Pj3Z Z9HZ7Lor6naP7wICSBFewRP07fUXPpfnHH2hsCWuRbZdLQ3fQc8WdZ2b6yFdeTaGUB/y xDWh53WUEZK8aGkBguuNlbo6PoPY1BgnBKku/eKkGgZUEv15nwMGcfa1kK0bhfP7zDoI slgKudiXHK1lDWlxrKENzkIp3UWDTBo68grSidt6s7XYJKACU4oQkxOrzIiHGLJLme50 LvlcYKE1NySmHKuaktOmvFAGHJScXthW4j3Mk5YwwcfdF/MQUCrhukqsh9wlVb8piBgM uVnQ== X-Gm-Message-State: AKwxyteyvRyd6mAOYyxLl2J1OuPYPLyMZ9VSKmkBZ6Q0AdnDjDN1z4h3 QdaSCHdKg2lE6Jd4b7XasUae3Q== X-Google-Smtp-Source: AH8x225iNnzrIKmScGHDkxzQcFvYZJyIAZBNZyhy5ewIa0YdPC0j98EJQtmjK1yofvtnbrRniwkFeg== X-Received: by 10.101.71.130 with SMTP id e2mr7731522pgs.396.1516657735976; Mon, 22 Jan 2018 13:48:55 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id y17sm2360048pfk.67.2018.01.22.13.48.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Jan 2018 13:48:55 -0800 (PST) Date: Mon, 22 Jan 2018 13:48:53 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: Ferruh Yigit , chaozhu@linux.vnet.ibm.com, dev@dpdk.org, Bruce Richardson , Konstantin Ananyev , Jonas Pfefferle Message-ID: <20180122134853.0cf85c70@xeon-e3> In-Reply-To: <4302048.2hzkQNGxWI@xps> References: <20180116183755.24542-1-stephen@networkplumber.org> <1537329.tE083vG8Go@xps> <20180122085613.2928a3a6@xeon-e3> <4302048.2hzkQNGxWI@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 01/14] eal: introduce atomic exchange operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 21:48:57 -0000 On Mon, 22 Jan 2018 22:03:02 +0100 Thomas Monjalon wrote: > 22/01/2018 17:56, Stephen Hemminger: > > On Mon, 22 Jan 2018 00:50:55 +0100 > > Thomas Monjalon wrote: > > > > > 21/01/2018 20:25, Ferruh Yigit: > > > > On 1/21/2018 6:59 PM, Ferruh Yigit wrote: > > > > > From: Stephen Hemminger > > > > > > > > > > To handle atomic update of link status (64 bit), every driver > > > > > was doing its own version using cmpset. > > > > > Atomic exchange is a useful primitive in its own right; > > > > > therefore make it a EAL routine. > > > > > > > > > > Signed-off-by: Stephen Hemminger > > > > > Reviewed-by: Ferruh Yigit > > > > Series applied to dpdk-next-net/master, thanks. > > > > > > I need to drop this series when pulling in master, > > > because PPC is not supported. > > > > > > Chao, please could you help on this feature? > > > Thanks > > > > The generic code should work for PPC. > > No, the generic code is inside #ifdef RTE_FORCE_INTRINSICS. > PPC does not define RTE_FORCE_INTRINSICS, > and ARM could disable it I guess. I will add a non intrinsic generic version using cmpset.