* [dpdk-dev] [PATCH] lib: fix wrong cast
@ 2018-01-23 9:48 Zhiyong Yang
2018-01-23 9:59 ` Akhil Goyal
2018-01-23 15:31 ` [dpdk-dev] [dpdk-stable] " De Lara Guarch, Pablo
0 siblings, 2 replies; 4+ messages in thread
From: Zhiyong Yang @ 2018-01-23 9:48 UTC (permalink / raw)
To: dev
Cc: ferruh.yigit, thomas, stable, declan.doherty, akhil.goyal, Zhiyong Yang
The wrong casts don't cause actual error, but they should conform to C
standard.
Fixes: c261d1431bd8 ("security: introduce security API and framework")
Fixes: b3bbd9e5f265 ("cryptodev: support device independent sessions")
Cc: stable@dpdk.org
Cc: declan.doherty@intel.com
Cc: akhil.goyal@nxp.com
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
lib/librte_cryptodev/rte_cryptodev.c | 2 +-
lib/librte_security/rte_security.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c
index 7726d15f4..8745b6b02 100644
--- a/lib/librte_cryptodev/rte_cryptodev.c
+++ b/lib/librte_cryptodev/rte_cryptodev.c
@@ -1094,7 +1094,7 @@ rte_cryptodev_sym_session_create(struct rte_mempool *mp)
struct rte_cryptodev_sym_session *sess;
/* Allocate a session structure from the session pool */
- if (rte_mempool_get(mp, (void *)&sess)) {
+ if (rte_mempool_get(mp, (void **)&sess)) {
CDEV_LOG_ERR("couldn't get object from session mempool");
return NULL;
}
diff --git a/lib/librte_security/rte_security.c b/lib/librte_security/rte_security.c
index 6461dba05..d98f46dea 100644
--- a/lib/librte_security/rte_security.c
+++ b/lib/librte_security/rte_security.c
@@ -49,7 +49,7 @@ rte_security_session_create(struct rte_security_ctx *instance,
RTE_FUNC_PTR_OR_ERR_RET(*instance->ops->session_create, NULL);
- if (rte_mempool_get(mp, (void *)&sess))
+ if (rte_mempool_get(mp, (void **)&sess))
return NULL;
if (instance->ops->session_create(instance->device, conf, sess, mp)) {
--
2.13.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] lib: fix wrong cast
2018-01-23 9:48 [dpdk-dev] [PATCH] lib: fix wrong cast Zhiyong Yang
@ 2018-01-23 9:59 ` Akhil Goyal
2018-01-23 15:31 ` [dpdk-dev] [dpdk-stable] " De Lara Guarch, Pablo
1 sibling, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2018-01-23 9:59 UTC (permalink / raw)
To: Zhiyong Yang, dev; +Cc: ferruh.yigit, thomas, stable, declan.doherty
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] lib: fix wrong cast
2018-01-23 9:48 [dpdk-dev] [PATCH] lib: fix wrong cast Zhiyong Yang
2018-01-23 9:59 ` Akhil Goyal
@ 2018-01-23 15:31 ` De Lara Guarch, Pablo
2018-01-23 15:39 ` De Lara Guarch, Pablo
1 sibling, 1 reply; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2018-01-23 15:31 UTC (permalink / raw)
To: Yang, Zhiyong, dev
Cc: Yigit, Ferruh, thomas, stable, Doherty, Declan, akhil.goyal,
Yang, Zhiyong
> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Zhiyong Yang
> Sent: Tuesday, January 23, 2018 9:48 AM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; thomas@monjalon.net;
> stable@dpdk.org; Doherty, Declan <declan.doherty@intel.com>;
> akhil.goyal@nxp.com; Yang, Zhiyong <zhiyong.yang@intel.com>
> Subject: [dpdk-stable] [PATCH] lib: fix wrong cast
>
> The wrong casts don't cause actual error, but they should conform to C
> standard.
>
> Fixes: c261d1431bd8 ("security: introduce security API and framework")
> Fixes: b3bbd9e5f265 ("cryptodev: support device independent sessions")
> Cc: stable@dpdk.org
> Cc: declan.doherty@intel.com
> Cc: akhil.goyal@nxp.com
>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] lib: fix wrong cast
2018-01-23 15:31 ` [dpdk-dev] [dpdk-stable] " De Lara Guarch, Pablo
@ 2018-01-23 15:39 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2018-01-23 15:39 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Yang, Zhiyong, dev
Cc: Yigit, Ferruh, thomas, stable, Doherty, Declan, akhil.goyal,
Yang, Zhiyong
> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of De Lara
> Guarch, Pablo
> Sent: Tuesday, January 23, 2018 3:31 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>; dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; thomas@monjalon.net;
> stable@dpdk.org; Doherty, Declan <declan.doherty@intel.com>;
> akhil.goyal@nxp.com; Yang, Zhiyong <zhiyong.yang@intel.com>
> Subject: Re: [dpdk-stable] [PATCH] lib: fix wrong cast
>
>
>
> > -----Original Message-----
> > From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Zhiyong
> > Yang
> > Sent: Tuesday, January 23, 2018 9:48 AM
> > To: dev@dpdk.org
> > Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; thomas@monjalon.net;
> > stable@dpdk.org; Doherty, Declan <declan.doherty@intel.com>;
> > akhil.goyal@nxp.com; Yang, Zhiyong <zhiyong.yang@intel.com>
> > Subject: [dpdk-stable] [PATCH] lib: fix wrong cast
> >
> > The wrong casts don't cause actual error, but they should conform to C
> > standard.
> >
> > Fixes: c261d1431bd8 ("security: introduce security API and framework")
> > Fixes: b3bbd9e5f265 ("cryptodev: support device independent sessions")
> > Cc: stable@dpdk.org
> > Cc: declan.doherty@intel.com
> > Cc: akhil.goyal@nxp.com
> >
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-23 15:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-23 9:48 [dpdk-dev] [PATCH] lib: fix wrong cast Zhiyong Yang
2018-01-23 9:59 ` Akhil Goyal
2018-01-23 15:31 ` [dpdk-dev] [dpdk-stable] " De Lara Guarch, Pablo
2018-01-23 15:39 ` De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).