From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by dpdk.org (Postfix) with ESMTP id 996251B1B4 for ; Wed, 24 Jan 2018 16:39:18 +0100 (CET) Received: by mail-pf0-f195.google.com with SMTP id b25so3330332pfd.9 for ; Wed, 24 Jan 2018 07:39:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pDgpg3C0l3wKRzhYUsctaPJ0+6PW8o/fNfDME5dalt4=; b=hK65/7JKjEnK347lYkaZUnOwcN33vY7aWQElp+DRSl1pgDCyepfDqKl3IBtNycW0DU r2iCil1ZqaMs/pob0jMknFwrNwnUFZreaydYFgC7c7VInFwgvxOUaq1rbczZhj3bST2g mNLZFrTRk5908Yw6ase1eb3Aat0dVINIuTONOXPAiyrHxk3ngJIrG2uLCPYhJl4SXWUN SWnMKPaeelZhDU+1le4qu99i8vau5WJ3u1px1q+kBwOobmSmGXg3R5v/yK8fCIJgB8vC 7/00tpKBejiMW1v3zAdlwYqRU6upBSH97FK2gITWKabpma6BhXEAW4MGdq1rpJhIBCCo QW+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pDgpg3C0l3wKRzhYUsctaPJ0+6PW8o/fNfDME5dalt4=; b=oimjbZWnXm1WJRfuJ2U/Ku58ZM9WCzkvSCpTPHt5j0aAZe23Dl4BjZuGpvPH0gAdjO gU9PcurdfRLvfMA8YeaRvvVxVDzaarYeZRRc2nmhBYDoc7S8sthXVjETyD9Pqcr9pGJl 0iYAXNaUPKTJg/07JM5RxOcy77ndww/0P73avUoR/on0zcKzOALQdq9+jnT6mtgMVZui rTTAI3r0tbLPFSeY9lgSEaCQbovIxgbRXMorcLnWqiQ2NH8/soiaaQITWJP4YhbbmrQm VQf/29l7WQQL2tXwya245HB6mcmABAEM6cTEl2ouvkwY54eSWWoxoXekFz7m4ROegnUj MsTg== X-Gm-Message-State: AKwxytdCM9meeD79qnpJzUHArnckDQv2J/jcJeTpExCZi5quJq/c7k6u O92H2dIK9rt8cZrsFZiL114qpQ== X-Google-Smtp-Source: AH8x22770m6hy6PfDEWmMjUKlwTppq1h9Bzb3yerbpYTdXQDUG0XTkLw3pw00wCx/MHT5KkusSJjcg== X-Received: by 2002:a17:902:59d9:: with SMTP id d25-v6mr8799545plj.312.1516808357630; Wed, 24 Jan 2018 07:39:17 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id u63sm10463149pfi.63.2018.01.24.07.39.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jan 2018 07:39:17 -0800 (PST) Date: Wed, 24 Jan 2018 07:39:15 -0800 From: Stephen Hemminger To: Ophir Munk Cc: dev@dpdk.org, Matan Azrad , Thomas Monjalon , Olga Shern , Adrien Mazarguil , stable@dpdk.org Message-ID: <20180124073915.753a4764@xeon-e3> In-Reply-To: <1516803133-17529-1-git-send-email-ophirmu@mellanox.com> References: <1516792792-10119-1-git-send-email-ophirmu@mellanox.com> <1516803133-17529-1-git-send-email-ophirmu@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 15:39:19 -0000 On Wed, 24 Jan 2018 14:12:13 +0000 Ophir Munk wrote: > Remove CFLAGS -std=c11 and -pedantic in order to guarantee > a successful vdev_netvsc compilation on old Linux distributions. > Otherwise old GCC compilers may complain as follows: > cc1: error: unrecognized command line option -std=c11 > > Fixes: 6086ab3bb3d2 ("net/vdev_netvsc: introduce Hyper-V platform driver") > Cc: stable@dpdk.org > > Signed-off-by: Ophir Munk > --- > drivers/net/vdev_netvsc/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/vdev_netvsc/Makefile b/drivers/net/vdev_netvsc/Makefile > index f2b2ac5..45351b8 100644 > --- a/drivers/net/vdev_netvsc/Makefile > +++ b/drivers/net/vdev_netvsc/Makefile > @@ -12,7 +12,7 @@ EXPORT_MAP := rte_pmd_vdev_netvsc_version.map > # Additional compilation flags. > CFLAGS += -O3 > CFLAGS += -g > -CFLAGS += -std=c11 -pedantic -Wall -Wextra > +CFLAGS += -Wall -Wextra > CFLAGS += -D_XOPEN_SOURCE=600 > CFLAGS += -D_BSD_SOURCE > CFLAGS += -D_DEFAULT_SOURCE Why did this driver not use $(WERROR) like rest of DPDK drivers.