From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com
 [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id 92024199AC
 for <dev@dpdk.org>; Wed, 24 Jan 2018 19:27:34 +0100 (CET)
Received: by mail-pf0-f196.google.com with SMTP id e76so3757378pfk.1
 for <dev@dpdk.org>; Wed, 24 Jan 2018 10:27:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=5JI1c+oDiA0etoPmbicvAuDgnnWF6uByRkxlOaEM6Vo=;
 b=uYZPzMf1i4lWI35h8MpGCxD4pxHshcKjUkFjH9G/2sBAaXSDCzw0Auzhs9f2Za8YJB
 EwYLM1CN8KC6tj8O5J2NCHtSuzj2Q79kYlJpedZnOHU0Ah+/iLS1eXJ9SZ+Q0PoATr+O
 bxb0HznyIoeJK/6WMDmvl4IT5irbHTkccuKZ8D44VsbOjZqg6WAdQHXvaFJOGWFRC2lL
 Ox/Jzr53ERArceJdeDS2Mf3OLLnbBVeNSQxnSXy4pbXjYAMVakK6ikesesWhoulOioKm
 5fnmvJXJojXXU4kmPcQ0n7yxeVgD7x2DScaVn6zjXtXiYkDDkNSxrnXvht8xcso8ix7G
 lzLA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=5JI1c+oDiA0etoPmbicvAuDgnnWF6uByRkxlOaEM6Vo=;
 b=tN7lhJX1yu764HSRGa5hJNeGNOz8xprM3uHs36KAfWL86d0VFV0gkRe3IZOigR3Erj
 Kf4Um1O7/j2Xr+7gblKkb7wTE7I2H84LPK7J4o/RnPPo5NDX2kIxc/ak+KjxK0e8xjWS
 0dFHnR7wKb92uZaGS/MjsLAay5VvD4ZwBJ+HHFN+v19Q0TYFvo2aLdewNfJTx97KsoxT
 xwXIvrgokCbC7wq7fh0I/l/wclHB9csLJHixrpUq7lj8mOCyeJVqvfZfF9w96OW0m/RD
 A5eokcWtRviSyzqf7cnvVU8a05zImbfhocR6gzUms/k9PcKX5yh2bys+iSir1u0h36tT
 T2WA==
X-Gm-Message-State: AKwxytcFXrHlcvwhpwcP+jOE1XpK+s5OUzCVL1mp4BCn8lmV6/Mdr98P
 eacYgR6KssUIOezgPsL1kYooHg==
X-Google-Smtp-Source: AH8x226Edwew39nRgPkKqlVcjuTm3SHh7giyuC+PXJKPetgCOERJkXJICXHSt/uIWIvYVozlk8PjIA==
X-Received: by 10.98.216.2 with SMTP id e2mr13636815pfg.151.1516818453657;
 Wed, 24 Jan 2018 10:27:33 -0800 (PST)
Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133])
 by smtp.gmail.com with ESMTPSA id t71sm13272844pfg.115.2018.01.24.10.27.33
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 24 Jan 2018 10:27:33 -0800 (PST)
Date: Wed, 24 Jan 2018 10:27:31 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Matan Azrad <matan@mellanox.com>, stable@dpdk.org, Ophir Munk
 <ophirmu@mellanox.com>, dev@dpdk.org, Olga Shern <olgas@mellanox.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>
Message-ID: <20180124102731.219f90cc@xeon-e3>
In-Reply-To: <2260225.RPhyHJgTVH@xps>
References: <1516792792-10119-1-git-send-email-ophirmu@mellanox.com>
 <1516803133-17529-1-git-send-email-ophirmu@mellanox.com>
 <20180124073915.753a4764@xeon-e3> <2260225.RPhyHJgTVH@xps>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/vdev_netvsc: fix build
 using C11 mode and pedantic
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jan 2018 18:27:34 -0000

On Wed, 24 Jan 2018 19:08:02 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> 24/01/2018 16:39, Stephen Hemminger:
> > On Wed, 24 Jan 2018 14:12:13 +0000
> > Ophir Munk <ophirmu@mellanox.com> wrote:  
> > > --- a/drivers/net/vdev_netvsc/Makefile
> > > +++ b/drivers/net/vdev_netvsc/Makefile
> > > @@ -12,7 +12,7 @@ EXPORT_MAP := rte_pmd_vdev_netvsc_version.map
> > >  # Additional compilation flags.
> > >  CFLAGS += -O3
> > >  CFLAGS += -g
> > > -CFLAGS += -std=c11 -pedantic -Wall -Wextra
> > > +CFLAGS += -Wall -Wextra
> > >  CFLAGS += -D_XOPEN_SOURCE=600
> > >  CFLAGS += -D_BSD_SOURCE
> > >  CFLAGS += -D_DEFAULT_SOURCE  
> > 
> > Why did this driver not use $(WERROR) like rest of DPDK drivers.  
> 
> It can be a separate patch.
> Matan?

I meant that you should use:

CFLAGS += $(WERROR_FLAGS)

instead of

CFLAGS += -Wall -Wextra

in this patch.

Also, do you really  need all the other CFLAGS? Why?

This driver has no reason to be a special case different from what is done
in virtio, vmxnet3, ixgbe, e1000, ...