From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 915E6DE0 for ; Wed, 24 Jan 2018 11:36:45 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2DE9B223C9; Wed, 24 Jan 2018 05:36:45 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 24 Jan 2018 05:36:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=P/GVXt/sj3CkK0XcTb6emBn1FD4dWGvCG6eCioRglAM=; b=VQ7smTlT gWE8HGVJHJu7as5ztbZquBE9ddu6P21fqXU3Za5jR4EhAS3amVQ1BIaRXc81IipF kMNR56+BBBWbM9/K/W1neoixUHS28K1y1NPF4HSTZvHz+HGEVsWw4OuRpzRbAf1c lELKuMgFxwULnewWCWqWmqZ02CdEc1PmmWj0KYpZ6AiQI2QG4K4gNoJBu7vEtd4S /DqSa+/ZujfgQBb8CT2VIN2W8xfXRZNKrR+lC6BZEs8L2GeL7lVlUZzwBZp3XT+g oyPlyR2D+3+eZvChk9H94sr1JFq7ysvp9C91KpStxqSrE/IQe452mmVCpfgdL2MR aTVYX+YhF+O/TQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=P/GVXt/sj3CkK0XcTb6emBn1FD4dW GvCG6eCioRglAM=; b=AOMx7qX9TWYwprJwY3bHwvP0i6fVDx3b5VQhBP36lZCOX fIoirAI+qBkSuVmhrJ6dGaKykSe1aWEZAFwDNTex6QX68mP2Xtz11QueqpXsEJpx H3E/+F0JwrhwgKksOiiYl1uuG6jckRpktAbEAdDEOVSDxIrOVGtlHAHOSAjBHEWH 9b+GE7HmvH3NBqd6YeVeoL7bgT/8aZvQdnUmIwBV3hnr4kSNir49EGF+SIpwkqk0 vnB7lv34MF7PeOPEx8BMO4wWPfn7gmnk0qHm50x5CxbPTWFpObdB4BVEebamLqZT FCtwJw+Q/1bP854umK3+6Ol5SSRoojudFHzu76g0A== X-ME-Sender: Received: from yliu-mob (unknown [115.150.27.206]) by mail.messagingengine.com (Postfix) with ESMTPA id 219AF240DE; Wed, 24 Jan 2018 05:36:43 -0500 (EST) Date: Wed, 24 Jan 2018 18:36:40 +0800 From: Yuanhan Liu To: Thomas Monjalon Cc: =?iso-8859-1?Q?Ga=EBtan?= Rivet , Ferruh Yigit , dev@dpdk.org Message-ID: <20180124103640.GV29540@yliu-mob> References: <1516114218-21501-1-git-send-email-yliu@fridaylinux.org> <1680850.DZ6KxSLkSi@xps> <20180124092827.GU29540@yliu-mob> <4742912.xRQpCbhV5k@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4742912.xRQpCbhV5k@xps> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 10:36:45 -0000 On Wed, Jan 24, 2018 at 11:21:44AM +0100, Thomas Monjalon wrote: > 24/01/2018 10:28, Yuanhan Liu: > > On Wed, Jan 24, 2018 at 09:19:10AM +0100, Thomas Monjalon wrote: > > > 24/01/2018 07:43, Yuanhan Liu: > > > > On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thomas Monjalon wrote: > > > > > 23/01/2018 13:46, Yuanhan Liu: > > > > > > If port not found, then the whole string will be used for dev attachment. > > > > > > It means we are attaching a port with PCI BDF == 04.00.0 AND > > > > > > port == 0 (the 2nd port will not be attached). > > > > > > > > > > > > > > > > > > And here is how the devargs would look like if "matching;settings" is > > > > > > being used: > > > > > > > > > > > > bus=pci,id=04:00.0/class=eth,port=0;bus=pci,id=04:00.0/class=eth,port=0/driver=mlx4,mlx4_arg_A=val,... > > > > > > > > > > > > The part before ";" will be used for lookup and the later part will be > > > > > > used for attachment. It should work. It just looks redundant. > > > > > > > > > > It does not have to be redundant. > > > > > It can be: > > > > > bus=pci,id=04:00.0/class=eth,port=0;driver=mlx4,mlx4_arg1=settings1,... > > > > > > > > I knew you would make such reply :) > > > > Then there is a contradiction. According your suggestion, the "port=0" belongs > > > > to the matching section, but it also has to be used in the settings section. > > > > > > If port=0 is matched, it is already set, right? > > > > Yes. > > > > > Why it needs to be in settings? > > > > But I was talking the case it's not matched, say it's not probed and here > > we do hotplug. > > I don't understand. > Anyway, the port property should be read-only. All proberties should be read-only. > Are we talking about the dev_port from the Linux kernel? Yes. And it can be used for probing one port only (out of 2 ports in a NIC) at probe stage. So, at this stage, it's a setting but not a match. --yliu