From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id 2E4152C2E for ; Thu, 25 Jan 2018 19:42:59 +0100 (CET) Received: by mail-pf0-f196.google.com with SMTP id 23so6422351pfp.3 for ; Thu, 25 Jan 2018 10:42:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YOIXePZ8QbxsNZi7g10iVGkQ4qlKKuHqF858YVmr8LU=; b=Nqo194J03RFAJRX/Ip8odBDnbww50+EvXp+QCWXIme/tMGiTtddDkry9gyEuD7q5/t ziGujdcLvPpJEpxQhfuKUmrS94Y0NejlVRCfBmrCHPmRWIrmjGw9iKrOfWKfWvj2RaM5 jxOnaYdJ+TV5TQZqDoId9Dsb15cqG1dDr1Ec6GP/LuO6hh1prCQtFUOEhQ7V+U4jS26h DdcA44OkdML7xoLA8RAdZXHvVb493vVjb+ZOf0k75fBPvfJzg4q4z1zKTsgmS7PS/ieW voPVGEwh+Do4AFiF5kO4mQZLQtAW2igFFDBG6YKz6SxUsNMjg+vwtaPueYa7LFzUvnPv O02Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YOIXePZ8QbxsNZi7g10iVGkQ4qlKKuHqF858YVmr8LU=; b=siMXyLXVjhO0sUEdh3PuljPKXru3KfJcQBErRPX+mxUDICRVdfRYwanZ2MebnfHCUZ DlNR+UiJA36bHjImIUTZrE3S6meuDldmwux1TPDiGGH6skJ/R+u6IR3vbmp8KA67rj+r oopCBckLgp7mL+GEFKSICb201gDnJzHJAJlEXvQSp7+fXqzKZ0XG46Rx22UNTdULyf+D GX1rrnA8q1udJq70G7JeWm2sbNheWbnjLEiuMp07/jumE15G8JyH+c6g71XwKxaGL2WP WX+Ht5WqfMzIJsdMGSug5E0qNQa9+VtpckxTFZaE820WU87A+i/zMSls+d5sV2YE6QJf VlmQ== X-Gm-Message-State: AKwxytdpWu0wnHpxwPkd2Mxu8GnzXKQnZ2rg8LLBndqhdfxUdIBnieHV BuKRGwwnK6gqRCX3bG5mrSbeFPj+XnQ= X-Google-Smtp-Source: AH8x2272VAEbNhFUDfagj3jpJTRLWr0MaRcT6iJLHs4Ypbzy0t+LUw0ACuTGBaAKGV5iQ6e7iCwWMg== X-Received: by 10.99.2.203 with SMTP id 194mr14031319pgc.268.1516905778241; Thu, 25 Jan 2018 10:42:58 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id g13sm20649353pfe.50.2018.01.25.10.42.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Jan 2018 10:42:58 -0800 (PST) Date: Thu, 25 Jan 2018 10:42:55 -0800 From: Stephen Hemminger To: Andrew Rybchenko Cc: , Ivan Malov Message-ID: <20180125104255.57e0cd19@xeon-e3> In-Reply-To: <1516899647-8541-3-git-send-email-arybchenko@solarflare.com> References: <1516899647-8541-1-git-send-email-arybchenko@solarflare.com> <1516899647-8541-3-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/6] net/sfc: add support for driver-wide dynamic logging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jan 2018 18:42:59 -0000 On Thu, 25 Jan 2018 17:00:43 +0000 Andrew Rybchenko wrote: > diff --git a/drivers/net/sfc/efsys.h b/drivers/net/sfc/efsys.h > index c7a54c3..8dd225e 100644 > --- a/drivers/net/sfc/efsys.h > +++ b/drivers/net/sfc/efsys.h > @@ -26,6 +26,7 @@ > #include > > #include "sfc_debug.h" > +#include "sfc_log.h" > > #ifdef __cplusplus > extern "C" { > @@ -721,7 +722,7 @@ typedef uint64_t efsys_stat_t; > #define EFSYS_ERR(_esip, _code, _dword0, _dword1) \ > do { \ > (void)(_esip); \ > - RTE_LOG(ERR, PMD, "FATAL ERROR #%u (0x%08x%08x)\n", \ > + SFC_GENERIC_LOG(ERR, "FATAL ERROR #%u (0x%08x%08x)", \ > (_code), (_dword0), (_dword1)); \ > _NOTE(CONSTANTCONDITION); \ > } while (B_FALSE) Off topic, but why is this header file having C++ wrapper? It is driver private, and driver is always built with C.