From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0075.outbound.protection.outlook.com [104.47.40.75]) by dpdk.org (Postfix) with ESMTP id E99FE1B319 for ; Fri, 26 Jan 2018 06:27:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Do9RLagTkohQ4rpLaPMADnJxli3bbsSqEsoFTinolx4=; b=hn5DD3glEx+nuuUN9fL578EA3TXaC3ZPgc208LmmTAuveV0tJavlBn+mng930y4cEMkuNFmaiqq5w+42vU7b/QE07Nf0L5wTMTVwhrpSzCCQ4i0WVLQ0HEdsRy27/Y7+xlNiG2RrTTUZLMo8IQtcLMODmcQwwF5UUT/u83qZ90w= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT (111.93.218.67) by BN6PR07MB3458.namprd07.prod.outlook.com (10.161.153.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Fri, 26 Jan 2018 05:27:32 +0000 Date: Fri, 26 Jan 2018 10:55:22 +0530 From: Pavan Nikhilesh To: Ferruh Yigit , jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com Cc: dev@dpdk.org Message-ID: <20180126052521.bkwtrkizp3rhlda2@Pavan-LT> References: <20180123162240.26831-1-pbhagavatula@caviumnetworks.com> <11910e83-35cc-deb0-fff4-e01bde0a2240@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11910e83-35cc-deb0-fff4-e01bde0a2240@intel.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR01CA0107.INDPRD01.PROD.OUTLOOK.COM (10.174.144.23) To BN6PR07MB3458.namprd07.prod.outlook.com (10.161.153.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a041573e-1eb4-4e64-4b28-08d5647d80c8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:BN6PR07MB3458; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3458; 3:vCB25BCKvlWKJBz7NITEap8jEXoOVXyoZS1s4ddNrJ/cRHoUdaICByTawqs7Kr2uiLTFHVY41hf/RjVbEbbAIno1WF1w01fVNIxgQvSlocMWFnZBEH8aT8dxGFtxLEq/tCgCnfliGFKmWOFenCXI7cB2PtzD7nuDdc8wrUyQ0jVmLC0Yud8r47MissPnLGqd0OdMwVMV+nVNYKPnHhpX3HvtFknz+PFIOUkmord+WWZK2GzF+qb0795cJDDC7DRj; 25:IaFB7S1qmMK5Xy5bMA8O0S1kurQFiHWT7e7OsVlggMFsDSUKhNM5HT4RwzHPPBoxG4qgeiUu1/+0nVEOQg4lCSnRj9xdNMND5LSfDcp6c4Ljir4PeRdUZtvUAZMKgfUW4G0ppj6fO0Qi1x/xuM3/gjwJilULsMtY/IID7unf8JbVjiNFi2hS6qmrqU7/WAORZmmR634NKVybyG5DEKlAvgoTuCrUlusudlHmB/vj4trnusy5MJFMxEYMCrqKU+pltBsPzo9kuRgnhEv45gRM+/kQ6udqlQDcDonv67bblZxuze4f5Orn0j6LeeucvP6Z6KvFV9+trQlNplkbM72MDg==; 31:BFZRF/BlVzuk0mtcSWWAESMezgtJldb1vEsS0/KbTHgkyYUqugwBoPE773eEvEalZ11TIMi1XYKAk6wC0ipyy+IbJm207a0Nr4sfow71gL/FW5le+WNVHVC47JS2i3XX35v9r9Ou7QtBkSPHuV75ffPCGHlwkrfHNMsfiQ3CmVtrHC4sBpGfz6T1a4LK17gE2pcxlL2eMpcrwnoaeS8w92zfIhYG5NYsDw1MRntiIDo= X-MS-TrafficTypeDiagnostic: BN6PR07MB3458: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3458; 20:m7R742kY1QI2YGodG+jRjR0fz8uO+cNFXIHz21P7IM4DYD66OaDX43/Y8rwCi0kpKl2bFZBsJSerjgqZd1tqgrwBfOq8avhmIQlU6Ok8XkHg2J9uzBbNGg6jUX+7+Yy5Ncdlxl1tI2Z2b+mj+Y06fIBvIRm+xDZY45pMWMykWXYtcddWkHl4pxSuKKoVJhwH84rtXhIU9hkzXZyQX3FynqYgOR6cmxVsdMahGQf6pwg17WjXP808ENRtdwI8S+i/qHnPubztIO5ze7mLRdPMkQpUpuVtbovzEP9p/O8W9a16Ph0gjyBIMBxd8oSGn/QU174U2Wv9pKmX/Ii2DWiR/iNKYZJEdy8+Htg47Ek8JbpGoE7fWPiTSocmri0ADrCn5PksbiBoIMhs1TiGdw5SJ8t5gZuZBA4O32ASV86R9CsJsWnx08DINN7a5KvEJXedl4HBhd8Ep0xAmsBjgDorEYRHyqEQok4wSeU/44XQ9zGWLB2j0y+4/t9tqPnzryV0zeUVrdSjM9YqILxhylLmKlmNeOoS1weqdWkqYgF/nT/jUZw9e4yWgL7xb3/lIDZqggctvtQCRZ5SwG/CgqDSRmAjqHFpo/+HzItD6P/Mrj0=; 4:bkMsvtAPskYInsKW7IJO6lEMJ4xObBAxh4114CWZ1MrtqOAtrMt5esC76LLRqwdgimpcT5K5SdsyH9lw5WHEABfKhSpEgk4Fp2cid527bSfg4odwPi4AVm5ft7Ah9CSQZlpNe4RvbBBdNUL/y8SaUJusymYz3LIJTIrQhDrK6gj8eqHqsKwVpfJLOKwYJfMF9HGLLfUrp72OTLwKVxTbUfkdw/hCBgOtXGVD5ryDTIq2jQnxa+nW0NEHruBHTxCk0XrXcplTQAJl0ElAWUJRQg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(10201501046)(93006095)(3231023)(2400081)(944501161)(3002001)(6041288)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:BN6PR07MB3458; BCL:0; PCL:0; RULEID:; SRVR:BN6PR07MB3458; X-Forefront-PRVS: 05641FD966 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(39850400004)(346002)(376002)(366004)(396003)(189003)(199004)(3846002)(6116002)(47776003)(2950100002)(23726003)(66066001)(5660300001)(1076002)(2906002)(316002)(305945005)(7736002)(42882006)(106356001)(6636002)(6666003)(16586007)(25786009)(58126008)(83506002)(97736004)(186003)(4326008)(50466002)(478600001)(5009440100003)(8936002)(33716001)(53936002)(72206003)(53546011)(386003)(76176011)(6246003)(26005)(33896004)(9686003)(6496006)(52116002)(105586002)(81166006)(81156014)(229853002)(16526019)(55016002)(8676002)(68736007)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3458; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR07MB3458; 23:xXqGJzGSG84PIOKiv600fh4NAZc8rXnglKduKV7rU?= =?us-ascii?Q?xCJkedT77TagB//Vr+xiGKMPvqg7rIXHmpiloR/dc5oLRYB+dOWRm7mQoGLb?= =?us-ascii?Q?yg6wDTyEuKDqKsdPKPSDYE7VQZRF9UV9VUJt7K1XX393d43LoVDfoQEWV/8O?= =?us-ascii?Q?SiTab1RxvU8gptzPkuFBwSfytjEOlDXxWmlId0yOgH+THN4ZUMjOjQRh25El?= =?us-ascii?Q?g3y+v0jPqpuV1GZOYBxsFllE+o2Dtd3gfP8l+jFC+9R8Hn2c90yOOdyIVzjr?= =?us-ascii?Q?c+le98Cr559T8ZMY4oym0MKoNyH85VXtOWM0e9XSAHIQnQ+ZX+uol07IezkP?= =?us-ascii?Q?aBCfnle6m3bkZgIT5mmHM7/z/lPI7BIxfBZvi/IQZqNJpUP63iCOtJSfY5a0?= =?us-ascii?Q?kAT8qqmvWKs896pFs1sXgr68OZv2oQOWmy47ZcfA+NFmEvOMAkAtQHSOnDMT?= =?us-ascii?Q?EK93TAc/jObBzQqzUr5Ok6jjXV4EW2tViS6gYvCUbcSebuWGTnA4dflieNBh?= =?us-ascii?Q?8Dggtmelld3RSR69g6+fK4TeCcfRLFwf5Xa9lTjztg3kgEIDLD06unPHHxIl?= =?us-ascii?Q?Rff7v7e9s9Hqn7AFqh+uKtyDccgnFlaoF44vCLNJ1L8ngEXTx6kj7kq/hxnU?= =?us-ascii?Q?msP7D61XXcLYJyhoogsQtRVXrZHz2jF7mQx3tdecX5qbuviSINoDdbM6WBq3?= =?us-ascii?Q?1z2uKh6SDyCEBap31YwquWQCpcbfK4txGjYlRmtIdsc5+rN0bWQEwL2crBzz?= =?us-ascii?Q?BAWdEMXUK1JX7UYy1Gjt7Rtx9kVADurEaohdMK+hOEoL7n0MxZjzuYGQDhRq?= =?us-ascii?Q?0LtbBPmTgl3at0e3aZy9l4U/k9sXKACn2nJUkSLLgFzizVWnoiGgG31gNw4F?= =?us-ascii?Q?YrMz9VHqi5xni890UifI3FiOfhP+gwq0q6k4KPbosr5P+ZY38uFbDkehGZSt?= =?us-ascii?Q?fDXN3R6cLlSUAnaZB5YPWecp4K11imhXt8dCrnojpT/pey21rg27QroAtkna?= =?us-ascii?Q?xzkjmSAVsvgCIdRT85+31myhtxqo8q9403ErKjMNDBBji8FeXAIqguyd8xdv?= =?us-ascii?Q?ce0qY5geQDqkxCyaoC9/F+CyYcPWKWbOugORXoev8E58TUoAOZAqa6Bggeaj?= =?us-ascii?Q?HpvwPQGBCwU+W5hxOSRasdr8tOaixJpvgCXusIcnaXVUQLF0Ca5CL03KFTGg?= =?us-ascii?Q?p2xyxmduOMGZMtcxHGDfop/be7PG794CEMnG1xNvaZ6yMFbc/pguOOWpQWNl?= =?us-ascii?Q?pm+fD0sdmVbu1D22oc8047Y66CvVrjNh/qfCC9emnDIvaaqoN+4vK5pU+7oO?= =?us-ascii?B?QT09?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3458; 6:IAUce2PDpqajGed2BqYJjDAuKn0Yayya9dpD5+/1aMIdk7ivHCHaniujdUnnR+rScvp96jKdbGXc1WikjtAKdZkv8rPTb6XGPSyna2uwWYH4WcW2mBzA2A8eVLySIzlTR9HxfFBmZ4CMmNL+U7bmXZg0lwEzbYr2TpqjSCCmb9sC/5Gsovl8Mghcpm2eSI3ReWKh345b/HqkZTOO26ZdCOia+xE1XYRhd0N60Gc7BcMP/knbGKPeMZn0X+t0q7DWnMRVqd9rCoZCeIhomBH9et4M0d1Jp6OMBjIHnO04JKfd132AuQH/UNwovqUvyeyNOVXtnwHwVt2HY6KNR5bflw+cSufBkubv26Vt11G6ZK4=; 5:Bfpw3NcsIGqA2IK6GF0aZ/gIOYKotFdXmHIq/ZeWvwGHl9Ic90UNofQOZw/57SwxxAyt0mUTBthDdKCoSTxTLVYlvE2O12blWrgLy86Ww6/VBJfga51ycSlWtV/E1tLdz4Mnj7b3o8Y7bNeiIDwfoyu3yOPZbwBYsn0v6w5qmpc=; 24:2t8xONYUCxYOiz2prultTWyKxUh6OZvs39NOAqJCL13P8UdsCugiCTV/yl7v60t/iwuniVMiBF/Q5DHXY6puSQGX46eGHLDz3132tYhyx9k=; 7:sGqdHsoFx7MtLfv62XrOh3v6euWP6IPLnKvYAFj9bZ9TgSI8Do7Y1EaB1ODWahAuPbtOdMljpypnAlmS+XN4x2qMObTp5kxtTO/3cvRquC/1M9P5AA+SfhE8hKYjGUa/lKOOzACgr0XDBd6tsuBJhsKu5f18+NJevHBD9bk0HPsy4eB0tDr7FP0JnF2u1iD9I+WJdzlkS3kElL5psQ8VtvunURfdU4at8+MCEq+/di+YO/Oj8qwvj3+/5Sv2cYat SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2018 05:27:32.2249 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a041573e-1eb4-4e64-4b28-08d5647d80c8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3458 Subject: Re: [dpdk-dev] [PATCH] net/octeontx: disable PMD for old compilers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 05:27:36 -0000 On Thu, Jan 25, 2018 at 01:58:32PM +0000, Ferruh Yigit wrote: > On 1/23/2018 4:22 PM, Pavan Nikhilesh wrote: > > Disable for clang < 4.0 as it doesn't support the following > > arm machine directives: > > > > .cpu > > > > This also disables event octeontx as it depends on net octeontx. > > > > Signed-off-by: Pavan Nikhilesh > > <...> > > > @@ -20,3 +20,8 @@ CLANG_MINOR_VERSION := $(shell echo $(CLANG_VERSION) | cut -f2 -d.) > > ifeq ($(shell test $(CLANG_MAJOR_VERSION)$(CLANG_MINOR_VERSION) -lt 35 && echo 1), 1) > > CC_SUPPORTS_Z := false > > endif > > + > > +ifeq ($(shell test $(CLANG_MAJOR_VERSION)$(CLANG_MINOR_VERSION) -lt 40 && echo 1), 1) > > + CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d > > + CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d > > +endif > > I remember we did this before but this is ugly. > > Can it be done in a generic way that compiler dependencies defined in the PMD > Makefile and during config PMD may be disable based on dependency and > environment. If there is no dependency PMD will not do anything special, does it > make sense? Makes sense, Will disable compiler dependent code in PMD makefile. Thanks, Pavan.