From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 46D141B1CA for ; Fri, 26 Jan 2018 18:03:20 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id 141so22403973wme.3 for ; Fri, 26 Jan 2018 09:03:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5bjrXN3Sj5Ji/BU3okhJ8nm1IuHkpli5XmbLFJNJz5I=; b=za96KHKt++X8HF25zAoom3CFR2tkcAi3uU9jhmNnHRw+ylPiO+awQV87DES9QFEJ8Y 5gY655wOTznE2GmTKPRHZ8S2Hj/JBhWtFUoK2xfeNOPBG3GV9kg38G2B/nvcNR0FSjU4 jfoqVT3Lj3m1ltdQrgOaU9AhAcvnSqJsNSXKC4mZ++nPtMnIHCmGg1FsdNa7HMGnHEfv 3y/OOb4U8H875Zj1kaq+Ejwxad8B+ZYK4kUVk15Vo+62tv/kOsV+CkFig7RYydRRthOA 0PybNLOcWw1UQepfnU9huCFQ8222mkO8z4D7i7E9ufzjTMGP/IR1tcz9nrJLSgrMgqDp sgmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5bjrXN3Sj5Ji/BU3okhJ8nm1IuHkpli5XmbLFJNJz5I=; b=h9CsIbYgdRsTX/sqXQqIlxUTb0eSPInxsKaTHm4N6mNL2y2LYNK2T/g3KtSSSvU0VI ZJglhagTZ64yWl3Vqeisj+Su/wXS1kVDAMnSlMZnK4p4cjO8ke0l3k2Y0Bx/5JmVcRhG mxym5JVGFdWAhCjl814dhUmDYvCEK1GX5Ml5BwFYTJIG/Ymy4o2xelyUiWhedikUXE7l /Diwhw4AC/1EanPKfE5y1j+pREv6vjSyPrZAmnLS62AmAsm3XnSRXRFUd/M9CFQYU0mU GiLm7h9xt3E5EvRQp++kNJilshAEMMbvHzf5tdqUv7g/7GcBr5iIWY+kboYQFquuOZs8 cIZQ== X-Gm-Message-State: AKwxytegttClfV1Oi+5Vt0hbrQRa/Xv2Kj5W4bQfW9c5HhM8XTUcawkf wuDzapE/WcSRmaLGoEzdaqFo/w== X-Google-Smtp-Source: AH8x225SDbLKXnnl4phFG6DIcO/BsgSEVIiQ+wRDzylC+IwuIHYXVTM86+X0haFwAVhZyeSuxdgOTA== X-Received: by 10.80.182.103 with SMTP id c36mr33480580ede.57.1516986200038; Fri, 26 Jan 2018 09:03:20 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id x20sm2833439edm.47.2018.01.26.09.03.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jan 2018 09:03:19 -0800 (PST) Date: Fri, 26 Jan 2018 18:03:07 +0100 From: Adrien Mazarguil To: Moti Haimovsky Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20180126170307.GZ4256@6wind.com> References: <1515323086-100332-1-git-send-email-motih@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515323086-100332-1-git-send-email-motih@mellanox.com> Subject: Re: [dpdk-dev] [PATCH] net/mlx4: fix no broadcasts reception in promisc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 17:03:20 -0000 Hi Moti, On Sun, Jan 07, 2018 at 01:04:46PM +0200, Moti Haimovsky wrote: > This patch fixes the issue of mlx4 not receiving broadcast packets > when configured to work promiscuous mode. Also in allmulticast mode, right? Both IBV_FLOW_ATTR_MC_DEFAULT and IBV_FLOW_ATTR_ALL_DEFAULT priorities are too low and may end up in this situation. You could add it usually occurs on VFs. > Fixes: eacaac7bae36 ("net/mlx4: restore promisc and allmulti support") > Cc: stable@dpdk.org > > Signed-off-by: Moti Haimovsky If you confirm this problem covers allmulticast mode, please update the commit log. Otherwise, patch looks good, thanks. Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND