DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Erez Ferber <erezf@mellanox.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix MTU update Changing the MTU is not related to changing the number of segments, activating or not the multi-segment support should be handled by the application.
Date: Mon, 29 Jan 2018 09:16:14 +0100	[thread overview]
Message-ID: <20180129081614.yr5vxg3zrdn2vkab@laranjeiro-vm.dev.6wind.com> (raw)
In-Reply-To: <1517146787-7918-1-git-send-email-erezf@mellanox.com>

Hi Erez,

On Sun, Jan 28, 2018 at 03:39:47PM +0200, Erez Ferber wrote:
> This is a backport based on commit
> a0edafe4099b1ef139242abb7baa2c2a48b83fd2

There is some issues in this commit, first the title line exceed the
75 characters.

Second it is submitted on the dev mailing list whereas it seems to be
targeting a stable branch, in should have been posted on
stable@dpdk.org and according to the sha-1 I would say the target is
the 17.08.

Can you make things clearer?

> Signed-off-by: Erez Ferber <erezf@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_ethdev.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
> index c0f73e9..f73d26e 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -930,9 +930,7 @@ recover:
>  		/* Provide new values to rxq_setup(). */
>  		dev->data->dev_conf.rxmode.jumbo_frame = sp;
>  		dev->data->dev_conf.rxmode.max_rx_pkt_len = max_frame_len;
> -		if (rehash)
> -			ret = rxq_rehash(dev, rxq_ctrl);
> -		else
> +		if (!rehash)
>  			ret = rxq_ctrl_setup(dev, rxq_ctrl, 1 << rxq->elts_n,
>  					     rxq_ctrl->socket, NULL, rxq->mp);
>  		if (!ret)
> -- 
> 1.8.2.3

-- 
Nélio Laranjeiro
6WIND

      reply	other threads:[~2018-01-29  8:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-28 13:39 Erez Ferber
2018-01-29  8:16 ` Nélio Laranjeiro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180129081614.yr5vxg3zrdn2vkab@laranjeiro-vm.dev.6wind.com \
    --to=nelio.laranjeiro@6wind.com \
    --cc=dev@dpdk.org \
    --cc=erezf@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).