From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id E211D1B364 for ; Mon, 29 Jan 2018 09:16:03 +0100 (CET) Received: by mail-wr0-f193.google.com with SMTP id s5so6145238wra.0 for ; Mon, 29 Jan 2018 00:16:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=3VvsRjls5M05fp7BXKkCDz/w+Vu5xRtvxvPqGC+OJ+A=; b=AY24iDBxQvlOx7PYbB+jjBaVolHfSaIzA6kMWKbDMgKPZfm/eEwidZIxGHiC65xgMK vQbC/pmr2gwsdkKZO9Sme3IwyysmV/EkHQ8NQHm21CQtqpyAjIYFfeeY639+WyZc/2rC OjefN3qzqEI7KmgCqirClm3mQZS+2BshAoiUkslR6tMW+fjXrYQiAUBXVzyJUib9MdF5 2IwsVz0knMkSHxC9fYd7AXTsikVXLYI0m8TUnTAshSswERoI+EdIYWVqA8oWTejtKqdA 5WTOTI54hgGBusX6Yn0S1pUJluj8laLyD+Q0YxhcTh03PR9VWekwOX9yni9k0T1N72N1 a5AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=3VvsRjls5M05fp7BXKkCDz/w+Vu5xRtvxvPqGC+OJ+A=; b=hF2BSmYQZIhagtXo/F1IbgEIIVzlGSZ+jHs5JE3s3hp8QsCsirUHZeNHjiKyGJ2ydz ow68zr9U+f92jgP3ystDJKG6j49htBbQoAlWrPa7K/ls82i7RXQFYgkGFjP+UJ2gNMYd jO0KL2P2lQVBRyaFkeg0G5e157Sv59AAJEIoi88Qnf10lt0rSAtvvKhwyHaekEkQbpwN XYLLogYHa8dFPQa1SqFoXBKMh59lGtZ9m1SH/kOBCSPwOnQkOFqnyDRgL3T0oSBN2hfH vKInTKm1m2jh6WiD5kOsFERYAJS4U9SurZepTJCb+STuSY5ygXKqoAt8dYp1fgLRCzkL 3h6g== X-Gm-Message-State: AKwxytd/Keu4homNK3x4wBLaRvgTtnxBRyua+SfvleE56576UjoDh1W6 CPFC80XLz2X1ML9Cv9Bp2GKH88AMTw== X-Google-Smtp-Source: AH8x2279lRuN+ejSTdk2s/PTw69SSBYKequhSv9C7liSvSMed98lgB5/hdGxouGfntFQEJIJuZjoxA== X-Received: by 10.223.134.242 with SMTP id 47mr19869899wry.227.1517213763633; Mon, 29 Jan 2018 00:16:03 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 78sm8982340wmm.22.2018.01.29.00.16.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Jan 2018 00:16:03 -0800 (PST) Date: Mon, 29 Jan 2018 09:16:14 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Erez Ferber Cc: dev@dpdk.org Message-ID: <20180129081614.yr5vxg3zrdn2vkab@laranjeiro-vm.dev.6wind.com> References: <1517146787-7918-1-git-send-email-erezf@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1517146787-7918-1-git-send-email-erezf@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix MTU update Changing the MTU is not related to changing the number of segments, activating or not the multi-segment support should be handled by the application. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 08:16:04 -0000 Hi Erez, On Sun, Jan 28, 2018 at 03:39:47PM +0200, Erez Ferber wrote: > This is a backport based on commit > a0edafe4099b1ef139242abb7baa2c2a48b83fd2 There is some issues in this commit, first the title line exceed the 75 characters. Second it is submitted on the dev mailing list whereas it seems to be targeting a stable branch, in should have been posted on stable@dpdk.org and according to the sha-1 I would say the target is the 17.08. Can you make things clearer? > Signed-off-by: Erez Ferber > --- > drivers/net/mlx5/mlx5_ethdev.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c > index c0f73e9..f73d26e 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -930,9 +930,7 @@ recover: > /* Provide new values to rxq_setup(). */ > dev->data->dev_conf.rxmode.jumbo_frame = sp; > dev->data->dev_conf.rxmode.max_rx_pkt_len = max_frame_len; > - if (rehash) > - ret = rxq_rehash(dev, rxq_ctrl); > - else > + if (!rehash) > ret = rxq_ctrl_setup(dev, rxq_ctrl, 1 << rxq->elts_n, > rxq_ctrl->socket, NULL, rxq->mp); > if (!ret) > -- > 1.8.2.3 -- Nélio Laranjeiro 6WIND