From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 5C53D1B376
 for <dev@dpdk.org>; Mon, 29 Jan 2018 09:25:13 +0100 (CET)
Received: from lfbn-lil-1-110-231.w90-45.abo.wanadoo.fr ([90.45.197.231]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.89) (envelope-from <olivier.matz@6wind.com>)
 id 1eg4kg-0000Ka-8f; Mon, 29 Jan 2018 09:25:19 +0100
Received: by droids-corp.org (sSMTP sendmail emulation);
 Mon, 29 Jan 2018 09:25:07 +0100
Date: Mon, 29 Jan 2018 09:25:07 +0100
From: Olivier Matz <olivier.matz@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20180129082507.qlbqbnamhfye5ghk@platinum>
References: <1516848417-77912-1-git-send-email-wenzhuo.lu@intel.com>
 <20180125104005.upmo7l4imeg2oyj7@glumotte.dev.6wind.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09093B720B5F@shsmsx102.ccr.corp.intel.com>
 <460287e3-db94-b677-e262-4c45a59fb486@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <460287e3-db94-b677-e262-4c45a59fb486@intel.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [RFC] lib/librte_ether: add a return value for MAC
 set ops
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Jan 2018 08:25:13 -0000

Hi,

On Fri, Jan 26, 2018 at 04:54:43PM +0000, Ferruh Yigit wrote:
> On 1/26/2018 2:19 AM, Lu, Wenzhuo wrote:
> > Hi Olivier,
> > 
> > 
> >> -----Original Message-----
> >> From: Olivier Matz [mailto:olivier.matz@6wind.com]
> >> Sent: Thursday, January 25, 2018 6:40 PM
> >> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> >> Cc: dev@dpdk.org
> >> Subject: Re: [dpdk-dev] [RFC] lib/librte_ether: add a return value for MAC set
> >> ops
> >>
> >> Hi Wenzhuo,
> >>
> >> On Thu, Jan 25, 2018 at 10:46:57AM +0800, Wenzhuo Lu wrote:
> >>> Setting the default MAC address may fail on many NICs.
> >>> But the ops return void. So, even it failed, RTE changes the MAC
> >>> address and APP doesn't know the failure.
> >>>
> >>> It's not real patch, just show the idea to add a return value for the
> >>> ops.
> >>
> >> Thank you for taking care of this. I had some plans to work on it too, as
> >> discussed here:
> >> https://dpdk.org/dev/patchwork/patch/32284/
> > Sorry, didn't notice that. Glad to know you're working on that. So you'll continue, right?
> 
> Plan was send PMD fixes and deprecation notice on this release and send fix next
> release [1].
> 
> I think PMD fixes are merged now, but deprecation notice not send yet.
> 
> [1]
> https://dpdk.org/ml/archives/dev/2018-January/085195.html

Yes, I'll send the deprecation notice today.