From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 61B4E1B69A for <dev@dpdk.org>; Mon, 29 Jan 2018 13:04:49 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2018 04:04:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,429,1511856000"; d="scan'208";a="13849979" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.77]) by orsmga008.jf.intel.com with SMTP; 29 Jan 2018 04:04:46 -0800 Received: by (sSMTP sendmail emulation); Mon, 29 Jan 2018 12:04:45 +0000 Date: Mon, 29 Jan 2018 12:04:45 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: "Van Haaren, Harry" <harry.van.haaren@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Varghese, Vipin" <vipin.varghese@intel.com> Message-ID: <20180129120444.GA18816@bricha3-MOBL3.ger.corp.intel.com> References: <1517077877-53654-1-git-send-email-harry.van.haaren@intel.com> <3800883.jMHuFJQnlm@xps> <E923DB57A917B54B9182A2E928D00FA651008AAE@IRSMSX102.ger.corp.intel.com> <8777922.WAhnjB1RAy@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8777922.WAhnjB1RAy@xps> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH v2 2/4] eal: add function to release internal resources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 29 Jan 2018 12:04:49 -0000 On Mon, Jan 29, 2018 at 12:55:35PM +0100, Thomas Monjalon wrote: > 29/01/2018 12:10, Van Haaren, Harry: > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > Sent: Monday, January 29, 2018 10:56 AM > > > To: Van Haaren, Harry <harry.van.haaren@intel.com> > > > Cc: dev@dpdk.org; Varghese, Vipin <vipin.varghese@intel.com> > > > Subject: Re: [PATCH v2 2/4] eal: add function to release internal resources > > > > > > 29/01/2018 11:45, Harry van Haaren: > > > > --- a/doc/guides/prog_guide/env_abstraction_layer.rst > > > > +++ b/doc/guides/prog_guide/env_abstraction_layer.rst > > > > +Finalizing and Cleanup > > > > +~~~~~~~~~~~~~~~~~~~~~~ > > > > + > > > > +During the initialization of EAL resources such as hugepage backed memory > > > can be > > > > +allocated by core components. The memory allocated during > > > ``rte_eal_init()`` > > > > +can be released by calling the ``rte_eal_finalize()`` function. Refer to > > > the > > > > +API documentation for details. > > > > > > About naming, what is better between > > > rte_eal_finalize() and > > > rte_eal_cleanup() ? > > > I tend to think that "cleanup" is more descriptive. > > > > Sure cleanup() is fine for me, I'll spin a v3 with the function name change. > > Harry, it is a real question! > If someone thinks "finalize" is better, I would like to hear it > because we may use the same wording in more DPDK functions. > I like finalize better. 1) Both initialize and finalize sound similar as both end in "ize" so sound like they are a pair 2) The use of .init and .fini elf sessions are precedent for the naming /Bruce