From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 3125F1B3EB for ; Mon, 29 Jan 2018 15:29:31 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 889688E3FE; Mon, 29 Jan 2018 14:29:30 +0000 (UTC) Received: from localhost (dhcp-192-241.str.redhat.com [10.33.192.241]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1870C18A3E; Mon, 29 Jan 2018 14:28:50 +0000 (UTC) Date: Mon, 29 Jan 2018 15:28:49 +0100 From: Jens Freimann To: Yuanhan Liu Cc: dev@dpdk.org, tiwei.bie@intel.com, maxime.coquelin@redhat.com, mst@redhat.com Message-ID: <20180129142849.wjnghi2ver4szv6k@dhcp-192-241.str.redhat.com> References: <20180129141143.13437-1-jfreimann@redhat.com> <20180129141143.13437-10-jfreimann@redhat.com> <20180129142449.GL29540@yliu-mob> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20180129142449.GL29540@yliu-mob> User-Agent: NeoMutt/20171215 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 29 Jan 2018 14:29:30 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 09/14] vhost: add virtio 1.1 defines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 14:29:31 -0000 On Mon, Jan 29, 2018 at 10:24:49PM +0800, Yuanhan Liu wrote: >On Mon, Jan 29, 2018 at 03:11:38PM +0100, Jens Freimann wrote: >> This should actually be in the kernel header file, but it isn't >> yet. For now let's use our own headers. >> >> Signed-off-by: Jens Freimann >> --- >> lib/librte_vhost/vhost.h | 4 +++- >> lib/librte_vhost/virtio-1.1.h | 20 ++++++++++++++++++++ >> 2 files changed, 23 insertions(+), 1 deletion(-) >> create mode 100644 lib/librte_vhost/virtio-1.1.h >> >> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h >> index e52a9b69c..152e8bce1 100644 >> --- a/lib/librte_vhost/vhost.h >> +++ b/lib/librte_vhost/vhost.h >> @@ -167,7 +167,9 @@ struct vhost_msg { >> #ifndef VIRTIO_F_VERSION_1 >> #define VIRTIO_F_VERSION_1 32 >> #endif >> - >> +#ifndef VIRTIO_F_PACKED >> + #define VIRTIO_F_PACKED 34 >> +#endif >> #define VHOST_USER_F_PROTOCOL_FEATURES 30 >> >> /* Features supported by this builtin vhost-user net driver. */ >> diff --git a/lib/librte_vhost/virtio-1.1.h b/lib/librte_vhost/virtio-1.1.h >> new file mode 100644 >> index 000000000..5ca0bc33f >> --- /dev/null >> +++ b/lib/librte_vhost/virtio-1.1.h >> @@ -0,0 +1,20 @@ >> +#ifndef __VIRTIO_1_1_H >> +#define __VIRTIO_1_1_H >> + >> +#define VRING_DESC_F_NEXT 1 >> +#define VRING_DESC_F_WRITE 2 >> +#define VRING_DESC_F_INDIRECT 4 >> + >> +#define VIRTQ_DESC_F_AVAIL 7 >> +#define VIRTQ_DESC_F_USED 15 >> +#define DESC_USED (1ULL << VIRTQ_DESC_F_USED) >> +#define DESC_AVAIL (1ULL << VIRTQ_DESC_F_AVAIL) >> + >> +struct vring_desc_1_1 { > >Is it how it's named in the spec? If not, I'm wondering "vring_desc_packed" >might be a better name? > >If so, we could rename others, like rename "_dequeue_1_1" to "_dequeue_packed". I tried to name everything _packed, but obviously missed this one. Will change it in the next version. Thanks! regards, Jens