From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mleitner@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 7938E1B6D6
 for <dev@dpdk.org>; Tue, 30 Jan 2018 18:55:01 +0100 (CET)
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
 [10.5.11.12])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id D0F3F18B31D;
 Tue, 30 Jan 2018 17:55:00 +0000 (UTC)
Received: from localhost.localdomain (ovpn-204-95.brq.redhat.com
 [10.40.204.95])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 9CAC960BE3;
 Tue, 30 Jan 2018 17:55:00 +0000 (UTC)
Received: by localhost.localdomain (Postfix, from userid 1000)
 id 46C2A180A3A; Tue, 30 Jan 2018 15:54:59 -0200 (-02)
Date: Tue, 30 Jan 2018 15:54:59 -0200
From: Marcelo Ricardo Leitner <mleitner@redhat.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: Shahaf Shuler <shahafs@mellanox.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>, dev@dpdk.org
Message-ID: <20180130175459.GP3494@localhost.localdomain>
References: <20180129170310.14142-1-adrien.mazarguil@6wind.com>
 <20180130144512.21872-1-adrien.mazarguil@6wind.com>
 <20180130144512.21872-3-adrien.mazarguil@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180130144512.21872-3-adrien.mazarguil@6wind.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.29]); Tue, 30 Jan 2018 17:55:00 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH v4 2/4] net/mlx4: spawn rdma-core dependency
	plug-in
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Jan 2018 17:55:01 -0000

On Tue, Jan 30, 2018 at 04:34:54PM +0100, Adrien Mazarguil wrote:
...
> +	handle = dlopen(MLX4_GLUE, RTLD_LAZY);
> +	if (!handle) {
> +		rte_errno = EINVAL;
> +		dlmsg = dlerror();
> +		if (dlmsg)
> +			ERROR("cannot load glue library: %s", dlmsg);
> +		goto glue_error;
> +	}
> +	sym = dlsym(handle, "mlx4_glue");
> +	if (!sym || !*sym) {
> +		rte_errno = EINVAL;
> +		dlmsg = dlerror();
> +		if (dlmsg)
> +			ERROR("cannot resolve glue symbol: %s", dlmsg);
> +		goto glue_error;
> +	}
> +	mlx4_glue = *sym;
> +	return 0;
> +glue_error:
> +	if (handle)
> +		dlclose(handle);
> +	ERROR("cannot initialize PMD due to missing run-time"
> +	      " dependency on rdma-core libraries (libibverbs,"
> +	      " libmlx4)");

Patches are mostly LGTM. The only concern left is if ERROR is the
appropriate log level here. I know it's a fatal error for Mellanox
cards, but Considering DPDK will load all drivers for probing the hw,
these messages will show up even when using other cards. So what about
switching to WARNING instead? Should be less confusing to the users
then.

  Marcelo