From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0041.outbound.protection.outlook.com [104.47.37.41]) by dpdk.org (Postfix) with ESMTP id 075031B76B for ; Wed, 31 Jan 2018 11:24:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=tvdJirmkcKsTphY9urLc+p7DVcXq26pwrSrFrVYy0/8=; b=b3Mj+Pavr+/F5GKfECspdRUSoQ/NVkrpjqdlDQFreaRlck6v21ehtisWsJ4co70Awx2SXezMWPMXmv6HGq63ljXHMIpxgryyDu34dyUPjLw8e5UQfKO27HCIDDeS3IZV9gbXgf0ctaEDERt68VDqK6HyANierbMdeEORU4jrUYU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (106.201.47.68) by BN3PR07MB2513.namprd07.prod.outlook.com (10.167.4.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Wed, 31 Jan 2018 10:24:12 +0000 Date: Wed, 31 Jan 2018 15:53:54 +0530 From: Jerin Jacob To: Ophir Munk Cc: "dev@dpdk.org" , Thomas Monjalon , Pascal Mazon , Jan Viktorin , Jianbo Liu Message-ID: <20180131102352.GA24477@jerin> References: <20180131051408.3652-1-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) X-Originating-IP: [106.201.47.68] X-ClientProxiedBy: MA1PR0101CA0013.INDPRD01.PROD.OUTLOOK.COM (52.134.136.151) To BN3PR07MB2513.namprd07.prod.outlook.com (10.167.4.138) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bb53b91f-4d30-4f46-88e1-08d56894c7f8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 3:u0t+wFih3Ow4WLIfK8RaF7h5NBkSh6zo5HWY+CROsw2Tw3INiDFAR1LEtBK7jmElCLGlgjfgEiWbnoM+tW9ZM8a5KYdPBsZHqvTBXVVwINiDmh238IEdDcfoWxMKtiDwbSWz7cAsaMzJsSV5pPhaapEsz4MG3L01OGzOerNpGGJJ4k0EzIGU939OnqNbuw/OVjIdUifs9Ygs8SNt3sWwmNmgJhKTP6DXgaMU9gJY208+au7FjgySqS0oxB0AMRI3; 25:1+aHp6yqQGFoniomW9oENqRKqnXlZu/+pfg+6QIB1zIXV72EaSZH48UhCEdfUFl0Cf618DF/70J5Wqwyeg4P8S+9SRPQGBAOnaF7xvPcdavmcJgsSbK2brMvwwavwAU4l8bEoy3tAy0pqJKotwW6S1rVnQmcMcFONWqlxYs/2Fxzs24PGKYezZyi8GJBcPmRgaq4u/oDyQpI8is4UJ20pKlx1fLIp/B+VklyNKZ3EPhPJm9twbCJhpbciAbnq/q2hTFx4ZGWn607neYHUdAUf0sHQeht5j3b5us0e8SVq9h0ESunzHaZ98uzxdAzkapzMZ8hMWnwF7z5jzyR6zV2Vw==; 31:3UtyaApBXPT0rDCPU8vyFDRvzKop8Rp8HlV07QnL7e91aataz4OmnX8F44UFN13KMwEvMuCfmNGCqCnjQU9Sn2F4kCyclntnV0FtidaUlpdYvJfEGjFIQ854w+Gps6Gq+G/JLjCNksf9YOA3VE2dQks/uFPMQcO55zNAzhAjys9JB0tWn5Y4DKfK5MTkPRb4L5Iug87GEap8SN1Rm1L60t5pdQJw6SlOv7tZixjGqU0= X-MS-TrafficTypeDiagnostic: BN3PR07MB2513: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 20:A/5AJuAhB4CA/vxgjrMYfmb48AcubNUIcgD0DrjAk3yFYETPcvZYC6Z+9V+d9kDeW5qr56AZa8lZD4izJh24OcK4n3HK+trYKZiqQFa/H4tU5+Qut+L3a/47e5xxwIA9nOaZ2EuTD+1Z7DDWTJ64+Dz7w23bSbybUg/o/n97bjEYHMIxCq+MvnJJeEA/RbhmhZizQ8c6j7dK549TLyt2Vf89FdQWGs2rl96F0BMmlWnEK+EU/UpucPuUnc0LZFSB1d/AuJbn8qnrVWqH/dvZ9iLW4yoK9r5GUfgwlojB9VfOu2+jNf+BmnbqX3bUrcNWj/I6YHO/p3zXvfmjuX0q7/2B4FSp4PXwsl1H4Hgvj9nsM+k7oS6PmJcjEC0B+WOBJ/QTDZY7mq32i/b8Iqra4HeqLViNyoblLp3TN5gwBxgWolXCbnA1dmr2PYu8+PepHY/6Y+SOJnouvAoYa7vgfLu62jSBKixjk7m0oLcKQUga5qB8MEYM+DPIVqgcXQDrWmqbsyvtip7pIS0hB4i8FkeicarL0T6B8zDPoWfB1A8pPYwiv+/lIE6fFp2irgPT5tzdNain6lD8HIREvpNSNYcX0UQ07qbkt0+08waUbxY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(42262312472803)(58145275503218); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3231101)(2400082)(944501161)(3002001)(93006095)(10201501046)(6041288)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(6072148)(201708071742011); SRVR:BN3PR07MB2513; BCL:0; PCL:0; RULEID:; SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 4:lkWF6m1tnag9b8nPXGz5bt/CK0txSncO3zmJBT+2GiTW6Vm21XIxDm32fCQKWV6sK3aBoy1ugx8VcXRNiJZ23lLty/1GDtab576aVROTKRbsBJMdbCejVPm505IUNjbvFv3yAggnbmM3gSC+8gRisGUoNPT8XrV8CNJSPM5X6m6Je8GAIRA2OIG5IKphHhRPAJZWMyJMD6Z6ZebQGxVVq85sSzWb5+vNZMEyFzP/Rq8Wf16aNoo+g2Kt+6N0JNiq9hbzYNWSBG/AsBegI6PCuTRFs3ubxYIs7eUBj6SKhfYkNxfzwZ8WZxbBZMuOXw7GeQhDwYuAvWCiI9/xVjJm8ihjj0krBYLkjWtL1kKT4YPrVPT8Nu44SYNeYTtuqRzN X-Forefront-PRVS: 056929CBB8 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(346002)(396003)(376002)(366004)(199004)(189003)(13464003)(26005)(55016002)(6306002)(33896004)(105586002)(316002)(9686003)(53546011)(23676004)(2486003)(6246003)(186003)(386003)(76176011)(59450400001)(478600001)(6496006)(52116002)(58126008)(3846002)(16526019)(5660300001)(52146003)(81166006)(8676002)(50466002)(8936002)(305945005)(1076002)(55236004)(6666003)(42882006)(2950100002)(6916009)(81156014)(6116002)(54906003)(5009440100003)(53936002)(66066001)(2870700001)(47776003)(97736004)(106356001)(2906002)(966005)(83506002)(68736007)(33716001)(229853002)(4326008)(25786009)(72206003)(33656002)(7736002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2513; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjA3TUIyNTEzOzIzOkZtTXgvU25idDE1YmRLVkN2UEZqMEdMNEY5?= =?utf-8?B?aFNnWDEvNFVoeUlkRkZVbW5wT3FmdExBeXNhdHNjVmMyZHBIUTVITUVMMVJn?= =?utf-8?B?WGVheDBleC93TDRHVnFiZHNad3kzbVBrRUpLYW13bjF5Ti8xeVZWT3JCTkRO?= =?utf-8?B?MmNIRVRhL2hvUStHcWhGbWNiWDBIYzdHSTBtTGhZV28vY2d4VmxDZ2ZaYk56?= =?utf-8?B?am90enp1QUNDZnBlbWt6bnZMVmQrMnQxUzZ3ek4ydTh4TFp3Z25OU1lPRWtn?= =?utf-8?B?azluRlNNamorL084NytPY2ZybFREVmpqRHQraVl5NCs1OXJHN2NrTTV6UkdP?= =?utf-8?B?Qks4YWNaL1JSam90RlB0eGp0cHl0b0N6UkVYVFFjdUt1UFRBKzhqTU9ZSW9k?= =?utf-8?B?VjhPRTBQbDhJdDJMZU1rMTladHM2NGdGRVhBcUJiUXRsL3Ixb3gzZytNMEVE?= =?utf-8?B?TGVibUNhUmNPNThLKzhCRVRuQlg0bGUveUZjVk9aSWlBRFVkVXl3T3VIQVBa?= =?utf-8?B?M0IwRWU0REF3R05ISEpFWWxWMjU0QU1FRTBjbFk0eGtFQ090V0JCVWQ4aVFH?= =?utf-8?B?S01ZOUZZSlduZVVJTktSQ2NuYzZ2azYvWXlkOUxnOWIrQUV3Sy9qZDF4RlQ0?= =?utf-8?B?STBid3NERk02U0hDZEgzUmxrN3g2Q29UWlNOcGpuM0h1WUdmcUhIc3gzbHUz?= =?utf-8?B?bUhGek90akpjRndIWW82eTc4U2E0alM1QitYR2FTdWplMWEvL0d5Tk1CTHpZ?= =?utf-8?B?MEVOa1VpdWdxWjRBMFprb08xb1NNUExVbmpGeitYMHBBV1ZRcmF1WEtGRUts?= =?utf-8?B?SFljTzlROEx2QzE4djNxdVNKTy9ESHpYSEljRlg1Vzl3dkpPNzlBcU5KVjB5?= =?utf-8?B?Mmt5QlMvVlRhWTBEZ3E5bDhtNlZnbncxMUlFbWRZd2dkRmZkRk5qeEhpQ25K?= =?utf-8?B?MHIwcXZ4S1lqcmJVRjFUQzJwQkh4MDRHZkxmZThrWmFBUk9UQmJpdmpvajNV?= =?utf-8?B?bkxXanlkWmxzeWdtZ1pPakNJanNWQnptZDU5b1U3bXNDaGo0TFl5UCtMMDV2?= =?utf-8?B?bHBzVkhOcEhzckYyNGVJU1lqS0VKM0Yzak9lWHpiaGx4NUQ2TWZveWI3SjNK?= =?utf-8?B?ZUFSV2pUV3hzV2ZaN2FyUnRrSmp2ZUx3OUJKeEJiK0VsR2NTbnNtWVpJRkZj?= =?utf-8?B?SndxWVFWbnc5Q0VaQTRBMGlnS2dhdVRpK0tROWVzd0FZUXJOZGdsL2djUXZQ?= =?utf-8?B?eUYyT2xQejlIWnk3dEdJVkVPeHVRNDlvdTVXWWhodC9OaCtnTHFJb1d2MUFO?= =?utf-8?B?SkdVbzZZTHo3cEl3dTFEeXpWc3BLUEVCUEMvUUJOZC9TWHBseWxvM1RmWU1y?= =?utf-8?B?dWREQmpzRFFZTzhkbXFyUFAyV0w0SmJDY284RTlCclQxRzRORHhYa2E0dmVQ?= =?utf-8?B?RlEwS0tDZXpFcDJRUVBxUUdMMDZaRkpqNTRmTVpCdW1NaGpuUHVOeVFBc1No?= =?utf-8?B?V1NwN2dWdUpGL3lWOTlDaXRwRFNYZ3Q4bFQvNzhjM3hQc2ZCQXpIR0VrR1Fr?= =?utf-8?B?VXRETk1oZk0xK21ES21QS3phOXVKTjQ2ZnA4UVZyV2FZVUZRR1RiMndFQ3VU?= =?utf-8?B?VkJLblhUaUJrZHdITzlzMG9BNy8raXFWOG5BTGNNNjhORHZpb0hVcWE4M1Ja?= =?utf-8?B?b29BbE1HRkVIRVNIVkNwZmlITWI1UlJWM1YwV1MyVmQrVGNBcm1oRFZEbGZq?= =?utf-8?B?N01aTTFwTm5Xd0g3Ri9jSmVGdmNDck9UNHVtV0t3Y3ZhbExGTC9iOERqbzR0?= =?utf-8?B?aUxiaWp6NzBacFl1aFZ0RHdlWmliY0tVNDFwTnlyUzJmYWRJU0VaaXRiQ1N2?= =?utf-8?B?ZVJnQnF1bVRWYXJPR1J1cTlwUXU3TzEzWStKNXl5QUdkWEdLZVV2TlFBVFlZ?= =?utf-8?B?b0pnUjdhQmk3NFhHME8vY0xtQXFXNkR4dUtkQXowRXRaTnF3Skd1aXBHVVp4?= =?utf-8?B?SXIyVE4yV0djSW0wUnBWZ2t4SDI2anVtR2taZz09?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 6:wIFp5yUoaP87hc+c5E7x7k8CD0TDKy6NW3tQm95VWSliXS11t28T0pJnZIANG+ZtD0rqP0UVc2majFa6CGZ30x4IKiQHLDAYQxXpjwL/swqkh4r0wKMl4uEA2eKm694l2yKmGdtafbtTfRkRJGe+GqQ8yU59LuzPOGf1aO0RTX9HMblXYy0Md+3Ub+h2hx4QRM/NiJZ7+XWq2PRdqJzcsXSvSBzDtSCSokYsBuxdDEwOSgiyj2a16yVL8yB3cWAtuzGbk2X2UuUSSEc2Wngk5joj6hMzMb51AKImXQ49kgzBjhN8xkxHzBBAumr6GyV64zySjpzoKrj+J2oh+u4G5RPsEnQFemyxk51Hg/1p5+A=; 5:roOqpoz7R+xdNkx+bFxZrQrWqBstk/C/fgR7qzbq4GTu2isN2E1btENHY+FBbJApWDxxHl7FeOnY20QWN9ZSWqpYbPdCa+liUnLOzk1WqvCeHsXs0URkTW4aMA1X7WeAh1dAiyQkPRTd5xk4INIPPa4nupGdvCuqewSWKdFgjBw=; 24:B3NowH0fWd6vDi8P7LDyisvA6CTsA3uy0ogUCwVhxL5F+JJXOPDl5c0/Ci5R3AMO0ShpMXfOa18OT3dJE+GGx1ekX6oHOAI50rrnTy//Jb0=; 7:AA5HJW8G3RUp/o/Q9uek4sGeTwS4IzZra+q1iWcP81yVvmye/pFs8NpJdS2UuBLgvtyVhUK1CsG243aJwm3/L1ji/qa43m0izicMbmu2CTXLRJUDvcpOXdyKmnfz+Uo08GISJU1nVOqOeReUWX7+xIlnF8gSFjwmw4utRbTcQDz/5nBt6ooFGWnrlAFKOMYZyQCNdhFLmsr6RagZOaH4SVi6MeQhZ4QSjIgHaDpSnYCZliD+csccXp6Un1f9ZBEv SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2018 10:24:12.8913 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bb53b91f-4d30-4f46-88e1-08d56894c7f8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2513 Subject: Re: [dpdk-dev] [PATCH] net/tap: fix build issue with ARM32 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Jan 2018 10:24:18 -0000 -----Original Message----- > Date: Wed, 31 Jan 2018 09:59:45 +0000 > From: Ophir Munk > To: Jerin Jacob , "dev@dpdk.org" > > CC: Thomas Monjalon , Pascal Mazon > , Jan Viktorin , Jianbo > Liu > Subject: RE: [dpdk-dev] [PATCH] net/tap: fix build issue with ARM32 > > Hi, > Please see comments inline > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > > Sent: Wednesday, January 31, 2018 7:14 AM > > To: dev@dpdk.org > > Cc: Thomas Monjalon ; Jerin Jacob > > ; Pascal Mazon > > ; Jan Viktorin ; > > Jianbo Liu > > Subject: [dpdk-dev] [PATCH] net/tap: fix build issue with ARM32 > > > > arm32 Linux does not support eBPF interface. > > Since tap PMD driver has a dependency on eBPF(the symbol __NR_bpf), > > disabling it armv7 config. > > > > compilation error log: > > In file included from /tmp/dpdk/drivers/net/tap/tap_bpf_api.c:15:0: > > /tmp/dpdk/drivers/net/tap/tap_bpf.h:103:4: error: #error __NR_bpf not > > defined # error __NR_bpf not defined > > ^ > > arm architecture is missing is file drivers/tap/tap_bpf.h > I suggest adding it, for example > > # elif defined(__arm__) > # define __NR_bpf 386 By looking at Linux source code http://elixir.free-electrons.com/linux/v4.15/source/tools/build/feature/test-bpf.c#L6 I am not sure, Is eBPF support available for arm32 support? > > It should work for you. Can you please try it? I don't have access to an arm32 board. I was facing cross compilation build issue with arm32. > If it doesn't work for you, please have a look in this link: > https://sourceforge.net/p/predef/wiki/Architectures/ > where you can see more arm architecture definitions. > You should find the one suitable for you. I guess, it is not just matter of enabling the build for arm32. It should work at runtime too, If some can confirm following addition in the drivers/net/tap/tap_bpf.h works then we can add it. # elif defined(__arm__) # define __NR_bpf 386 > > > /tmp/dpdk/drivers/net/tap/tap_bpf_api.c: In function ‘sys_bpf’: > > /tmp/dpdk/drivers/net/tap/tap_bpf_api.c:92:17: error: ‘__NR_bpf’ > > undeclared (first use in this function) > > return syscall(__NR_bpf, cmd, attr, size); > > ^ > > /tmp/dpdk/drivers/net/tap/tap_bpf_api.c:92:17: note: each undeclared > > identifier is reported only once for each function it appears in > > /tmp/dpdk/drivers/net/tap/tap_bpf_api.c:93:1: error: control reaches end of > > non-void function [-Werror=return-type] } ^ > > cc1: all warnings being treated as errors > > > > Fixes: b02d85e1 ("net/tap: add eBPF API") > > > > Cc: Pascal Mazon > > Cc: Jan Viktorin > > Cc: Jianbo Liu > > > > Signed-off-by: Jerin Jacob > > --- > > config/defconfig_arm-armv7a-linuxapp-gcc | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/config/defconfig_arm-armv7a-linuxapp-gcc > > b/config/defconfig_arm-armv7a-linuxapp-gcc > > index a20b7a85f..4a55bb397 100644 > > --- a/config/defconfig_arm-armv7a-linuxapp-gcc > > +++ b/config/defconfig_arm-armv7a-linuxapp-gcc > > @@ -80,3 +80,4 @@ CONFIG_RTE_LIBRTE_BNX2X_PMD=n > > CONFIG_RTE_LIBRTE_QEDE_PMD=n CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n > > CONFIG_RTE_LIBRTE_AVP_PMD=n > > +CONFIG_RTE_LIBRTE_PMD_TAP=n > > -- > > I suggest fixing the compilation issue by adding the missing architecture system call number > (as suggested above) instead of disabling TAP compilation by default > > > 2.16.1 >