From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0054.outbound.protection.outlook.com [104.47.38.54]) by dpdk.org (Postfix) with ESMTP id A048C2951 for ; Thu, 1 Feb 2018 21:40:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hOqYPz6QJElyQKGBKuG1oB6OMKtlCVw0+P6kFemyDEs=; b=FA81s/glaDgQO4Ffenpxry60BFP44gX07lFZMbsEROJibe4++rwng1CP1UO7mSNfiregILlvoZwsa3e484KDbUxe7sHv9/vnHmrTJO9iMavOF3RI/TiZI2p2/TThWzct7d2OFVWke2G+Lzgtv9l2UlN1YtpwQWo2J/1HIJY16UU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT (117.203.57.68) by MWHPR07MB3469.namprd07.prod.outlook.com (10.164.192.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Thu, 1 Feb 2018 20:40:24 +0000 Date: Fri, 2 Feb 2018 02:10:00 +0530 From: Pavan Nikhilesh To: Hemant Agrawal , "olivier.matz@6wind.com" , "thomas@monjalon.net" , jerin.jacob@caviumnetworks.com Cc: dev@dpdk.org Message-ID: <20180201203959.wi3e56buepnu3px6@Pavan-LT> References: <1517514427-28843-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [117.203.57.68] X-ClientProxiedBy: PN1PR0101CA0016.INDPRD01.PROD.OUTLOOK.COM (10.174.151.26) To MWHPR07MB3469.namprd07.prod.outlook.com (10.164.192.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c9dbf855-ea10-4800-b4b3-08d569b406a0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:MWHPR07MB3469; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3469; 3:U/NN/kuoOZ/nnXxm/28oPz8Sya3bqEgKh+39+qkUSW3snVE3qpcTEby+jVm3rqDc6h6PFpvjh3dvfzk2jh9VkInnYZeftQMrHPHJkoGsK9gy9rZPtxgiVi7XzS0D315Qy11iQ5wsmnCTpAHisAYuFTzc40FUV4XGYCM87RJHys6T+lSlRTXPudey3ViTdDopDsrmhWW3SSOycaRfUKg4hFPGfnef8nPwL5dF90/k+TQDo7tGOZnpOs2GUhld/Gz2; 25:luyUdNE/JvABeYg6Cj7p64MmMfn3EYMJZAUKzP8hB+pRePbNsRO38VE1lwvhgA7CGkGTfIsdHFB0jt+5XkKLOCcYUDSNGCzvOEfqq7d9fgkq3a0COelFNytJ6U8Aj8JetCWoywiHDSb0RBLmuy4myVeItm3xxAPNTW0aO+goD6lYsVh3NxuJHgbG3sDGmfYt0+EeXOqrXcmvbNExKASuKWAaO9itKGoRTRfpZET29sSB5mW0zf8jVwTr5ilSoErWnD2qlgPx/ejx+mQ9APCBA3ntlHVzk/Pk7A/xZVfGpGmoK1K6lBPEBvpq2h4XBjhfrg7YL+9b6kNXhR1UEHe/Og==; 31:OiEmaZackiPNPiqTXFhGdp2ZQCKvzbtPaytfkRkaye0khj3FUTORbfl5AiNlvwcOK4TkOTHaqb74wl6rpBMG2rntLxWYlbikZEC7hbAbAzoK3Pa1TNJKfpdOC6hMpOE/8d7ff5ffQIwVQqSHEihSeyXMfLaokHV7OaePTq3/2WJILwSPY/jqk//Sn9vZQuVK9H+igIQrbllviher7+sQownNsyzsjYI9qXpkh86GINU= X-MS-TrafficTypeDiagnostic: MWHPR07MB3469: X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3469; 20:MShds/q0reWsmayoZi7/vOFyA7yVVEjQASdnS9AQQdK423mIhPnBiRs2hrbzd0I8B4sU0eMg6aCGtfAOpiIArmh3GO5v/JJmGIBVJU8BO1Mu7V9/yyxdkb6DnsfimzR9z7SI15ni3HUlkkPTwQA3+MmmzPazofzAVNZV5jH+zmGsDdd3S6qtRsaT+lPYsvia/h6BpDC8Uc2Lqq97VtbdE31JmpHapyKiJccWQkzQdQraMMeQda3OYl7ZRQFf0gqu5x1LPLVHmYqdiaSVNig3rfscRXyh0EETHYcOle6HLJAR0lrKR4NY5CaEcDnRZEFDUaQ1eobUzHpv3KuaVEK960Ua4rghUPbOQBTyBnBvGH6MRIxz/ntE6Ljq0fUYQGsyQ5LN3RBE2ukLZo4eb2rf3Sw+3NbpKTJfgEpwEHHlTAw+yM/DZf4nJ84drYlgv/fJW/WWvH+AhINoqRE8mwuPsYKgDdKX/ZHUdH5x4/QRzpR1svJN17Rkv2JD5TwYkFHnWGm8jyIklXBqqHYs05LfUSJvlVJauBSlS1gKioi8zt1ji/bdY+QkUpOY/x0sEFGs2i3tsBvRJ+1m2IFe1UfhhaMfRL4DFfDN9zpjZH48qRU=; 4:DWxP9DYc5RfVPRTKiEw1mheKaB602yEhQJPUOkuZ+/O8NcO7St+EaiTPPzy2yzXJHyFLTNzktWGeoWgUpIsgIf4EbYYRTGwEWr1vQ0vQlacOeaXXFxMzMRkywI7gsgBh6dvyVh5V0OQsf2k+M85a3jN5SrU7FarTAWiOw8EA2XJ+IMdlkVITTsi5GpWwLuk41ZfPQ4u95luPujhRWmRiv6+GhTJdKRqwz4mObT4LXXbBvbuDrC4K7tjWLZNcPXIkzBnFq5IJkwvdpLWGLf5qfA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(93006095)(3231101)(2400082)(944501161)(10201501046)(3002001)(6041288)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011); SRVR:MWHPR07MB3469; BCL:0; PCL:0; RULEID:; SRVR:MWHPR07MB3469; X-Forefront-PRVS: 0570F1F193 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(346002)(366004)(376002)(39860400002)(39380400002)(13464003)(189003)(199004)(42882006)(2950100002)(6636002)(81166006)(5660300001)(8936002)(2906002)(81156014)(97736004)(316002)(68736007)(47776003)(2201001)(105586002)(8676002)(6666003)(110136005)(58126008)(66066001)(186003)(72206003)(55236004)(52116002)(55016002)(53546011)(6116002)(76176011)(6496006)(50466002)(16526019)(33896004)(83506002)(33716001)(229853002)(386003)(9686003)(8656006)(53936002)(2501003)(23726003)(1076002)(7736002)(106356001)(6246003)(16586007)(26005)(25786009)(305945005)(4326008)(478600001)(3846002)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3469; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR07MB3469; 23:MXHd87sq6H/CdG/UxvH4PZbmKeqUIxeogYX3ca9O0?= =?us-ascii?Q?39nd/xPHHMCrIUggZgFviG3P5hsP6atu1NPusuY5h3Y9w3MKpEgT4Tb2TgDX?= =?us-ascii?Q?Z2utVnj1kqJx3WRiTpte44GfPCi0rNwhuLXiLfIEUd4ojrbB8EYXezd1yqTo?= =?us-ascii?Q?ofvOKQmVeVlLDebtjbWxXPRwq00vVbfRkKb3nD945auo9RDUO2SsGYXC37gQ?= =?us-ascii?Q?rPhWxCzy5ubAOudnqdlIcZbHzB1ySGL1XGQS+fp0hkNdCnCSuHa306RavBMH?= =?us-ascii?Q?DKcZrcVST5TmbXQhSys1UPXK3Sby5cy05AtvyyvQxMh3msewh812pjmltCRI?= =?us-ascii?Q?5Q+oMnM3gPJk86lvbUHUQaYND4L+8UrWZXNZek8ofdtSrf/twOXioMBl0Rj5?= =?us-ascii?Q?W3LFZ7AhWhHiF9CcpZEupZNOfUmiPAkXQ9h2zoAFi+lh9edyv683d9n3P+hx?= =?us-ascii?Q?7O+h07k0Yc621HIystiNlS31fk0XAIyEodqZecolE4mxbG38Wlxnq+rwXyI0?= =?us-ascii?Q?xhcQDjGfrD1G5DUEYoEQixWirFPSL8VwKABenhDU9kiy4fmqsv4NFCm5X9HS?= =?us-ascii?Q?eaiAJYJl1lyJ34NIXGO3OzVHkNjZRATN6dvkySv6br09uz+Y+ir+s4Cebb8R?= =?us-ascii?Q?/RvJ8viGff6TWPMvJUqSNLGteP4T4nvUjRnCqu2hzqDMUARdxrgTgRk+xaNg?= =?us-ascii?Q?Ww0Qdh1Ow65p9wVd0e4eSlgEL1s1LGqnmPQThsIs691SQQZUQq/RJPPNY+4s?= =?us-ascii?Q?c3+MjYp6gsFrE02e9xyTWW4yULd0Dd6Ihrh2+s6krGxj2GtlPc+YzTsTK4/z?= =?us-ascii?Q?GPIpIG+Voa8lRLWJUef+iypFsY2RgS14hu4SGheMTzJuiDfWImFwzQagpAPp?= =?us-ascii?Q?+g2+KSqpO09LJC4lEFYJAtmt2pL5EHSHmNhb+kk0kyxL1pFhwFbZMV/vPnsI?= =?us-ascii?Q?qcW1fjdMCZz8JDsXWnayU0ZwDxQi1wgBmOekq/xt5pAxJsAm69Ni2M7LEuSA?= =?us-ascii?Q?BSfAi5Ngfio8ELFsCXFC41CYbF1Ki3Cqa/7+ZtbLF24cOM3wWJxBx5Q/VhxG?= =?us-ascii?Q?dguzC8zHNXa3VHqJHzB1UgNbyEcF8I747VZkqiRjSVinavQuzGheHoYG9PdE?= =?us-ascii?Q?3XJ+MaDFNNViMQE98yqhDgh4B0Yl1hubw1nvOJjiYdbODCV43FdPLZ9fSUVu?= =?us-ascii?Q?JyRvKxVAulVCgKGJXgShuk/MwsuaSi9vER5NV1jxqmMQ3Ml66fCqczldVgUf?= =?us-ascii?Q?39S7s/nOltbGjRFG9ZlOXSzUBB9eMhsE7MOt0JyJL/x8UTyMzR3hq9fjtuX0?= =?us-ascii?Q?FyMj/zHf9rtowiMkmNwTxKrjsrVGbfYj4zCsq3DHZp1b16E8h0qDXyrsOqs8?= =?us-ascii?Q?dFIHrwcUtKcPyMl/UUQeMJcdkQ=3D?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3469; 6:FceIdw9eIxLrdBWpwSDRhdL3FyNzicFZvzn+rTqHyv2gavz4qSLu9x3hVSGqiEaZu8TbtGjVSi9orMAktXINGL46y6t1WXTk+xwSpBf4ooLTpzxiMTfi0NQzb28mhmV1u9U60UZ0xigjW7vG9SB0pc67BUVmb6xxOY58FUG1Unoy5t9gNgG8WSr/aMCZDzuxafgiQMKbkIUbXhmbi7GkpZ6DPfndIAOsZkwJPce1BKWEtDE2Oc5g1z4ZGu04TNXifWSeidBhEy78n+8IpiTzf0195uiZiVVfyDhUDtKK04C74c5g11VBGOmp16nKEAIDc/5UG6S8m3ztvZbTdF9+C4VeXAOyEWNXAkWXMdCXoZ0=; 5:nvy6jl+LNxsYtdNIrWdIgCfpxU26gKxP7/FvMb67ri/LcqUUcRjhXXrdDmB13VDCGRkF7oUY4DuVsfnTmFViEAV1cqE/yqXL4rYeQcsy4fvcvBy28f+9wc+pez5zG6AIhGyt786z4m8+hWqvPIDLKLpknFj4q16dQDVAIExvQ1A=; 24:i2udewd/8IKdCosAm+epoWkFCLRzhCVgYJDsOMd/rbmVkRIb8dHFuZM/4VX3RMZn4AMCcX4xL/K7i1CO+5IBE+WS+uYKTFciordv92tlT88=; 7:l+en27UKwEnL87X9h/rbWqIGVtHjerk7Kzt1T+HVuPn9RBluTsvIZANTPlsXuLcgiECb3zg//VaVGGRwNCU58CBnG9lxHXrOYjYKtvoQZTNa/armOoFOMKUCNr9r36FjdCpZvnxE3S2wxbBteSqYv9xAyDmaarBkEy+3iXMLPbs3HH845qnI4n2FvKICqdpxXPRxlW6I2K2Zw3Z4TlqKF3K8d71anhujuuPgVqS7FyDLDUFzKV9wz19ocY4iBxVW SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2018 20:40:24.5892 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c9dbf855-ea10-4800-b4b3-08d569b406a0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3469 Subject: Re: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 20:40:29 -0000 Hi Hemanth, Currently, best_mempool_ops is broken because when rte_mbuf_user_mempool_ops is invoked it is expected to returns 'NULL' through internal_config.user_mbuf_pool_ops_name. IMO it is best to create a named memzone ('mbuf_user_pool_ops') at the end of eal_init and copy mbuf-pool-ops passed to eal. `rte_eal_mbuf_default_mempool_ops` is not expected to return 'NULL' would doing so break the ABI?. --- /** * Get default pool ops name for mbuf * * @return * returns default pool ops name. */ const char * rte_eal_mbuf_default_mempool_ops(void); --- IMO creating named mempool at the end of eal_init and changing `rte_mbuf_user_mempool_ops` as below would be a better solution. rte_mbuf_user_mempool_ops(void) { ... mz = rte_memzone_lookup("mbuf_user_pool_ops"); if (mz == NULL) return NULL; ... } Thoughts? Pavan. On Thu, Feb 01, 2018 at 07:56:47PM +0000, Hemant Agrawal wrote: > Hi Pavan, > Your patch was breaking the design of the best_mempool_ops and the whole purpose of selection was getting lost. > I guess you were trying to fix test_mempool. I have sent another patch, which fixes that and start using the best mempool ops API > instead of default mempool ops API. > > Regards, > Hemant > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hemant Agrawal > > Sent: Friday, February 02, 2018 1:17 AM > > To: olivier.matz@6wind.com; pbhagavatula@caviumnetworks.com > > Cc: thomas@monjalon.net; dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops" > > > > This reverts commit fe06cb6c54fe5ada299ebba40a382bee37c919f2. > > ---