From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 3F2D628F3
 for <dev@dpdk.org>; Fri,  2 Feb 2018 14:40:13 +0100 (CET)
Received: from lfbn-lil-1-110-231.w90-45.abo.wanadoo.fr ([90.45.197.231]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.89) (envelope-from <olivier.matz@6wind.com>)
 id 1ehbZj-000356-H1; Fri, 02 Feb 2018 14:40:21 +0100
Received: by droids-corp.org (sSMTP sendmail emulation);
 Fri, 02 Feb 2018 14:40:07 +0100
Date: Fri, 2 Feb 2018 14:40:07 +0100
From: Olivier Matz <olivier.matz@6wind.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: thomas@monjalon.net, pbhagavatula@caviumnetworks.com,
 nipun.gupta@nxp.com, jerin.jacob@caviumnetworks.com,
 santosh.shukla@caviumnetworks.com, dev@dpdk.org
Message-ID: <20180202134007.qvip4jkiv2gksxoj@platinum>
References: <1517514427-28843-1-git-send-email-hemant.agrawal@nxp.com>
 <1517558582-27108-1-git-send-email-hemant.agrawal@nxp.com>
 <1517558582-27108-2-git-send-email-hemant.agrawal@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1517558582-27108-2-git-send-email-hemant.agrawal@nxp.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH FIX-OPTION-1] mbuf: fix the logic of user
	mempool ops API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Feb 2018 13:40:13 -0000

On Fri, Feb 02, 2018 at 01:33:01PM +0530, Hemant Agrawal wrote:
> From: Nipun Gupta <nipun.gupta@nxp.com>
> 
> The existing rte_eal_mbuf_default mempool ops can return the compile time
> default ops name if the user has not provided command line inputs for
> mempool ops name. It will break the logic of best mempool ops as it will
> never return platform hw mempool ops.
> 
> This patch introduces a new API to just return the user mempool ops only.
> 
> Fixes: 8b0f7f434132 ("mbuf: maintain user and compile time mempool ops name")
> 
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>

This option is fine for me. I think we may also consider deprecating
rte_eal_mbuf_default_mempool_ops(), as it is done in option 2.

Acked-by: Olivier Matz <olivier.matz@6wind.com>