DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yanglong Wu <yanglong.wu@intel.com>
To: dev@dpdk.org
Cc: shahafs@mellanox.com, wenzhuo.lu@intel.com,
	Yanglong Wu <yanglong.wu@intel.com>
Subject: [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue
Date: Mon,  5 Feb 2018 15:53:06 +0800	[thread overview]
Message-ID: <20180205075306.104779-1-yanglong.wu@intel.com> (raw)
In-Reply-To: <20180205023357.104418-1-yanglong.wu@intel.com>

In the feature of increasing port_id range from 8 bits to 16 bits,
vlan port_id allocation function was forget to substitute UINT8 with
UINT16, so the vlan port_id was allocated as a inccrete number.

Fixes:28caa76aea71 ("app/testpmd: fix port id type")

Signed-off-by: Yanglong Wu <yanglong.wu@intel.com>
Reviewed-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
v2:
modified commit message
---
v3:
add review tag
---
 app/test-pmd/cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f71d96301..8990ebf6b 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3352,7 +3352,7 @@ cmdline_parse_token_num_t cmd_vlan_tpid_tpid =
 			      tp_id, UINT16);
 cmdline_parse_token_num_t cmd_vlan_tpid_portid =
 	TOKEN_NUM_INITIALIZER(struct cmd_vlan_tpid_result,
-			      port_id, UINT8);
+			      port_id, UINT16);
 
 cmdline_parse_inst_t cmd_vlan_tpid = {
 	.f = cmd_vlan_tpid_parsed,
-- 
2.11.0

  parent reply	other threads:[~2018-02-05  7:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-02  5:09 [dpdk-dev] [PATCH] app/testpmd:vlan filter fail Yanglong Wu
2018-02-04  6:27 ` Shahaf Shuler
2018-02-05  1:51   ` Wu, Yanglong
2018-02-05  2:33 ` [dpdk-dev] [PATCH v2] " Yanglong Wu
2018-02-05  6:14   ` Shahaf Shuler
2018-02-05  7:36     ` Wu, Yanglong
2018-02-05  7:53   ` Yanglong Wu [this message]
2018-02-05  8:00     ` [dpdk-dev] [PATCH v3] app/testpmd: fix port_id alloction issue Yang, Zhiyong
2018-02-05  8:48   ` [dpdk-dev] [PATCH v3] app/testpmd: fix port DCB configuration Yanglong Wu
2018-02-05  8:59     ` Shahaf Shuler
2018-02-05  9:47     ` [dpdk-dev] [PATCH v4] " Yanglong Wu
2018-02-05  9:56     ` Yanglong Wu
2018-02-06 15:09       ` Zhang, Helin
  -- strict thread matches above, loose matches on Subject: below --
2017-12-22  7:48 [dpdk-dev] [PATCH v2] app/testpmd: fix port_id alloction issue Yanglong Wu
2018-01-02  5:35 ` [dpdk-dev] [PATCH v3] " Yanglong Wu
2018-01-05  0:58   ` Lu, Wenzhuo
2018-01-09 23:27     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180205075306.104779-1-yanglong.wu@intel.com \
    --to=yanglong.wu@intel.com \
    --cc=dev@dpdk.org \
    --cc=shahafs@mellanox.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).