From: Olivier Matz <olivier.matz@6wind.com>
To: David C Harton <dharton@cisco.com>
Cc: yliu@fridaylinux.org, maxime.coquelin@redhat.com,
tiwei.bie@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/virtio: Fix crash in virtio_dev_free_mbufs
Date: Mon, 5 Feb 2018 09:17:22 +0100 [thread overview]
Message-ID: <20180205081722.dcgygxghtysyqavi@platinum> (raw)
In-Reply-To: <20180203145523.28013-1-dharton@cisco.com>
On Sat, Feb 03, 2018 at 09:55:23AM -0500, David C Harton wrote:
> virtio_dev_free_mbufs was recently modified to free the
> virtqueues but failed to check whether the array was
> allocated. Added a check to ensure vqs was non-null.
>
> Fixes: bdb32afbb610 ("net/virtio: rationalize queue flushing")
> Cc: olivier.matz@6wind.com
>
> Signed-off-by: David C Harton <dharton@cisco.com>
> ---
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
Thank you for this fix.
Out of curiosity, did you see the problem by code review or is there an
easy way to reproduce the crash?
next prev parent reply other threads:[~2018-02-05 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-03 14:55 David C Harton
2018-02-05 8:17 ` Olivier Matz [this message]
2018-02-05 8:44 ` Maxime Coquelin
2018-02-05 18:52 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180205081722.dcgygxghtysyqavi@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=dharton@cisco.com \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).