From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 0F2AF1B2DC for ; Mon, 5 Feb 2018 09:17:33 +0100 (CET) Received: from lfbn-lil-1-110-231.w90-45.abo.wanadoo.fr ([90.45.197.231] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eiby4-0001bZ-9Q; Mon, 05 Feb 2018 09:17:38 +0100 Received: by droids-corp.org (sSMTP sendmail emulation); Mon, 05 Feb 2018 09:17:22 +0100 Date: Mon, 5 Feb 2018 09:17:22 +0100 From: Olivier Matz To: David C Harton Cc: yliu@fridaylinux.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com, dev@dpdk.org Message-ID: <20180205081722.dcgygxghtysyqavi@platinum> References: <20180203145523.28013-1-dharton@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180203145523.28013-1-dharton@cisco.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/virtio: Fix crash in virtio_dev_free_mbufs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 08:17:33 -0000 On Sat, Feb 03, 2018 at 09:55:23AM -0500, David C Harton wrote: > virtio_dev_free_mbufs was recently modified to free the > virtqueues but failed to check whether the array was > allocated. Added a check to ensure vqs was non-null. > > Fixes: bdb32afbb610 ("net/virtio: rationalize queue flushing") > Cc: olivier.matz@6wind.com > > Signed-off-by: David C Harton > --- Reviewed-by: Olivier Matz Thank you for this fix. Out of curiosity, did you see the problem by code review or is there an easy way to reproduce the crash?