From: Olivier Matz <olivier.matz@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, John McNamara <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH] mk: add debug target
Date: Mon, 5 Feb 2018 10:23:02 +0100 [thread overview]
Message-ID: <20180205092302.w4pnay6r5c3elbng@platinum> (raw)
In-Reply-To: <7264515.xsl8mJ6Wl0@xps>
On Fri, Feb 02, 2018 at 10:07:31AM +0100, Thomas Monjalon wrote:
> 01/02/2018 18:04, Ferruh Yigit:
> > On 1/30/2018 11:40 PM, Thomas Monjalon wrote:
> > > 16/12/2017 01:13, Ferruh Yigit:
> > >> Add "debug" target to build library with debug symbols and optimization
> > >> disabled.
> > >>
> > >> This is shortcut for exiting method to compile with
> > >> EXTRA_CFLAGS="-O0 -g3"
> > >>
> > >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > >> ---
> > >> + debug build library with debug symbols
> > > [...]
> > >> +.PHONY: debug
> > >> +debug:
> > >> + $(Q)$(MAKE) EXTRA_CFLAGS="-O0 -g3"
> > >
> > > This target will override any EXTRA_CFLAGS,
> > > so we cannot build in debug mode with more extra cflags this way.
> >
> > How about EXTRA_CFLAGS+="-O0 -g3"
> > which is not override EXTRA_CFLAGS but merge them, can be ok?
>
> I am not sure it works. Have you tested?
Instead of adding a new target, what about, having:
make DEBUG=1
The DEBUG variable could be used by the rte.*.mk to set the specific
flags, before the EXTRA_* flags.
prev parent reply other threads:[~2018-02-05 9:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-16 0:13 Ferruh Yigit
2018-01-30 23:40 ` Thomas Monjalon
2018-02-01 17:04 ` Ferruh Yigit
2018-02-02 9:07 ` Thomas Monjalon
2018-02-05 9:23 ` Olivier Matz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180205092302.w4pnay6r5c3elbng@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).