From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5E8A77CEA for ; Mon, 5 Feb 2018 11:06:47 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2018 02:06:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,464,1511856000"; d="scan'208";a="17103914" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.77]) by fmsmga002.fm.intel.com with SMTP; 05 Feb 2018 02:06:43 -0800 Received: by (sSMTP sendmail emulation); Mon, 05 Feb 2018 10:06:42 +0000 Date: Mon, 5 Feb 2018 10:06:42 +0000 From: Bruce Richardson To: Andrew Rybchenko Cc: dev@dpdk.org, Ivan Malov Message-ID: <20180205100642.GB19876@bricha3-MOBL3.ger.corp.intel.com> References: <1517575438-8609-1-git-send-email-arybchenko@solarflare.com> <1517575438-8609-2-git-send-email-arybchenko@solarflare.com> <20180202161829.GC20444@bricha3-MOBL3.ger.corp.intel.com> <915e76b2-504d-c142-a5d6-da0658d39d7e@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <915e76b2-504d-c142-a5d6-da0658d39d7e@solarflare.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH 2/2] net/sfc: add support for meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 10:06:48 -0000 On Sat, Feb 03, 2018 at 06:33:51PM +0300, Andrew Rybchenko wrote: > On 02/02/2018 07:18 PM, Bruce Richardson wrote: > > On Fri, Feb 02, 2018 at 12:43:58PM +0000, Andrew Rybchenko wrote: > > > From: Ivan Malov > > > > > > Signed-off-by: Ivan Malov > > > Signed-off-by: Andrew Rybchenko > > > --- > > > drivers/net/meson.build | 2 +- > > > drivers/net/sfc/base/meson.build | 69 ++++++++++++++++++++++++++++++++++++++++ > > > drivers/net/sfc/meson.build | 61 +++++++++++++++++++++++++++++++++++ > > > 3 files changed, 131 insertions(+), 1 deletion(-) > > > create mode 100644 drivers/net/sfc/base/meson.build > > > create mode 100644 drivers/net/sfc/meson.build > > Hi, > > > > looks pretty good in general. I have a few comments below to improve > > things. > > > > Unfortunately, this will break the ARM builds in it's current form too > > (or at least it broke the builds using the cross-files that I tested). > > I think you need to add a check at the top of the driver meson.build > > file for unsupported architectures, and set "build = false" for those > > platforms. > > Many thanks for review notes. Hopefully we have processed everything. > It looks like x86 is the common for 64-bit and 32-bit. > In theory we do not supported 32-bit x86 with make. > I've tried to build on 32-bit host with meson/ninja and the build fails > but earlier than our driver: > > ../dpdk-next-net/lib/librte_kni/rte_kni.c: In function ‘kni_allocate_mbufs’: > ../dpdk-next-net/lib/librte_kni/rte_kni.c:669:2: error: size of unnamed > array is negative >   RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_off) != >   ^~~~~~~~~~~~~~~~ > ../dpdk-next-net/lib/librte_kni/rte_kni.c:671:2: error: size of unnamed > array is negative >   RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, data_len) != >   ^~~~~~~~~~~~~~~~ > ../dpdk-next-net/lib/librte_kni/rte_kni.c:673:2: error: size of unnamed > array is negative >   RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, pkt_len) != >   ^~~~~~~~~~~~~~~~ > ../dpdk-next-net/lib/librte_kni/rte_kni.c:675:2: error: size of unnamed > array is negative >   RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, ol_flags) != >   ^~~~~~~~~~~~~~~~ > ../dpdk-next-net/lib/librte_kni/rte_kni.c: At top level: > cc1: warning: unrecognized command line option ‘-Wno-format-truncation’ > cc1: warning: unrecognized command line option > ‘-Wno-address-of-packed-member’ > [26/498] Compiling C object 'lib/rte_port@sta/rte_port_kni.c.o'. > ninja: build stopped: subcommand failed. > > It is Debian stretch. gcc (Debian 6.3.0-18) 6.3.0 20170516 > Does the build on 32-bit x86 work for you? > > bash$ meson --version > 0.42.1 > bash$ ninja --version > 1.7.2 > > Build using make works fine. > Yes, I haven't investigated getting 32-bit builds working yet on meson, due to time constraints. It should be fixed soon in the 18.05 release, I hope. At this point for meson patches, the main requirement is to not break anything that is already confirmed as working. Beyond that, additional support is always welcome, but not required. :-) /Bruce