From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <mleitner@redhat.com> Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 02E571B343 for <dev@dpdk.org>; Mon, 5 Feb 2018 13:58:10 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A2CB073B11; Mon, 5 Feb 2018 12:58:09 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-10.gru2.redhat.com [10.97.116.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3DB5C18EDB; Mon, 5 Feb 2018 12:58:09 +0000 (UTC) Received: by localhost.localdomain (Postfix, from userid 1000) id D76EA18106E; Mon, 5 Feb 2018 10:58:06 -0200 (-02) Date: Mon, 5 Feb 2018 10:58:06 -0200 From: Marcelo Ricardo Leitner <mleitner@redhat.com> To: "Van Haaren, Harry" <harry.van.haaren@intel.com> Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>, Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>, Shahaf Shuler <shahafs@mellanox.com>, Nelio Laranjeiro <nelio.laranjeiro@6wind.com> Message-ID: <20180205125806.GE27676@localhost.localdomain> References: <20180202144736.8239-1-adrien.mazarguil@6wind.com> <20180202164050.13017-1-adrien.mazarguil@6wind.com> <20180202164050.13017-4-adrien.mazarguil@6wind.com> <6047554.pbob4v6vxF@xps> <20180205112402.GE4256@6wind.com> <20180205121339.GB27676@localhost.localdomain> <E923DB57A917B54B9182A2E928D00FA65100D01D@IRSMSX102.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <E923DB57A917B54B9182A2E928D00FA65100D01D@IRSMSX102.ger.corp.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 05 Feb 2018 12:58:09 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/mlx: version rdma-core glue libraries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 05 Feb 2018 12:58:11 -0000 On Mon, Feb 05, 2018 at 12:24:23PM +0000, Van Haaren, Harry wrote: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marcelo Ricardo Leitner > > Sent: Monday, February 5, 2018 12:14 PM > > To: Adrien Mazarguil <adrien.mazarguil@6wind.com> > > Cc: Thomas Monjalon <thomas@monjalon.net>; dev@dpdk.org; Shahaf Shuler > > <shahafs@mellanox.com>; Nelio Laranjeiro <nelio.laranjeiro@6wind.com> > > Subject: Re: [dpdk-dev] [PATCH v2 3/4] net/mlx: version rdma-core glue > > libraries > > > > On Mon, Feb 05, 2018 at 12:24:02PM +0100, Adrien Mazarguil wrote: > > > On Sun, Feb 04, 2018 at 03:29:38PM +0100, Thomas Monjalon wrote: > > > > 02/02/2018 17:46, Adrien Mazarguil: > > > > > --- a/drivers/net/mlx4/Makefile > > > > > +++ b/drivers/net/mlx4/Makefile > > > > > @@ -33,7 +33,9 @@ include $(RTE_SDK)/mk/rte.vars.mk > > > > > > > > > > # Library name. > > > > > LIB = librte_pmd_mlx4.a > > > > > -LIB_GLUE = librte_pmd_mlx4_glue.so > > > > > +LIB_GLUE = $(LIB_GLUE_BASE).$(LIB_GLUE_VERSION) > > > > > +LIB_GLUE_BASE = librte_pmd_mlx4_glue.so > > > > > +LIB_GLUE_VERSION = 18.02.1 > > > > > > > > You should use the version number of the release, i.e. 18.02.0 > > > > Ideally, you should retrieve it from rte_version.h. > > > > > > Keep in mind this only needs to be updated when the glue API gets > > modified, > > > and this "18.02.1" string may remain unmodified for subsequent DPDK > > > releases, probably as long as the PMD doesn't use any new rdma-core calls. > > > > > > We've already backported this patch to 17.02 and 17.11, both requiring > > > different sets of Verbs calls and thus a different version, hence the > > added > > > "18.02" as a starting point. The last digit may have to be modified > > possibly > > > several times between official DPDK releases while work is being done on > > the > > > PMD (i.e. per commit). > > > > > > In short it's not meant to follow DPDK's public versioning scheme. If you > > > really think it should, doing so will make things more complex in the > > > Makefile, which will have to parse rte_version.h. What's your opinion? > > > > What about appending date +%s output to it? It would be stricter and > > automated. > > Adding current timestamp or date into a build breaks reproducibility of builds, so is > generally not recommended. Then the sha1sum of mlx4_glue.h. With this the size check I mentioned on the other patch would become redundant and unnecessary. > > No opinion on string/version naming here. >