From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: Ophir Munk <ophirmu@mellanox.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Olga Shern <olgas@mellanox.com>,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1] net/failsafe: fix default Tx offloads capabilities
Date: Mon, 5 Feb 2018 17:33:20 +0100 [thread overview]
Message-ID: <20180205163320.kopsydr2a7ujbwcs@bidouze.vm.6wind.com> (raw)
In-Reply-To: <1517846526-751-1-git-send-email-ophirmu@mellanox.com>
Hi Ophir,
On Mon, Feb 05, 2018 at 04:02:06PM +0000, Ophir Munk wrote:
> Failsafe reported Tx offloads capabilities are the AND result of its
> default capabilities and those of its sub-devices.
> In the corrupted code failsafe default Tx capabilities were set to 0.
> As a result when running testpmd with "--tx-offloads=0x8000" parameter
> (request for multi segments offload) - an error was returned:
>
> PMD: net_failsafe:
> Some Tx offloads are not supported, requested 0x8000 supported 0x0
>
> To fix this, failsafe default Tx offload capabilities are set to
> DEV_TX_OFFLOAD_MULTI_SEGS |
> DEV_TX_OFFLOAD_IPV4_CKSUM |
> DEV_TX_OFFLOAD_UDP_CKSUM |
> DEV_TX_OFFLOAD_TCP_CKSUM,
>
> Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> ---
> drivers/net/failsafe/failsafe_ops.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c
> index e7bb801..7a67e16 100644
> --- a/drivers/net/failsafe/failsafe_ops.c
> +++ b/drivers/net/failsafe/failsafe_ops.c
> @@ -77,7 +77,11 @@ static struct rte_eth_dev_info default_infos = {
> DEV_RX_OFFLOAD_SCATTER |
> DEV_RX_OFFLOAD_TIMESTAMP |
> DEV_RX_OFFLOAD_SECURITY,
> - .tx_offload_capa = 0x0,
> + .tx_offload_capa =
> + DEV_TX_OFFLOAD_MULTI_SEGS |
With the caveat that this offload above will not be backported to
the stable branch this patch will fix,
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Thanks,
> + DEV_TX_OFFLOAD_IPV4_CKSUM |
> + DEV_TX_OFFLOAD_UDP_CKSUM |
> + DEV_TX_OFFLOAD_TCP_CKSUM,
> .flow_type_rss_offloads = 0x0,
> };
>
> --
> 2.7.4
>
--
Gaëtan Rivet
6WIND
prev parent reply other threads:[~2018-02-05 16:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 16:02 Ophir Munk
2018-02-05 16:33 ` Gaëtan Rivet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180205163320.kopsydr2a7ujbwcs@bidouze.vm.6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=dev@dpdk.org \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).