From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <nelio.laranjeiro@6wind.com>
Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com
[209.85.128.196]) by dpdk.org (Postfix) with ESMTP id C254E1B354
for <dev@dpdk.org>; Tue, 6 Feb 2018 14:21:41 +0100 (CET)
Received: by mail-wr0-f196.google.com with SMTP id 35so1892560wrb.13
for <dev@dpdk.org>; Tue, 06 Feb 2018 05:21:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:content-transfer-encoding:in-reply-to
:user-agent; bh=srmjyvgyjoZ+Zx1vwZpynZ94dPv/GQdW3UDXv6zw2lY=;
b=qEcWaGShdMP4Gu+FnxebrQ0klfTtGah8DPzXnDd9Qo+ds4j3UyC1H9K1AiWvOPwW4R
3ZZ/R3w2CeUx1o4ByHMlzJXP8L1vInTMKkE7ZVDMg1KZDChaE/Z5mO1g+IiA6BSvLJzV
vJDH+lgLGqKweQK4F7/GNpFaCTqvrSneD2I35GGfDNgH6pwYdcslwsXBpnG5UPUldsYD
xHWoUZ3928ICEqtTZtb0KS6ifowJCcm1JYL7tsC6HJ7LEhIBImC8DzJfn6O/ZCGmuxzE
CBoKkzVTO7gAF42OnD7C+iWCQkDxLgGIJSl2INs5k+HetUezhSnE7fBuN3CuYssq5S0P
/JdA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:content-transfer-encoding
:in-reply-to:user-agent;
bh=srmjyvgyjoZ+Zx1vwZpynZ94dPv/GQdW3UDXv6zw2lY=;
b=KRwUd2F76iOTeqao7OejR7KcWQWzGHhurwYyFxIeOa9RUg+wjMULpnNMqtXmFqq5qf
fisn9ahgZq/2nZBPHS4fc2whEp06NI4YebV7tqzacj5Cs7HdOWPkLFrVkOBr/YIZIbvj
euWIvy6j7xu3T+vFDcuOBKNcQY1ipyob3QNgh9tNHWzzyWf+I3eR5cl9ujG56Z068ygP
+Hc5qNeBbWX/mUkSyW0IpmGArXdbQx0T69G1SGKacKp+uis4+ETSlDA3JE5+pUy4aM1S
907hlpPiedajN0tMf85Tns47MCIpkmKIPrBMB54pgEnPt9ts2KTn8rikeuFo/NM8SZ8k
XCmQ==
X-Gm-Message-State: APf1xPANCTPpFytqNeXnJ3bErarsuhlm2SMJFG+eGVH12n3WYTvSJ3ge
gs4EZyQ6+H55IvY7t/u2XDWU
X-Google-Smtp-Source: AH8x227V3nYRt06fUHNiA5t+g45LpLx3y+L00K94mfGB1lQzIT0vf4sdZrMJ9TBrdgIRlBNK7qFM8g==
X-Received: by 10.223.161.27 with SMTP id o27mr2121883wro.97.1517923301525;
Tue, 06 Feb 2018 05:21:41 -0800 (PST)
Received: from laranjeiro-vm.dev.6wind.com
(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])
by smtp.gmail.com with ESMTPSA id 104sm11077466wrl.74.2018.02.06.05.21.40
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Tue, 06 Feb 2018 05:21:40 -0800 (PST)
Date: Tue, 6 Feb 2018 14:22:09 +0100
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
To: Xueming Li <xuemingl@mellanox.com>
Cc: Nelio Laranjeiro <notifications@github.com>, dev@dpdk.org,
Shahaf Shuler <shahafs@mellanox.com>
Message-ID: <20180206132209.efxis4nxd2z2hg7o@laranjeiro-vm.dev.6wind.com>
References: <20180206125253.91036-1-xuemingl@mellanox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180206125253.91036-1-xuemingl@mellanox.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: dump flow create error message
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Feb 2018 13:21:41 -0000
On Tue, Feb 06, 2018 at 08:52:53PM +0800, Xueming Li wrote:
> Add error message dump when flow create error happened.
>
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index e38452ef3..ea90556d0 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -1890,6 +1890,7 @@ priv_flow_create(struct priv *priv,
> DEBUG("Flow created %p", (void *)flow);
> return flow;
> exit:
> + ERROR("Flow create error: %s", error->message);
> for (i = 0; i != hash_rxq_init_n; ++i) {
> if (parser.queue[i].ibv_attr)
> rte_free(parser.queue[i].ibv_attr);
> --
> 2.13.3
Hi Xueming,
Can you move this debug message to mlx5_flow_create().
Thanks,
--
Nélio Laranjeiro
6WIND