From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id CA1341B687 for <dev@dpdk.org>; Tue, 6 Feb 2018 16:12:41 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2018 07:12:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,469,1511856000"; d="scan'208";a="27740071" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.77]) by fmsmga004.fm.intel.com with SMTP; 06 Feb 2018 07:12:38 -0800 Received: by (sSMTP sendmail emulation); Tue, 06 Feb 2018 15:12:37 +0000 Date: Tue, 6 Feb 2018 15:12:37 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com> Cc: Herbert Guan <Herbert.Guan@arm.com>, "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "harry.van.haaren@intel.com" <harry.van.haaren@intel.com>, dev@dpdk.org Message-ID: <20180206151237.GA27232@bricha3-MOBL3.ger.corp.intel.com> References: <1517375549-29756-1-git-send-email-herbert.guan@arm.com> <1517384359-1438-1-git-send-email-herbert.guan@arm.com> <20180205092244.yf34vqtvvwu6djfz@Pavan-LT> <HE1PR08MB28093BE6908025D80AB7ADB386FD0@HE1PR08MB2809.eurprd08.prod.outlook.com> <20180206060257.rwr4jhtdlc72f33l@Pavan-LT> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180206060257.rwr4jhtdlc72f33l@Pavan-LT> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH v1] build: add more implementers' IDs and PNs for Arm platforms X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 06 Feb 2018 15:12:42 -0000 On Tue, Feb 06, 2018 at 11:32:59AM +0530, Pavan Nikhilesh wrote: > On Tue, Feb 06, 2018 at 05:51:29AM +0000, Herbert Guan wrote: > > Hi Pavan, > > > > > -----Original Message----- > > > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > > > Sent: Monday, February 5, 2018 17:23 > > > To: Herbert Guan <Herbert.Guan@arm.com>; > > > jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com; > > > bruce.richardson@intel.com; harry.van.haaren@intel.com > > > Cc: dev@dpdk.org > > > Subject: Re: [PATCH v1] build: add more implementers' IDs and PNs for Arm > > > platforms > > > > > > Hi Herbert, > > > > > > On Wed, Jan 31, 2018 at 03:39:19PM +0800, Herbert Guan wrote: > > > > 1) Add native PN option '-march=native' to allow automatic detection. > > > > Set 'arm_force_native_march' to 'true' in config/arm/meson.build > > > > to use native PN option. > > > > 2) Add implementer_pn option for part num selection in cross compile > > > > 3) Add known Arm cortex PN support > > > > 4) Add known implementers' IDs (use generic flags/archs by default) > > > > 5) Sync build options with config/common_armv8a_linuxapp > > > > > > > > Signed-off-by: Herbert Guan <herbert.guan@arm.com> > > > > --- > > > <snip> > > > > + > > > > machine_args_generic = [ > > > > -['default', ['-march=armv8-a+crc+crypto']]] > > > > +['default', ['-march=armv8-a']], > > > > > > Any specific reason for this change? > > > Traditional make uses > > > MACHINE_CFLAGS += -march=armv8-a+crc+crypto > > > found at mk/machine/armv8a/rte.vars.mk > > > > > > > Both CRC and Crypto are optional instructions / extensions on Arm v8 CPUs. > > When making a general build (e.g. a release build for distribution), we need to > > ensure all targeted CPUs (all Armv8 for example) can support this compiled > > binary. Defaulting crc and crypto to be supported may introduce risks. For a certain > > CPU/platform, '-march=native' may be used, or CPU implementers can further > > Customize these args in this file. > > On the other hand, the rte_cpuflags.c is already supporting run-time CPU flags > > (instruction sets) detection and this is the preferred approach. > > > > Makes sense, As I mentioned in the previous mail some vendors use 64B > cacheline instead of 128B as of now I dont see a way to detect that. The vendor > needs to modify implementor Id specific flags flags_<vendor>. > With that in mind. > > Acked-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com> Applied to dpdk-next-build Thanks, /Bruce