From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Nikhil Rao <nikhil.rao@intel.com>
Cc: dev@dpdk.org, vipin.varghese@intel.com, deepak.k.jain@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix unchecked return in default Rx adapter conf cb
Date: Wed, 7 Feb 2018 00:31:14 +0530 [thread overview]
Message-ID: <20180206190113.GA5868@jerin> (raw)
In-Reply-To: <1517768311-827-1-git-send-email-nikhil.rao@intel.com>
-----Original Message-----
> Date: Sun, 4 Feb 2018 23:48:31 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: dev@dpdk.org
> CC: nikhil.rao@intel.com, vipin.varghese@intel.com,
> deepak.k.jain@intel.com, jerin.jacob@caviumnetworks.com
> Subject: [PATCH v2] eventdev: fix unchecked return in default Rx adapter
> conf cb
> X-Mailer: git-send-email 2.7.4
>
> The default adapter configuration callback is invoked when a Rx
> queue is added to the adapter and the adapter detects that a SW
> service is needed. The adapter needs to re-configure the device
> with an additional port and to do do, it needs to stop the
> device and restart it after it is done reconfiguring it. This
> patch adds code to check the return code of
> rte_event_dev_start() for both when the reconfiguration fails
> and when it succeeds and introduces a new error code (-EIO)
> for the first case.
>
> Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation")
> Coverity issue: 257000
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Cc: stable@dpdk.org
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
next prev parent reply other threads:[~2018-02-06 19:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 22:56 [dpdk-dev] [PATCH] event/rx_adapter: fix ignore return of event start Vipin Varghese
2018-01-31 5:32 ` Rao, Nikhil
2018-01-31 6:54 ` Jerin Jacob
2018-02-02 8:08 ` Varghese, Vipin
2018-02-02 10:04 ` Rao, Nikhil
2018-02-02 12:12 ` Jerin Jacob
2018-02-04 18:18 ` [dpdk-dev] [PATCH v2] eventdev: fix unchecked return in default Rx adapter conf cb Nikhil Rao
2018-02-06 19:01 ` Jerin Jacob [this message]
2018-02-06 20:24 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206190113.GA5868@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=nikhil.rao@intel.com \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).