From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0065.outbound.protection.outlook.com [104.47.34.65]) by dpdk.org (Postfix) with ESMTP id 5B2331B638 for ; Tue, 6 Feb 2018 20:01:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8Hr3XscwdFHyIM7Vnix6bmpcPquDhvQ8lLZSxKKFK84=; b=jSxMf34xrusld/4DkH4yzVlgIddu2u8gX3ZqditNfzU44ceVJ02AwfpiZFOGqG6JC8affyycmaXFhmsy9QvRaPeLxaUzBaBe010QTVgWI1F+MtqGk49tqLPriUdrfz0xpAwR9/x3CVYFUMk5GX609Gk5mHu1fjdbZJfKKZ14HUQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (106.201.34.24) by BN3PR07MB2513.namprd07.prod.outlook.com (10.167.4.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Tue, 6 Feb 2018 19:01:29 +0000 Date: Wed, 7 Feb 2018 00:31:14 +0530 From: Jerin Jacob To: Nikhil Rao Cc: dev@dpdk.org, vipin.varghese@intel.com, deepak.k.jain@intel.com Message-ID: <20180206190113.GA5868@jerin> References: <1517352989-11720-1-git-send-email-vipin.varghese@intel.com> <1517768311-827-1-git-send-email-nikhil.rao@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1517768311-827-1-git-send-email-nikhil.rao@intel.com> User-Agent: Mutt/1.9.3 (2018-01-21) X-Originating-IP: [106.201.34.24] X-ClientProxiedBy: BMXPR01CA0027.INDPRD01.PROD.OUTLOOK.COM (10.174.214.13) To BN3PR07MB2513.namprd07.prod.outlook.com (10.167.4.138) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e0a91261-0965-4000-8d6a-08d56d940899 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:BN3PR07MB2513; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 3:Fi37PlUOoOcIdJj3bSgxznFJsqdesGJjwgx+oJRHnnzlTzQe1MPPT43CWEUvJPz+/o7/cv7LMhG5GGFN/YHHlPTuHiG4SD6jrJRzCBvaXUpbTV7bu87bOuAXytPGK5YfZtG+6c19e17YD11NwogVE7c3wC05Cn/5JeXphvq0vszPnCJgZv0GlZnCvGtg/A+yv/kw0sMvYI4GzHzOKbt5tzyNtlBJcrp2swrGhAxS4p8zelEzSIn0Oy4DN6tIqm/u; 25:TjG7foJ8PbaXvKMtIJ9EJEeQhc1Ba8jPZdI3MrMUJt6E/DjJoMRXvdoiZv8BhCLPAYAmUR6LtcAwEf/MgnMYeucA3FfQrnFIgksiIijCi0mMpkMOLBmElLDSk4c4dVZdgNi8lrCPP6B0Y19+nHQOzRpw3UYpG0ET/vylxZoUwplyOOQMqnkUEYxGTuUxnKrQHLgm0Clka66mwvMfRywGfqpiWeQIOKOSWdMJppoihe1LUEb1Ljmvwx3yU8QG7RnD6D89Hxp1A0JyMWDeA8pK9i/Gc4GsVC9bgI3F32ezNSGL26SdmBHXvHcU8WNdk0NgTF64n2e4nce01z3nmXsfdw==; 31:DT16biyJnJ0xjcGFAgPmQAizMfq87k3XeyCyoSi7RYy6r2n3oS6TRm39q34JeIu6vvo0aqaQTSRf+m3CKKY2qjXNr7y/cbxq8UeesSwm4PJHJnDHPl5Q+ofFgZxuhVrwXG08Xm0zU4HmWFPiw2KDLqGiu3fuzOrMMDqcaUblYtrg+1XPm4gzwuC3ZyhNnWsbmqhsvNUTJk9eJWtEuxfX9OH/6DmIR11T8UBfxESCc6w= X-MS-TrafficTypeDiagnostic: BN3PR07MB2513: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 20:59PlEJ5h9kOGVtKZ4Pv0HJPkZXI0cFhVgHFnGxhYWQjQQMRlAYhpBk79bCZNkPK2mv/FXKa3/0Eh0AvDh0++WEJFXSjbrF047se/mPmaF9AO891efTrwfKk/0NTz2Tjk6em8HvyfqfJYH7rU6gJWkpAVjZtn0OlMr90KfoFbEjqqjEWshfMxgVtQXE2BUH+aMLcSjI0jXsqJiBRVf2wWpcbc/CnM39lL0PP318qxP5eTphYQNDdKZUGKxJlCyYUWSZhoK+/3d6LI9r53KA7m6t2vtx+HNw3X0i1LVTicOA6hxjA99Ji7etAzWdJKW8dGMNCEh+8r9W+wGkBh1pBl+mHYi15dwxT0Q+fKNzf0r32aCHcpSKe7mlV3HcPdlb+mJtnZ43RXKwjdk+iyJVo84+dMsSRXZUG8ue+epfXeZr+5/lloyoPWLx/ceJcid9cQoAm8MeKU+joS8P0uVhOtbdB43RtDFmaw/tvewATZC8cNTqVDAcnXewKeq1+qGgSwCjtRqGnenSG9lyvIZ/jDyYw3475ljAcAlF5c1jF43sNLwmco+FEAnoHRrvqIImXZcGsOeeqPmJg5fx3musHv+aI0uAGFugxC97QLHzUlrGE=; 4:nhNOasVAlynnXilTyI84JhAkzw0iQj+9DFSRt0ilf7vZAbbJL78KkoTG4EwMDA0xU2ddAEtYvt61bx1e+dIverpxv6PkOmAj5e02JDuuZ8J0yvNujt+F/zTYgwIfp3VKbI4C3UTJK2Lr8RQFdfcm42wR2aiktZE41hdc5wo+8w3j/jDDLv2B2esQFGCwiDQIjvZ5yggwzIiZPhlxQF/avlYIgoSOm/vliugQpYjvE5qvO+V4JhOGoViQNFfuzOZWz2C7K/p8BVyZkJKjN7Zv+0E8I4l+fF4Mbi472uDlGE9blEBVj55c7yz6qfIfKQsz X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(3231101)(2400082)(944501161)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:BN3PR07MB2513; BCL:0; PCL:0; RULEID:; SRVR:BN3PR07MB2513; X-Forefront-PRVS: 0575F81B58 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39380400002)(39860400002)(396003)(346002)(376002)(189003)(199004)(13464003)(5009440100003)(33896004)(6496006)(72206003)(76176011)(478600001)(26005)(58126008)(23726003)(6116002)(386003)(55236004)(1076002)(3846002)(16586007)(186003)(16526019)(316002)(52116002)(106356001)(7736002)(305945005)(2950100002)(229853002)(105586002)(5660300001)(42882006)(81156014)(66066001)(81166006)(6916009)(8936002)(6666003)(9686003)(47776003)(8676002)(55016002)(6246003)(53936002)(83506002)(25786009)(2906002)(33716001)(97736004)(68736007)(4326008)(33656002)(50466002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2513; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2513; 23:Oe8VFv+U0AWqETUtrXGzExKORcrpNNqcwd1kCYH4n?= =?us-ascii?Q?H7e9hQjWg3jsLpIksFdtEK9JaLE4w1b/lQesiiKRLApLy3I+l4gl3WoJGgcy?= =?us-ascii?Q?DpXeiAxsCJWMV3mu1YgDw55K7uRLloAUdIMBOXJIByCOvO2PZzfRoVP1MUWB?= =?us-ascii?Q?ZHVj58GCPLCZnsTGM5RqCr4AKQ0mEiQnIdqcrtbxK6OdF14Fgz+m4ZRNhhNo?= =?us-ascii?Q?Z6z8Qvlykj2F+7tCFQjvvaF1QNEIIbAmnL8AxjkY1sULFJ1s9AOpEFwjjloP?= =?us-ascii?Q?05D6CYQbqIooe6K1s6TZxe00xbJKEcNhcE+xhyYF1Ait/NBc3Au02I5jwgyY?= =?us-ascii?Q?w8a8/IfUc8tESRlWXMq/MUPICAnLlkEVtQWQLjMSO1btO28qHRcaIx9hIgbs?= =?us-ascii?Q?K9WAu6UyayOHLC3vHViBlBZACOoByr4A2xbM5bRSVFi7OwTCGVhhI+5M+MmV?= =?us-ascii?Q?oWhmMOwY4TpO43sd1ApI+qrjPYZBBNfAg0L2ZXNQUQI9VYzVTCCnXX/9kyg4?= =?us-ascii?Q?g+jOr6Xz+XXcmIKnRnLGxwVwiohKgd5mBVmBH7W27gZCo3sMAP1j0XHbejIK?= =?us-ascii?Q?0cwD3hpWMFe3NtFiA+lfsDFRvXYOox74RfAoAF9yFLHWCwYk9pqEZ1FX6Q+a?= =?us-ascii?Q?hIMrsUX87HZl3mla4mQXpXe9rRgZeTpySMHJXj7Z2V8nekDPRf0ax7muXdGY?= =?us-ascii?Q?H6Odrw4cfAjCOZtlW0rmFDXaYTTcZ2PS1d6ZUU3Wn3bTQ1MnMglNhPuzUE/Q?= =?us-ascii?Q?FTbEkScmGlKzWGc6++iWyVqQAZqkBemEZJl5hi8h68AujXHHqBYgFy3YFaGv?= =?us-ascii?Q?G9GMeEBvc8TtyUNyIoSvTu3wsRpLrGjxA6jvYXC4ka1+PQIWpcc1hUl1Ui6j?= =?us-ascii?Q?MCprSLAl9bE/p2oV2w9FXpuW3aoWBVphy/Td6uSxSJWGfsvveNP4VAm7vzmF?= =?us-ascii?Q?quvs2kChVDtYTJ6tUYXEA54P43qGnFbogOuRQAe8CkuF2KUPo2MYXVQEltXG?= =?us-ascii?Q?XAD/prlDVbUjSqYccUTp0Ld7bc84m0lN9D/KyBzD4q9MhZtXxS/MKfQMtxW8?= =?us-ascii?Q?lhAV8SwdPzcZwxyIdMetT6JeaT9lVXFYLTS1mqshYTaLREFkSHh5xkbSeRs9?= =?us-ascii?Q?VlXJFJM3Du3ySjoiKKkyRYfJg0gLIM7AAqpTVlMFL4cGkus3RmIEvYOSg0id?= =?us-ascii?Q?IacOsGUNjhSzsjfBZ6Zr5Zm9KNaFoAjRRO2eAGf2JxhSEybnL5owQWTGpLMm?= =?us-ascii?Q?R4Bd1J7zejZIrhprtkMn8HrJaO7i0eLVqQPeRxe2BIfHYirOJVhHAQvlaUPC?= =?us-ascii?Q?WNh5D1YS7yxA+hDcnpzMU7eVbkNj8UzKh/l0qztTFpF?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2513; 6:SAer6ycMF9oP4Zs9gU2mH/KsUNIDe86dYfZx9/s/TWpL2dRU0DsFJqYFO/OwkGdiITqULEWDQ/qpvrLn3aw88Q2i+gQ6HXtb/gAaIejwKptbk0KimxrImHV5Bjn2GZr96XkPlgxjKGZ0FrXywFXtYmNNIMZTc8PGg2FhYFytltPD1QU+odr1eVxpwsYXIgm9uXSelTxRbZBzxFLQL1pnmE9UKi4y81fBRHOG3VPj76UXaYRqlimVngAAgf/O+01NzHPZSnzQDODzrzLPCJ33CNfHrZtrOQnfbWwPQ7B7Yz05y4zUWnZ6Ns2ff76iD3xgvejGftFIL360aRsahY3t0WAZHowZ3U8gfyL4F6OEPI4=; 5:3TAbwai7zpADaGu33Tnh5XXP5yxUq8mjnP1mV+bP6nMFeLFBi8ctOGkklwj7hJyz+EiIyGgF/ybiWNW0TVTyt3jAxE424/M9zQB7tIsJ80ZBgZVTPRpHLQnGDyoWYC3d70G7ppUc3jTHLu9cFw2K9UwzkCEkyjUzRZgAGvnfvPQ=; 24:95GTR9A9pVXydDboZK6qcwLc5RgHzbAlmp8/27jY1GH7r8njdA1Xg5OElik5bHKsxB5rftlAsoYGc+diCMkCrySRPZKQllbG04AsQNVojco=; 7:hEKnnzd4CfHvyZfXCWNDuWL/GeNwOWyjvlcTNLAx6vWMpnP/ybOv1Kevx5T3DsEk+9bwii8ccbZ8Gj4AfDJs77HkvJdtaDOcvtHpTZSVu+rM5K1x/mZdNpyOzsCYm7rLluGeRFcpK8I883oaIFYW5ctjWDnTMskDc99VsbrAhvJUp6lZrgR/NoAvDnqoPwZYNzCnsFwi84+8I7uS4A/wf1NbPsQ4QHzlTzzMqhN+x1FcJvGmBCzWLCsvLwl7MXfp SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2018 19:01:29.1536 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e0a91261-0965-4000-8d6a-08d56d940899 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2513 Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix unchecked return in default Rx adapter conf cb X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 19:01:33 -0000 -----Original Message----- > Date: Sun, 4 Feb 2018 23:48:31 +0530 > From: Nikhil Rao > To: dev@dpdk.org > CC: nikhil.rao@intel.com, vipin.varghese@intel.com, > deepak.k.jain@intel.com, jerin.jacob@caviumnetworks.com > Subject: [PATCH v2] eventdev: fix unchecked return in default Rx adapter > conf cb > X-Mailer: git-send-email 2.7.4 > > The default adapter configuration callback is invoked when a Rx > queue is added to the adapter and the adapter detects that a SW > service is needed. The adapter needs to re-configure the device > with an additional port and to do do, it needs to stop the > device and restart it after it is done reconfiguring it. This > patch adds code to check the return code of > rte_event_dev_start() for both when the reconfiguration fails > and when it succeeds and introduces a new error code (-EIO) > for the first case. > > Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation") > Coverity issue: 257000 > > Signed-off-by: Nikhil Rao Cc: stable@dpdk.org Acked-by: Jerin Jacob