From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nhorman@tuxdriver.com>
Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])
 by dpdk.org (Postfix) with ESMTP id 869F31B775
 for <dev@dpdk.org>; Wed,  7 Feb 2018 13:25:08 +0100 (CET)
Received: from cpe-2606-a000-111b-4011-eaa3-4b92-4a68-8f24.dyn6.twc.com
 ([2606:a000:111b:4011:eaa3:4b92:4a68:8f24] helo=localhost)
 by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63)
 (envelope-from <nhorman@tuxdriver.com>)
 id 1ejOmX-0007DY-9j; Wed, 07 Feb 2018 07:25:06 -0500
Date: Wed, 7 Feb 2018 07:24:25 -0500
From: Neil Horman <nhorman@tuxdriver.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Message-ID: <20180207122425.GA5272@hmswarspite.think-freely.org>
References: <1517492959-15104-1-git-send-email-arybchenko@solarflare.com>
 <1517991840-3612-1-git-send-email-arybchenko@solarflare.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1517991840-3612-1-git-send-email-arybchenko@solarflare.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-Spam-Score: -2.9 (--)
X-Spam-Status: No
Subject: Re: [dpdk-dev] [PATCH v2] buildtools: output build failure reason
	to stderr
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Feb 2018 12:25:08 -0000

On Wed, Feb 07, 2018 at 08:24:00AM +0000, Andrew Rybchenko wrote:
> If build fails because of failed experimental check and stdout is
> redirected to /dev/null, it is absolutely unclear why build fails.
> 
> Fixes: a4bcd61de82d ("buildtools: add script to check experimental API exports")
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> v2:
>  - use <<- to keep indentation of the message
> 
>  buildtools/check-experimental-syms.sh | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh
> index 7d21de3..5bc8cda 100755
> --- a/buildtools/check-experimental-syms.sh
> +++ b/buildtools/check-experimental-syms.sh
> @@ -22,9 +22,11 @@ do
>  	IN_EXP=$?
>  	if [ $IN_TEXT -eq 0 -a $IN_EXP -ne 0 ]
>  	then
> -		echo "$SYM is not flagged as experimental"
> -		echo "but is listed in version map"
> -		echo "Please add __rte_experimental to the definition of $SYM"
> +		cat >&2 <<- END_OF_MESSAGE
> +		$SYM is not flagged as experimental
> +		but is listed in version map
> +		Please add __rte_experimental to the definition of $SYM
> +		END_OF_MESSAGE
>  		exit 1
>  	fi
>  done
> -- 
> 2.7.4
> 
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>