* [dpdk-dev] [PATCH] doc: update ethdev APIs to return named opaque type @ 2018-02-09 10:11 Ferruh Yigit 2018-02-09 10:18 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit 0 siblings, 1 reply; 6+ messages in thread From: Ferruh Yigit @ 2018-02-09 10:11 UTC (permalink / raw) To: Neil Horman, John McNamara, Marko Kovacevic Cc: dev, Ferruh Yigit, Konstantin Ananyev, Stephen Hemminger, Bruce Richardson, Thomas Monjalon Ethdev APIs to add callback return the callback object as "void *", update return type to actual object type "struct rte_eth_rxtx_callback *" Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> --- Cc: Konstantin Ananyev <konstantin.ananyev@intel.com> Cc: Stephen Hemminger <stephen@networkplumber.org> Cc: Bruce Richardson <bruce.richardson@intel.com> Cc: Thomas Monjalon <thomas@monjalon.net> --- doc/guides/rel_notes/deprecation.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index bbd9456a7..b6479cd5a 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -49,6 +49,13 @@ Deprecation Notices rte_eth_dev_get_sec_ctx() is using uint8_t for port_id, which should be uint16_t. +* ethdev: add rx/tx callback functions return named opaque type + rte_eth_add_rx_callback(), rte_eth_add_first_rx_callback() and + rte_eth_add_tx_callback() functions currently return "void * " but APIs to + delete callbacks get "struct rte_eth_rxtx_callback * " as parameter. For + consistency functions adding callback will return "struct rte_eth_rxtx_callback * " + instead of "void * ". + * i40e: The default flexible payload configuration which extracts the first 16 bytes of the payload for RSS will be deprecated starting from 18.02. If required the previous behavior can be configured using existing flow -- 2.14.3 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] doc: update ethdev APIs to return named opaque type 2018-02-09 10:11 [dpdk-dev] [PATCH] doc: update ethdev APIs to return named opaque type Ferruh Yigit @ 2018-02-09 10:18 ` Ferruh Yigit 2018-02-09 13:22 ` Ananyev, Konstantin 0 siblings, 1 reply; 6+ messages in thread From: Ferruh Yigit @ 2018-02-09 10:18 UTC (permalink / raw) To: Neil Horman, John McNamara, Marko Kovacevic Cc: dev, Ferruh Yigit, Konstantin Ananyev, Stephen Hemminger, Bruce Richardson, Thomas Monjalon Ethdev APIs to add callback return the callback object as "void *", update return type to actual object type "struct rte_eth_rxtx_callback *" Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> --- Cc: Konstantin Ananyev <konstantin.ananyev@intel.com> Cc: Stephen Hemminger <stephen@networkplumber.org> Cc: Bruce Richardson <bruce.richardson@intel.com> Cc: Thomas Monjalon <thomas@monjalon.net> --- doc/guides/rel_notes/deprecation.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index bbd9456a7..5cb5a00d2 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -49,6 +49,13 @@ Deprecation Notices rte_eth_dev_get_sec_ctx() is using uint8_t for port_id, which should be uint16_t. +* ethdev: functions add rx/tx callback will return named opaque type + rte_eth_add_rx_callback(), rte_eth_add_first_rx_callback() and + rte_eth_add_tx_callback() functions currently return callback object as + "void \*" but APIs to delete callbacks get "struct rte_eth_rxtx_callback \*" + as parameter. For consistency functions adding callback will return + "struct rte_eth_rxtx_callback \*" instead of "void * ". + * i40e: The default flexible payload configuration which extracts the first 16 bytes of the payload for RSS will be deprecated starting from 18.02. If required the previous behavior can be configured using existing flow -- 2.14.3 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: update ethdev APIs to return named opaque type 2018-02-09 10:18 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit @ 2018-02-09 13:22 ` Ananyev, Konstantin 2018-02-10 12:02 ` Jerin Jacob 0 siblings, 1 reply; 6+ messages in thread From: Ananyev, Konstantin @ 2018-02-09 13:22 UTC (permalink / raw) To: Yigit, Ferruh, Neil Horman, Mcnamara, John, Kovacevic, Marko Cc: dev, Stephen Hemminger, Richardson, Bruce, Thomas Monjalon > -----Original Message----- > From: Yigit, Ferruh > Sent: Friday, February 9, 2018 10:18 AM > To: Neil Horman <nhorman@tuxdriver.com>; Mcnamara, John <john.mcnamara@intel.com>; Kovacevic, Marko > <marko.kovacevic@intel.com> > Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>; Stephen Hemminger > <stephen@networkplumber.org>; Richardson, Bruce <bruce.richardson@intel.com>; Thomas Monjalon <thomas@monjalon.net> > Subject: [PATCH v2] doc: update ethdev APIs to return named opaque type > > Ethdev APIs to add callback return the callback object as "void *", > update return type to actual object type > "struct rte_eth_rxtx_callback *" > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > --- > Cc: Konstantin Ananyev <konstantin.ananyev@intel.com> > Cc: Stephen Hemminger <stephen@networkplumber.org> > Cc: Bruce Richardson <bruce.richardson@intel.com> > Cc: Thomas Monjalon <thomas@monjalon.net> > --- > doc/guides/rel_notes/deprecation.rst | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index bbd9456a7..5cb5a00d2 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -49,6 +49,13 @@ Deprecation Notices > rte_eth_dev_get_sec_ctx() is using uint8_t for port_id, which should be > uint16_t. > > +* ethdev: functions add rx/tx callback will return named opaque type > + rte_eth_add_rx_callback(), rte_eth_add_first_rx_callback() and > + rte_eth_add_tx_callback() functions currently return callback object as > + "void \*" but APIs to delete callbacks get "struct rte_eth_rxtx_callback \*" > + as parameter. For consistency functions adding callback will return > + "struct rte_eth_rxtx_callback \*" instead of "void * ". > + > * i40e: The default flexible payload configuration which extracts the first 16 > bytes of the payload for RSS will be deprecated starting from 18.02. If > required the previous behavior can be configured using existing flow > -- Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> > 2.14.3 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: update ethdev APIs to return named opaque type 2018-02-09 13:22 ` Ananyev, Konstantin @ 2018-02-10 12:02 ` Jerin Jacob 2018-02-13 3:52 ` Hemant Agrawal 0 siblings, 1 reply; 6+ messages in thread From: Jerin Jacob @ 2018-02-10 12:02 UTC (permalink / raw) To: Ananyev, Konstantin Cc: Yigit, Ferruh, Neil Horman, Mcnamara, John, Kovacevic, Marko, dev, Stephen Hemminger, Richardson, Bruce, Thomas Monjalon -----Original Message----- > Date: Fri, 9 Feb 2018 13:22:06 +0000 > From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> > To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, Neil Horman > <nhorman@tuxdriver.com>, "Mcnamara, John" <john.mcnamara@intel.com>, > "Kovacevic, Marko" <marko.kovacevic@intel.com> > CC: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger > <stephen@networkplumber.org>, "Richardson, Bruce" > <bruce.richardson@intel.com>, Thomas Monjalon <thomas@monjalon.net> > Subject: Re: [dpdk-dev] [PATCH v2] doc: update ethdev APIs to return named > opaque type > > > > > -----Original Message----- > > From: Yigit, Ferruh > > Sent: Friday, February 9, 2018 10:18 AM > > To: Neil Horman <nhorman@tuxdriver.com>; Mcnamara, John <john.mcnamara@intel.com>; Kovacevic, Marko > > <marko.kovacevic@intel.com> > > Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>; Stephen Hemminger > > <stephen@networkplumber.org>; Richardson, Bruce <bruce.richardson@intel.com>; Thomas Monjalon <thomas@monjalon.net> > > Subject: [PATCH v2] doc: update ethdev APIs to return named opaque type > > > > Ethdev APIs to add callback return the callback object as "void *", > > update return type to actual object type > > "struct rte_eth_rxtx_callback *" > > > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > > --- > > Cc: Konstantin Ananyev <konstantin.ananyev@intel.com> > > Cc: Stephen Hemminger <stephen@networkplumber.org> > > Cc: Bruce Richardson <bruce.richardson@intel.com> > > Cc: Thomas Monjalon <thomas@monjalon.net> > > --- > > doc/guides/rel_notes/deprecation.rst | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > index bbd9456a7..5cb5a00d2 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -49,6 +49,13 @@ Deprecation Notices > > rte_eth_dev_get_sec_ctx() is using uint8_t for port_id, which should be > > uint16_t. > > > > +* ethdev: functions add rx/tx callback will return named opaque type > > + rte_eth_add_rx_callback(), rte_eth_add_first_rx_callback() and > > + rte_eth_add_tx_callback() functions currently return callback object as > > + "void \*" but APIs to delete callbacks get "struct rte_eth_rxtx_callback \*" > > + as parameter. For consistency functions adding callback will return > > + "struct rte_eth_rxtx_callback \*" instead of "void * ". > > + > > * i40e: The default flexible payload configuration which extracts the first 16 > > bytes of the payload for RSS will be deprecated starting from 18.02. If > > required the previous behavior can be configured using existing flow > > -- > > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > > 2.14.3 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: update ethdev APIs to return named opaque type 2018-02-10 12:02 ` Jerin Jacob @ 2018-02-13 3:52 ` Hemant Agrawal 2018-02-14 17:10 ` Thomas Monjalon 0 siblings, 1 reply; 6+ messages in thread From: Hemant Agrawal @ 2018-02-13 3:52 UTC (permalink / raw) To: Jerin Jacob, Ananyev, Konstantin Cc: Yigit, Ferruh, Neil Horman, Mcnamara, John, Kovacevic, Marko, dev, Stephen Hemminger, Richardson, Bruce, Thomas Monjalon On 2/10/2018 5:32 PM, Jerin Jacob wrote: >>> -----Original Message----- >>> From: Yigit, Ferruh >>> Sent: Friday, February 9, 2018 10:18 AM >>> To: Neil Horman <nhorman@tuxdriver.com>; Mcnamara, John <john.mcnamara@intel.com>; Kovacevic, Marko >>> <marko.kovacevic@intel.com> >>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>; Stephen Hemminger >>> <stephen@networkplumber.org>; Richardson, Bruce <bruce.richardson@intel.com>; Thomas Monjalon <thomas@monjalon.net> >>> Subject: [PATCH v2] doc: update ethdev APIs to return named opaque type >>> >>> Ethdev APIs to add callback return the callback object as "void *", >>> update return type to actual object type >>> "struct rte_eth_rxtx_callback *" >>> >>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> >>> --- >>> Cc: Konstantin Ananyev <konstantin.ananyev@intel.com> >>> Cc: Stephen Hemminger <stephen@networkplumber.org> >>> Cc: Bruce Richardson <bruce.richardson@intel.com> >>> Cc: Thomas Monjalon <thomas@monjalon.net> >>> --- >>> doc/guides/rel_notes/deprecation.rst | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst >>> index bbd9456a7..5cb5a00d2 100644 >>> --- a/doc/guides/rel_notes/deprecation.rst >>> +++ b/doc/guides/rel_notes/deprecation.rst >>> @@ -49,6 +49,13 @@ Deprecation Notices >>> rte_eth_dev_get_sec_ctx() is using uint8_t for port_id, which should be >>> uint16_t. >>> >>> +* ethdev: functions add rx/tx callback will return named opaque type >>> + rte_eth_add_rx_callback(), rte_eth_add_first_rx_callback() and >>> + rte_eth_add_tx_callback() functions currently return callback object as >>> + "void \*" but APIs to delete callbacks get "struct rte_eth_rxtx_callback \*" >>> + as parameter. For consistency functions adding callback will return >>> + "struct rte_eth_rxtx_callback \*" instead of "void * ". >>> + >>> * i40e: The default flexible payload configuration which extracts the first 16 >>> bytes of the payload for RSS will be deprecated starting from 18.02. If >>> required the previous behavior can be configured using existing flow >>> -- >> >> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> > > Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > >> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: update ethdev APIs to return named opaque type 2018-02-13 3:52 ` Hemant Agrawal @ 2018-02-14 17:10 ` Thomas Monjalon 0 siblings, 0 replies; 6+ messages in thread From: Thomas Monjalon @ 2018-02-14 17:10 UTC (permalink / raw) To: Yigit, Ferruh Cc: dev, Hemant Agrawal, Jerin Jacob, Ananyev, Konstantin, Neil Horman, Mcnamara, John, Kovacevic, Marko, Stephen Hemminger, Richardson, Bruce > >>> Ethdev APIs to add callback return the callback object as "void *", > >>> update return type to actual object type > >>> "struct rte_eth_rxtx_callback *" > >>> > >>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > >>> --- > >>> +* ethdev: functions add rx/tx callback will return named opaque type > >>> + rte_eth_add_rx_callback(), rte_eth_add_first_rx_callback() and > >>> + rte_eth_add_tx_callback() functions currently return callback object as > >>> + "void \*" but APIs to delete callbacks get "struct rte_eth_rxtx_callback \*" > >>> + as parameter. For consistency functions adding callback will return > >>> + "struct rte_eth_rxtx_callback \*" instead of "void * ". > >>> + > >>> * i40e: The default flexible payload configuration which extracts the first 16 > >>> bytes of the payload for RSS will be deprecated starting from 18.02. If > >>> required the previous behavior can be configured using existing flow > >>> -- > >> > >> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> > > > > Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > > Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com> Applied ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-14 17:10 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-02-09 10:11 [dpdk-dev] [PATCH] doc: update ethdev APIs to return named opaque type Ferruh Yigit 2018-02-09 10:18 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit 2018-02-09 13:22 ` Ananyev, Konstantin 2018-02-10 12:02 ` Jerin Jacob 2018-02-13 3:52 ` Hemant Agrawal 2018-02-14 17:10 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).