From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0080.outbound.protection.outlook.com [104.47.32.80]) by dpdk.org (Postfix) with ESMTP id BB7051B2FE for ; Mon, 12 Feb 2018 10:26:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hsfUdjHhkNAP2z0aU2P11a0DZ15kK/3/KrCNYriheOg=; b=B/T3VlRq6KT+otgDVBCN7kGGBFtCNRypn7L8SX2OHIyEoFb9jsdppVB4afPl/CInqjFp7yOTSlMZiK0e9cCoNQt7+YlvplunFKdTkpwzC7eJ/fd9IIOgL+VWHH2QqZ6fZv0JYdmPPLC09eHU21EFD5dirBiqo/Axtq/1/nVCluU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (122.178.204.19) by BN3PR07MB2516.namprd07.prod.outlook.com (10.167.4.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10; Mon, 12 Feb 2018 09:26:02 +0000 Date: Mon, 12 Feb 2018 14:55:45 +0530 From: Jerin Jacob To: Matan Azrad Cc: "dev@dpdk.org" , "ferruh.yigit@intel.com" , Thomas Monjalon , Konstantin Ananyev , Pavan Nikhilesh Message-ID: <20180212092544.GA24831@jerin> References: <20180210094220.16201-1-jerin.jacob@caviumnetworks.com> <20180212055439.6462-1-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) X-Originating-IP: [122.178.204.19] X-ClientProxiedBy: BM1PR0101CA0065.INDPRD01.PROD.OUTLOOK.COM (10.174.220.155) To BN3PR07MB2516.namprd07.prod.outlook.com (10.167.4.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1ac721d2-ec8a-4c65-880c-08d571faa386 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:BN3PR07MB2516; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2516; 3:d0hh46pdx0j0Pyrf6iilOQknTWUQmYzcixi+48SW+QlNhd/8KWWmMgkDRsGbRjY1pLVAz7e3RQn7d2rJ+kugCeUGMJfFGBGfWmTyUpn9+oLdorwEMxbRXMJvO58CY0eAhswZcn7CPEpWt3tQVdP3OS3LcnhJBnxo90+UzH9lKBcxcqR8xCLNKaj0gpDUjH/vWaLsPEQU4NwGHgcK6GSv6KjzcQ1GgnlfA+hCcS927jIqZK5m7B8nSVRxHNKGfoI+; 25:4inCwuziMhWmgN9LKQXioEgqbihEdiUNLlImhDp8ybAmNdEzDrgXeXtrkxCFPcbtMzJp5mtJSD6niGF44OLr7pRTILmBIx9vuw0YJOZDRcI3czuLSlvMDufImwtklBHHhr3qXjvVpmAawDI5FCRqrJNidQu79P2FI+2QMt/WJnwV2xomqPDH4bGd/Z3xeJ698jzDr9XXjjEr0RCVyS3gPY/nQcgICdnp2QWNDlPj8+0wcP/bmv58nzfw86DQkBvxBhoa9/t05mcqg0MouYQmkLR8Vo9Fj40EnkdWP43em+I2kAhQjiXMYPb6shSuxfOEmucczj0D9CBDorORWQa0jg==; 31:iUGPtUHJr3BBizAU6gAqcUO70CrApGTZbrHaTT0BkZIglxy4hjlLXwGosX1ExJixaVINtkr8VlegHKGbVodHYHrtSlJz9pa14MSDwBTZTs5320Z0eoNVFBDdzLlNMqSDHK3r9a0eyhUGXrEsnnjjsjJGuCwAZRJLELc8DyG+82qpGURyj8NFc474Y9ev9BL7TgcZA96WkGgrOFhUf3RRfI+s1+oirBQ/OVMJbD8SceE= X-MS-TrafficTypeDiagnostic: BN3PR07MB2516: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2516; 20:ZaGQ5n3z9LAlzXF9pI/SjZWDo7aTcWCnxIBLyP0JIUicHPe802xErgMDmAdtarix7V4pq9+aYUwitVcni+N+rSvuqhP7PlJnGcmw13C75F2Hfw37ZK/kvTFqLWtLtyxJeY2uGEQym5QT7qMOBCVWNoRdSpB/UWu9QTgA5va0plyRDZwvfH3wOvFvuIgU+j3kecCLNMqnIlHEYNG1NGO+fjieQu8gA/A3Cyf1CvS3ll007KqRuyVd/DbyvSnfk06U/8PX6OE98IrLPrbo6k34nwmRt4bXqdGJLO11p8rtiY6f3J//0IeTCrQxD2FK01ayNjrAvu6afNKvKW7TxiAzFhMkD/23zGEm+giN8co2RS7uhBFeBj3OwVMVWSQd3aVI8wwtxIRfpkKq60Y4AU7S+s/uiTRvzaEPAm3G9Ye1vDjTMgn+K8wGePLWu0g+dDkLCs8ljtQRBtFbxlldtZuIM7VqvLZkHvPSgRA/xAd9ZSK3XOjp+eAQE0N+Gi9P5E4KFbmDMuqKtl1vC9G0/jpSk7LkYlpH5aPJhcLniAQ6mhALTKWwFogNuDDpC/iyLWMPgH6FldND642YWe6lggkqfYetsovR7XSP2hQ0/ihlYho= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(60795455431006)(189930954265078)(45079756050767)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3231101)(2400082)(944501161)(93006095)(3002001)(10201501046)(6041288)(20161123564045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:BN3PR07MB2516; BCL:0; PCL:0; RULEID:; SRVR:BN3PR07MB2516; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2516; 4:Q89ka+Oe/Wk60r2iqA+jrIq4n4V5Qde91mU4+f9vlOjGMNjmrU/PZcbvm1qaS1W81utnh76SeVoP8Z7uwVOYU1ktsaT49yGhZtquvfFqlREPt1UIGLRqIzo5/WNimxpEKjzAGRSNHgmAi4pP+njLyqtAaEW9nk/OkU8o7KsbMJJxkcKO3WS1lvrCkQQbIgR0AicnfnG0KCxvIIItgmnq+ZM9K3vMWd9fbd/T6gGa00CIIwH2WlOABH8RtvIJrec227a2aGKyCJMLfJsk6A0yzMZedJZS8CJ/1MHviFJup52l7Db5BVnWkuG9WyjxqZOYLcb8hFCjPSgqZ4/vlVT9emuRAnA7BW42prXTUikbCef9JId97eQIB3RB7QXtlezmJniFARMebdxBHfICLDnvW2WD/qrpX3vw51D4Uo9FQco= X-Forefront-PRVS: 0581B5AB35 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39850400004)(396003)(39380400002)(376002)(346002)(189003)(199004)(13464003)(51444003)(81166006)(8676002)(8936002)(81156014)(9686003)(575784001)(6306002)(33716001)(47776003)(66066001)(50466002)(386003)(59450400001)(23726003)(6496006)(6666003)(83506002)(107886003)(1076002)(76176011)(53936002)(52116002)(42882006)(3846002)(54906003)(2950100002)(316002)(58126008)(26005)(16526019)(6116002)(16586007)(186003)(55016002)(2906002)(6246003)(33896004)(6916009)(4326008)(45080400002)(72206003)(68736007)(106356001)(966005)(105586002)(25786009)(305945005)(7736002)(97736004)(5660300001)(229853002)(33656002)(478600001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2516; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2516; 23:ir/mJscXmwq8vEZJy3YOS6VJCG2dAbUHX1cy+tvkS?= =?us-ascii?Q?IlnxnzWAXz7YyrsMaqGex+X6llEZGbzDlcseu31j98r5idGnaynPy/v0SwNb?= =?us-ascii?Q?Ag1AEWHDgoEQSBxbuaAsGfKbErfog8bT75PrBKI1QjRHptBjyx9RbGixJpu2?= =?us-ascii?Q?oxXKa9rvHPxHNcPlKO+TanSl6RTQ8LV06STqwWGUqQuqdJ4ZawnoxL3dayzE?= =?us-ascii?Q?V035WO5ewqkJTDRCgGddC8rFh3GzOAT85/r1VNiuDjL9Z1OBrreJPUICwH/V?= =?us-ascii?Q?GtH8OAcAXvQF8QTNbe4UgtUA/G2cOlBpiOGl/YQIWHMNpCauwIHUMY/UdIEI?= =?us-ascii?Q?vsPr7+GIFcS3BjkpqZvTVVICRl643v+QLnjzLI2YKkRIyqUHen9vJ4irk0a1?= =?us-ascii?Q?xZ3YChUUmaNze6GoDgQ53fpPnZpabu2iqwbLl+VUNQgxJ93h09XGFFLNctwn?= =?us-ascii?Q?ys2sgD3THiIO3PfSjzA3sWvveGiMtFOz4yTW94BDQaIV2L18FcD9WzF6+JQ0?= =?us-ascii?Q?qOzlREZCjSoa/wHecAeh6mr8N5tFHIzEFPSUWWU/bnZrhfQYT/EseKAZoPa8?= =?us-ascii?Q?AaJvvKC4BRIH1PQal57RclYz43pB0229yZQooB1IkIF6hVPTVfWdFdknJS+8?= =?us-ascii?Q?KF9FP04xhOd0tRLvWAHFd3q1XtGDHPvNbVUNNIOhXRNquZV8Iw4sZwf44ZbF?= =?us-ascii?Q?9nOqoPUxUvh4Qptn2WHVQvmYx/VQkXh78NRIL6NgPulEUurRG0XDhuEBftzo?= =?us-ascii?Q?ldOLrbNR9ggtcVDkuhZ3TKJy78oAWxGtHhACFI8sRs2TuF2/F72UbYdOv8BV?= =?us-ascii?Q?1jPLeyBc4WJLCX4afuHuuOEmGGR+4xipD+pGrIvCoBd22AoHhnuOO9Y+JjOR?= =?us-ascii?Q?OFqc99tZFERENm9Z/56o1lJcbUrwWr2ISEBw4JHu8CGHFAnrNNB6VfL24pJJ?= =?us-ascii?Q?mVEJ5ArWxlwo0saRcktNg8FFJc9MYU0xOPEa51vNwdLJu+sXQ6UgIiido2KV?= =?us-ascii?Q?n7p+zm+3Bq+1nbQuychAtrwCSPyoUt2cnaGAOFROu4pjD76djL6Zc3jRwD3c?= =?us-ascii?Q?7ngiBJXND8ZmO4BRr+Pit+nCfXO84notC2Ly2tNrrHJP41ES9JW58DkrBpjS?= =?us-ascii?Q?new9l5bGhbfMqm+cDjRbD/Lv8ZVHfDUul/+zumww0gPSfvnpxIKbhS/dd0Q4?= =?us-ascii?Q?GBOHh4sauenAP2VxFBQFNMMPFKIFO91CnDx4hw9Ac9auB/R1y1HQ+khAVKKV?= =?us-ascii?Q?3oLc8s5e9+75Kbb2fp/08jn7Vs9AOi+ZFmr9Evz2cfNc2DyoCuDPJpXiGX5z?= =?us-ascii?Q?pE/fKF4V8TUS4n9chgF2r5uYhLH72/TwG0XeR6UdkqKeGEeWF4Gx4Sej2YZ4?= =?us-ascii?Q?A8R2qUiN0GudgfslXxc+MzkkkOQRtrI3rxE4De0RZjhIchHfPtkWTJDFhr0G?= =?us-ascii?Q?YAkRt1GdzMrsN3sBh1DEHOJxq9+fOU=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2516; 6:UfBu0z2d5uLnp5pkxdwjitShSI6DU9ErtC4n/YyQb++YMA+OzOAco0Be8CnXIV2uABtcRzJ/OmqtTqdaGj+of2yCwK/Bdmc0NosUBn384mOHtHs77fYo9nNzYMCnNz9v9rhAQ2IBOvo7qfPEnVAOBZzlRx72gRyBjlLYctlwPkw97pPXIv93D/mrOtIKIXoAWmRpYaitrOOwOjjmfcQazK9Ie5Ei8n8OyxXYcqk6z1ZGisUJR7C3OPk0CXnLVheZ37pm2PHh5c8X8nXuc94lBSe0mfYV5dJhL34oj821gKOHeIJ6Qkyjm2VZDmEZMQS6EwiMs8LzWlfQupigVtOe23+Fa2arTSf0WWYyFyTbOtM=; 5:OwBWo3WoOrRmJdllfrqgP6Vszqcfsgcjlw/zPXXk+bcAkd/NeCX07BqYOwQapzHnPLBdUFFCVTYNd2QYqCJzWB1FYAF00XzqQpFmweRtFnQxTSPPlM7UPLyGgHSOgsAsSRxgvGJ1bCTdme/MvjhHC7D9OsZLJttxhBtiDEHBmgo=; 24:1hrsjJLJutATC6oVI4HPMwz35A9eRz3bhoG5MLgyNM8sa1ptIapM7Fn8c8W6LKZLABvL0HIoXBeIh4Bmm2+HKWPobdouaMkQ8xhZ4ZqNjA0=; 7:nZOS4RiL7FKZ8HkfwBFS1axSk/CC7IcvkJS3tXFW/yIXU5VlEPkT8+EvfQ2dfmvAXKoO6fwjm7bL/jcryqCP1j5NTaunxRUuYvXniX+qgXS3WYpMwN7WI/fDrPG3AhSycXoizOEe0X7IxifY/6cmOKLdzxlvt43wQWc3rNcOiyBU1+Pk/AdkB60/l9yHsjZPp4aRdNEpoCnTUyCm/wEQOxzar38yEkGhPi+VkkDRW0b8sj3Jp23jz6b8kmAnSx/E SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2018 09:26:02.2058 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1ac721d2-ec8a-4c65-880c-08d571faa386 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2516 Subject: Re: [dpdk-dev] [PATCH v2] ethdev: make ethdev data cache aligned X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2018 09:26:07 -0000 -----Original Message----- > Date: Mon, 12 Feb 2018 09:04:07 +0000 > From: Matan Azrad > To: Jerin Jacob , "dev@dpdk.org" > > CC: "ferruh.yigit@intel.com" , Thomas Monjalon > , Konstantin Ananyev , > Pavan Nikhilesh > Subject: RE: [dpdk-dev] [PATCH v2] ethdev: make ethdev data cache aligned > > Hi Jerin > > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > > Since struct rte_eth_dev_data used in the fast path, making it as cache > > aligned. > > > > Fixes: af75078fece3 ("first public release") > > Fixes: 5b7ba31148a8 ("ethdev: add port ownership") > > Looks like it is just improvement. > No need the above "fixes" lines (also fix title is not needed as you did). I think, It varies the way we look at it. I don't think, either way it matters in the commit log. See below, > > I think that performance improvement results should be added to the commit log. I added following under comment section. Do you this want to move git commit message ? If so, I can send the v3. - Some platform like thunderx + l3fwd showed 1% regression in the performance with 5b7ba31148a8 ("ethdev: add port ownership") in one port setup. > > Moreover, Did you investigate which fields in rte_eth_dev_data structures are important for performance and should not be in a different cache lines? No. That can be separate patch. > Maybe alternative order of the fields in the structure may improve the performance more... Maybe. > > > Cc: Matan Azrad > > Cc: Thomas Monjalon > > Cc: Konstantin Ananyev > > > > Signed-off-by: Jerin Jacob > > Signed-off-by: Pavan Nikhilesh > > --- > > v2: > > - Change the git comments based on Matan's feedback > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdp > > dk.org%2Fdev%2Fpatchwork%2Fpatch%2F35104%2F&data=02%7C01%7Cmat > > an%40mellanox.com%7C5c2537b12e6d4e51f12a08d571dd33a2%7Ca652971c7 > > d2e4d9ba6a4d149256f461b%7C0%7C0%7C636540117238324576&sdata=8OOg > > Zb0KzDbBce9xPVywV8ynmiKP9B%2BbYsQxgE5VlX0%3D&reserved=0 > > > > - Some platform like thunderx + l3fwd showed 1% regression in the > > performance with 5b7ba31148a8 ("ethdev: add port ownership") in one port > > setup. > > > > - If there are no objection for this change then request to take it for v18.02 > > release. > > --- > > lib/librte_ether/rte_ethdev_core.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/librte_ether/rte_ethdev_core.h > > b/lib/librte_ether/rte_ethdev_core.h > > index 315b31723..e5681e466 100644 > > --- a/lib/librte_ether/rte_ethdev_core.h > > +++ b/lib/librte_ether/rte_ethdev_core.h > > @@ -601,7 +601,7 @@ struct rte_eth_dev_data { > > struct rte_vlan_filter_conf vlan_filter_conf; > > /**< VLAN filter configuration. */ > > struct rte_eth_dev_owner owner; /**< The port owner. */ -}; > > +} __rte_cache_aligned; > > > > /** > > * @internal > > -- > > 2.16.1 >