From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <tiwei.bie@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
by dpdk.org (Postfix) with ESMTP id C3C901B2E6;
Mon, 12 Feb 2018 10:41:36 +0100 (CET)
X-Amp-Result: UNSCANNABLE
X-Amp-File-Uploaded: False
Received: from orsmga006.jf.intel.com ([10.7.209.51])
by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
12 Feb 2018 01:41:35 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,501,1511856000"; d="scan'208";a="17775498"
Received: from debian.sh.intel.com (HELO debian) ([10.67.104.164])
by orsmga006.jf.intel.com with ESMTP; 12 Feb 2018 01:41:33 -0800
Date: Mon, 12 Feb 2018 17:40:07 +0800
From: Tiwei Bie <tiwei.bie@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: yliu@fridaylinux.org, ferruh.yigit@intel.com, victork@redhat.com,
dev@dpdk.org, stable@dpdk.org, zhihong.wang@intel.com,
qian.q.xu@intel.com, lei.a.yao@intel.com
Message-ID: <20180212094007.afnnc6lzeglpwb4a@debian>
References: <20180209142654.29409-1-maxime.coquelin@redhat.com>
<20180209142654.29409-3-maxime.coquelin@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20180209142654.29409-3-maxime.coquelin@redhat.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH 2/2] vhost: don't take access_lock on
VHOST_USER_RESET_OWNER
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Feb 2018 09:41:37 -0000
On Fri, Feb 09, 2018 at 03:26:54PM +0100, Maxime Coquelin wrote:
> A deadlock happens when handling VHOST_USER_RESET_OWNER request
> for the same reason the lock is not taken for
> VHOST_USER_GET_VRING_BASE.
>
> It is safe not to take the lock, as the queues are no more used
> by the application when the virtqueues and the device are reset.
>
> Fixes: a3688046995f ("vhost: protect active rings from async ring changes")
> Cc: stable@dpdk.org
>
> Cc: Victor Kaplansky <victork@redhat.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
Thanks for the work!
Best regards,
Tiwei Bie