From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: Matan Azrad <matan@mellanox.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/failsafe: fix Rx interrupt reinstallation
Date: Wed, 14 Feb 2018 16:01:29 +0100 [thread overview]
Message-ID: <20180214150129.ajvb2otj5xogpn3i@bidouze.vm.6wind.com> (raw)
In-Reply-To: <20180214150013.qejbi426ajglhuua@bidouze.vm.6wind.com>
On Wed, Feb 14, 2018 at 04:00:13PM +0100, Gaëtan Rivet wrote:
> On Wed, Feb 14, 2018 at 02:47:26PM +0000, Matan Azrad wrote:
> > Fail-safe dev_start() operation can be called by both the application
> > and the hot-plug alarm mechanism.
> >
> > The installation of Rx interrupt are triggered from dev_start() in any
> > time it is called while actually the Rx interrupt should be installed
> > only by the application calls.
> >
> > So, each plug-in event causes reinstallation which causes memory leak
> > and spoils the fail-safe Rx interrupt mechanism.
> >
> > Trigger the Rx interrupt installation only when it does not exist.
> >
> > Fixes: 9e0360aebf23 ("net/failsafe: register as Rx interrupt mode")
> >
> > Signed-off-by: Matan Azrad <matan@mellanox.com>
>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Actually no!
There is a mistake in the patch, you disabled the uninstall, instead of
the installation.
--
Gaëtan Rivet
6WIND
next prev parent reply other threads:[~2018-02-14 15:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 22:59 [dpdk-dev] [PATCH] " Matan Azrad
2018-02-14 13:52 ` Gaëtan Rivet
2018-02-14 13:59 ` Matan Azrad
2018-02-14 14:47 ` [dpdk-dev] [PATCH v2] " Matan Azrad
2018-02-14 15:00 ` Gaëtan Rivet
2018-02-14 15:01 ` Gaëtan Rivet [this message]
2018-02-14 15:11 ` Matan Azrad
2018-02-14 15:12 ` Gaëtan Rivet
2018-02-14 15:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214150129.ajvb2otj5xogpn3i@bidouze.vm.6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).