From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f65.google.com (mail-pl0-f65.google.com [209.85.160.65]) by dpdk.org (Postfix) with ESMTP id 965501B2C7 for ; Thu, 15 Feb 2018 19:55:22 +0100 (CET) Received: by mail-pl0-f65.google.com with SMTP id t4so343489plo.0 for ; Thu, 15 Feb 2018 10:55:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7VTj06G0wZU0wguAYS7JpmSulnMILmTvVGOPzyXtxBo=; b=JCyRni2o7McoWKYcsr36HrT3IcswFab2zvLUbG9PErOfWt34kNsi+r/qTAYe1kQgyp AZIfZvYlUx0ddw599E25EWGyF1/+iKs/EbRCTjsDHKuuLOnnYbo3IylyMtfYxYniXrNj 7Flxp6BUztBQ+byeqdZ4NP0AyBTfXYk1sgCLe2OSkj4eWSaF8jSKrJngOFyx9NMCUkOq LoLHxLdyR0Lsg5L7bCcvHrYVOrp6tYjVRoj9irkMCDOMjk6IMItSqpkdNXsV9RgSAaph BAb7f1ErutPmvuoLAFpj3ANnsLHr8jNuwBY+ujEMiUR2fndGbzGxRve82E99rNYgSk7V uyTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7VTj06G0wZU0wguAYS7JpmSulnMILmTvVGOPzyXtxBo=; b=Wgkqr193G7gZ1JcCy96FnBJ+UZn8qp+rEKAoD6pwW+eCvlv2kuA1vHjrMOXdBf+ZJL dN2wUvYJXAKM2Em3W0u3BpZYBMjlyU/iIEhhrXjgC4+hkvNn45/DWC+p1ToPaGzFG2RW /5FgNFGk+EK32Y6SWW4O+BXsyyak+8eKWRZ9aGFi7A4HxvvvBiIifkZ/82sumZpd8M/b eHC06nY4qWyILtmsivgtU/sbVseEVm/IelKbbskhv7JVYFcyWdTjiG+/y9OLPfnNCQad MjVpubtl5dVjlWgHUFborw5et9LVcaOp9ci6FW0u6eVKegN7p9rl2Nj7cXnd3bHz3HCO 2V0g== X-Gm-Message-State: APf1xPBHcLn8qJ8+fQ0wbRRhFROtvXrgOAsQ6w3O7kfnDGWJbvxgr4OJ TmoXEOuK5kiUfz+uZSRr7B2CFg== X-Google-Smtp-Source: AH8x226JUddcdl4lt9Ex5aOK3qsFyyzQT7srvy+DvNMmzYcANarxyZWEqfV/kDf58aBu4vvJIaCGtw== X-Received: by 2002:a17:902:2803:: with SMTP id e3-v6mr3315087plb.447.1518720921722; Thu, 15 Feb 2018 10:55:21 -0800 (PST) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id f4sm16855666pfn.82.2018.02.15.10.55.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Feb 2018 10:55:21 -0800 (PST) Date: Thu, 15 Feb 2018 10:55:19 -0800 From: Stephen Hemminger To: Martin Klozik Cc: Thomas Monjalon , dev@dpdk.org Message-ID: <20180215105519.59319db9@xeon-e3> In-Reply-To: <1518534227-104477-1-git-send-email-martinx.klozik@intel.com> References: <1518534227-104477-1-git-send-email-martinx.klozik@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ethdev: adjust error log level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Feb 2018 18:55:22 -0000 On Tue, 13 Feb 2018 15:03:47 +0000 Martin Klozik wrote: > DPDK API does not propagate the reason of device allocation failure > from rte_eth_dev_allocate() up to the DPDK application (e.g. Open > vSwitch). > Log level of associated log entries was changed to warning. So user > can find additional details in log files also in production systems, > where debug messages cannot be turned on. > > Signed-off-by: Martin Klozik > --- > lib/librte_ether/rte_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index a6ce2a5..0590f0c 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -277,12 +277,12 @@ rte_eth_dev_allocate(const char *name) > > port_id = rte_eth_dev_find_free_port(); > if (port_id == RTE_MAX_ETHPORTS) { > - RTE_PMD_DEBUG_TRACE("Reached maximum number of Ethernet ports\n"); > + RTE_LOG(ERR, EAL, "Reached maximum number of Ethernet ports\n"); > goto unlock; > } > > if (rte_eth_dev_allocated(name) != NULL) { > - RTE_PMD_DEBUG_TRACE("Ethernet Device with name %s already allocated!\n", > + RTE_LOG(ERR, EAL, "Ethernet Device with name %s already allocated!\n", > name); > goto unlock; > } Should be NOTICE not ERROR. Since this is a recoverable condition.