From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 5AF051B29B for ; Fri, 16 Feb 2018 15:27:05 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id f3so3475619wmc.1 for ; Fri, 16 Feb 2018 06:27:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0kfykWZpJeAwWvHJXh2N3qIS/dHNiuF87h6SCP0lydY=; b=Jp3NUHy7jzJ/1HLkjfiiUGtF0BI44pZ7EMyaVQXF+2wB6ul3qCdWcEuQxZTpMvlwxY n/G2y19QkzXmwkHw3RIrCsG8xURjaOh0qqicTqy9QvPrntc/UYWQh4gr5e6I3iIH/8MO Kbt7tcNn5P+u3CiMHAt5HfmC8uYXP0k/2DFNQz6d8XmPNRxTVAAlxL/xo7niwmkDvbCy 8FYHiks89ZV6TzN5Yub6YawwCK9M1xuhqW2WnwSAfKxGV1kQ1vltHC+CfyKUzzxRpY+N yeTyo5p16jHWjB2tSMy1s4RiBECq1KXM9KC+j+ZAImrbPTjyurDsmioR7O59Nfwm7YhB H6iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0kfykWZpJeAwWvHJXh2N3qIS/dHNiuF87h6SCP0lydY=; b=mMSbyreoJ4asMG90HLePre9LcTaPCM8RHa7FzeuNhmRcpa3oykoLipNW/1e08OfNx/ waX+LmqSolHN7j4qSebZ+W2zL0iOMBwqy8Pt6+rWsyjijnPmuubzEzetleu+C5NFFg1v DHdGFk9Aiuq/cs3lrLTjomTOKrVANvOfWXIJqUiAuBNTM22BPJOly0R3PTVi8mj6pe+5 pKxeciiOMQ/zPTxhXF+ZuTbsh4IZpL3PbWzqXlJIuGUhveo7xJ9QJqbgpEnSGVOWVK25 OamBI9CHBRju87BkLOSw8S+NhY7zL2oAvaTUoI/8yKUPXPatsE0E++X5QkR3+qy6R916 szPA== X-Gm-Message-State: APf1xPBwEsDXcah/QjLoIYcFlvsL0t+wsH6yGxrMa4RIFl5qW4CYlGLg jGtFM4UcQIUzcgychsH3NXyjTw== X-Google-Smtp-Source: AH8x226FIMsoErz7VgiGLZpGbjYK13LmKJOy/W7Gldzc2b7SDIzMoA5ZQb2IenTannF5FPJUEMivhg== X-Received: by 10.28.94.211 with SMTP id s202mr4862770wmb.159.1518791224539; Fri, 16 Feb 2018 06:27:04 -0800 (PST) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 30sm13755174wri.48.2018.02.16.06.27.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Feb 2018 06:27:03 -0800 (PST) Date: Fri, 16 Feb 2018 15:26:51 +0100 From: Adrien Mazarguil To: Nelio Laranjeiro Cc: dev@dpdk.org, Yongseok Koh , stable@dpdk.org Message-ID: <20180216142651.GG4256@6wind.com> References: <20fc1ef17c45c727fe72182fa0ba89313fdb430d.1518686930.git.nelio.laranjeiro@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20fc1ef17c45c727fe72182fa0ba89313fdb430d.1518686930.git.nelio.laranjeiro@6wind.com> Subject: Re: [dpdk-dev] [PATCH 3/3] net/mlx5: fix traffic restart function to return errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Feb 2018 14:27:05 -0000 On Thu, Feb 15, 2018 at 10:29:27AM +0100, Nelio Laranjeiro wrote: > priv_dev_traffic_restart() was considering nothing could fail whereas it > can. How about simply describing it as: priv_dev_traffic_restart() must not ignore errors. > Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic") > Cc: stable@dpdk.org > > Signed-off-by: Nelio Laranjeiro > Acked-by: Yongseok Koh Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND