From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 470F11B16C for ; Mon, 19 Feb 2018 08:41:51 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id k87so13253219wmi.0 for ; Sun, 18 Feb 2018 23:41:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ILfk4V4itzLdzRRGAcBPn4A46BhJ5wGqHVVgQbKAkfc=; b=0Lri1nhfVJ8Pv0ltrW0H/gc7afKQXT7hbE82Ye0UX52aVp+uTNm0ODsMw2Ihh8Hdj1 OtxsbwY1FP5OqT+wgRBaZZE5SG3MzWIDmkxqfCvqEbCoqyS9O909HuAjyswXimHUnxTY rJA0bVzBfMQPFcy9gDmectZDP7vG5tEoXSJQS5Y8+ssI0aRhWtuXoEv9waBdLr1XKwfS 1GNaEeLkbNzTXc5qMKs0mcbIF0SHaBtJ/1j7zAQuwfGtWbIeRvznmBwbXwTPqiie2V0C kbnyw6oDEiKBDFvHj6+Sgj8IempsVc5wxMJvlrvwWOfQrpSEjSvmqLXphw+F2Fxzakcd gKug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ILfk4V4itzLdzRRGAcBPn4A46BhJ5wGqHVVgQbKAkfc=; b=o0ZFHyBypFU1QZFTEDv0yk5QmAarGPin99Ojtb49GuF1l2tgLp531AHGzXbSLdFQqY xG6C63IqOzT5Q20Qa6vFwIFb3CgSv2637mHyL9a4tz7/a5/6PHAAjkqOyQlas7WW6xf8 f7fXwwyxgH2g8xamDB/+cj+B7tRH+n1h8zGEkg2/9gAdjPfdBGN9LnuE8GCxKuCqkYVV nTiTgWHJl/kT2x8zcxpzAj0ErLa9o8TiX0qgjzHJmdIke3EKmxd57fXx5xnRtkaeJvSz kuAtggjD2Pd6+Qu/uQUY8WIVhT4u8KIsBbpTXRhqqduCn27fQH63/v/c4FDNMZxOshb/ 3GaA== X-Gm-Message-State: APf1xPDk5FrhY7cz7yTZ/UE8q2PDPxVMB9jbZJQYGPatStUBQCPklKJi 4gvLbhQICZWUofL0geCIITel X-Google-Smtp-Source: AH8x226tyqJ2KhvPMFT4VU23FosY+plTxV3ZsdwCJzHQ78xqXN/iTdjWeYjhK1z66beCa7TtKYVG3Q== X-Received: by 10.80.177.86 with SMTP id l22mr10697717edd.88.1519026110956; Sun, 18 Feb 2018 23:41:50 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id h2sm17074847edc.13.2018.02.18.23.41.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Feb 2018 23:41:50 -0800 (PST) Date: Mon, 19 Feb 2018 08:42:47 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Stephen Hemminger Cc: dev@dpdk.org, Adrien Mazarguil , Yongseok Koh Message-ID: <20180219074247.ntu4xysufkekjrgl@laranjeiro-vm.dev.6wind.com> References: <21fb91002768a627d9c7f3d81e0c8a12fbf6811f.1518684427.git.nelio.laranjeiro@6wind.com> <20180216100304.3335cb65@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180216100304.3335cb65@xeon-e3> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: add kernel version function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Feb 2018 07:41:51 -0000 On Fri, Feb 16, 2018 at 10:03:04AM -0800, Stephen Hemminger wrote: > On Thu, 15 Feb 2018 09:47:27 +0100 > Nelio Laranjeiro wrote: > > > Use a function to retrieve the version of the kernel. > > > > Signed-off-by: Nelio Laranjeiro > > This type of logic will run into problems with Enterprise and vendor kernels. > What about users using older kernels with OFED? What about case where kernel > MLX drivers have been backported? > > In general, it is better to adapt to the environment the code is running > in. Try the new feature, if it fails then log a message (at info level) > and fallback to the other strategy. We have already discussed it, this new API in the kernel is buggee between v4.5 to v4.9. As there is now way in between those version to detect if the API is the buggee one or not, we don't have any other solution. It is better to not use at all this new API than using a buggee one. -- Nélio Laranjeiro 6WIND