Re: [dpdk-dev] [PATCH 02/10] mempool/octeontx: probe timvf PCIe devices

[Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>]

On Sat, Feb 17, 2018 at 10:24:07AM +0530, Jerin Jacob wrote:
> -----Original Message-----
> > Date: Sat, 17 Feb 2018 03:06:52 +0530
> > From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > To: jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com,
> >  erik.g.carrillo@intel.com
> > Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH 02/10] mempool/octeontx: probe timvf PCIe devices
> > X-Mailer: git-send-email 2.16.1
> >
> > On Octeontx HW, each event timer device is enumerated as separate SRIOV VF
> > PCIe device.
> >
> > In order to expose as a event timer device:
> > On PCIe probe, the driver stores the information associated with the
> > PCIe device and later when appliacation requests for a event timer device
> > through `rte_event_timer_adapter_create` the driver infrastructure creates
> > the timer adapter with earlier probed PCIe VF devices.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> >  drivers/mempool/octeontx/Makefile                  |   1 +
> >  drivers/mempool/octeontx/meson.build               |   1 +
> >  drivers/mempool/octeontx/octeontx_mbox.h           |   7 +
> >  drivers/mempool/octeontx/octeontx_timvf.c          | 145 +++++++++++++++++++++
> >  .../octeontx/rte_mempool_octeontx_version.map      |   3 +
> >  usertools/dpdk-devbind.py                          |   8 ++
>
> I suggest to have separate patch for usertools/dpdk-devbind.py
> common code change.
>
> > diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> > index 18d938607..340643b70 100755
> > --- a/usertools/dpdk-devbind.py
> > +++ b/usertools/dpdk-devbind.py
> > @@ -22,11 +22,14 @@
> >                'SVendor': None, 'SDevice': None}
> >  cavium_pkx = {'Class': '08', 'Vendor': '177d', 'Device': 'a0dd,a049',
> >                'SVendor': None, 'SDevice': None}
> > +cavium_tim = {'Class': '08', 'Vendor': '177d', 'Device': 'a051',
> > +              'SVendor': None, 'SDevice': None}
> >
> >  network_devices = [network_class, cavium_pkx]
> >  crypto_devices = [encryption_class, intel_processor_class]
> >  eventdev_devices = [cavium_sso]
> >  mempool_devices = [cavium_fpa]
> > +eventtimer_devices = [cavium_tim]
>
> In order to reduce number of different type of device, IMO, we could
> group this also as "eventdev_devices" as it comes as sub device of
> eventdev.
>
> ie.
> eventdev_devices = [cavium_sso, cavium_tim]

Agreed, will do the specified changes and send it as a sperate patch.

Thanks,
Pavan.