From: Bruce Richardson <bruce.richardson@intel.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH v6] kernel folder for Linux and BSD modules
Date: Wed, 21 Feb 2018 10:56:10 +0000 [thread overview]
Message-ID: <20180221105609.GA2532@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <1519200571-12620-1-git-send-email-hemant.agrawal@nxp.com>
On Wed, Feb 21, 2018 at 01:39:31PM +0530, Hemant Agrawal wrote:
> This patch moves the kernel modules code from EAL to a common place.
> - Separate the kernel module code from user space code.
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Tested-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> v6: added meson build support
> v5: rearrange kernel compliation as per Bruce's suggestion
> v4: update the path in MAINTAINERS
> v3: move contigmem from bsdapp
> v2: rename kern to kernel, add freebsd modules as well
>
Hi Hemant,
from testing on FreeBSD, I believe these are the changes needed to allow
compilation with meson there. Nothing too drastic - mainly fix up the
folder names, and skip the subdir into the higher-level "freebsd" folder.
/Bruce
diff --git a/kernel/meson.build b/kernel/meson.build
index a5d5df7dd..697c419b6 100644
--- a/kernel/meson.build
+++ b/kernel/meson.build
@@ -13,7 +13,6 @@ if host_machine.system() == 'linux'
elif host_machine.system() == 'freebsd'
dpdk_conf.set('RTE_EXEC_ENV_BSDAPP', 1)
- subdir('freebsd')
kmods = ['contigmem', 'nic_uio']
# for building kernel modules, we use kernel build system using make, as
@@ -26,9 +25,9 @@ elif host_machine.system() == 'freebsd'
'-I' + join_paths(meson.source_root(), 'config'),
'-include rte_config.h']
foreach k:kmods
- subdir(join_paths('bsdapp', k))
+ subdir(join_paths('freebsd', k))
custom_target(k,
- input: [files('bsdapp/BSDmakefile.meson'), sources],
+ input: [files('freebsd/BSDmakefile.meson'), sources],
output: k + '.ko',
command: ['make', '-f', '@INPUT0@',
'KMOD_SRC=@INPUT1@',
next prev parent reply other threads:[~2018-02-21 10:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 5:57 [dpdk-dev] [PATCH] Create kern folder for Linux kernel modules Hemant Agrawal
2017-12-22 8:43 ` Thomas Monjalon
2017-12-22 10:04 ` Hemant Agrawal
2017-12-22 11:38 ` Thomas Monjalon
2017-12-22 13:59 ` Wiles, Keith
2017-12-22 14:17 ` Thomas Monjalon
2017-12-22 14:51 ` Wiles, Keith
2017-12-22 16:25 ` Hemant Agrawal
2017-12-22 14:28 ` Van Haaren, Harry
2017-12-22 13:05 ` Burakov, Anatoly
2017-12-26 6:46 ` [dpdk-dev] [PATCH v2] kernel folder for Linux and BSD modules Hemant Agrawal
2017-12-26 8:10 ` Tiwei Bie
2017-12-26 8:50 ` Hemant Agrawal
2017-12-26 8:58 ` [dpdk-dev] [PATCH v3] " Hemant Agrawal
2018-01-10 6:46 ` [dpdk-dev] [PATCH v4] " Hemant Agrawal
2018-01-10 11:04 ` Richardson, Bruce
2018-01-12 15:00 ` [dpdk-dev] [PATCH v5] " Hemant Agrawal
2018-02-21 8:09 ` [dpdk-dev] [PATCH v6] " Hemant Agrawal
2018-02-21 10:56 ` Bruce Richardson [this message]
2018-02-22 6:09 ` [dpdk-dev] [PATCH v7] " Hemant Agrawal
2018-03-21 18:42 ` Thomas Monjalon
2018-03-22 10:27 ` Bruce Richardson
2018-03-22 10:48 ` Thomas Monjalon
2018-03-22 16:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221105609.GA2532@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).