* [dpdk-dev] [PATCH] net/mlx5: fix disabling Tx packet inlining
@ 2018-02-26 17:50 Yongseok Koh
2018-02-27 7:50 ` Nélio Laranjeiro
0 siblings, 1 reply; 3+ messages in thread
From: Yongseok Koh @ 2018-02-26 17:50 UTC (permalink / raw)
To: adrien.mazarguil, nelio.laranjeiro; +Cc: dev, Yongseok Koh, stable
Adding 'txq_inline=0' to PMD parameter should disable Tx packet inlining
but it doesn't work properly for Enhanced Multi-Packet Send.
Fixes: 6ce84bd88919 ("net/mlx5: add enhanced multi-packet send for ConnectX-5")
Cc: stable@dpdk.org
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Shahaf Shuler <shahafs@mellanox.com>
---
drivers/net/mlx5/mlx5_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index dc4ead934..049f7e6c1 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -1382,7 +1382,7 @@ txq_burst_empw(struct mlx5_txq_data *txq, struct rte_mbuf **pkts,
(!txq->mpw_hdr_dseg ||
mpw.total_len >= MLX5_WQE_SIZE);
}
- if (do_inline) {
+ if (max_inline && do_inline) {
/* Inline packet into WQE. */
unsigned int max;
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix disabling Tx packet inlining
2018-02-26 17:50 [dpdk-dev] [PATCH] net/mlx5: fix disabling Tx packet inlining Yongseok Koh
@ 2018-02-27 7:50 ` Nélio Laranjeiro
2018-03-11 13:19 ` [dpdk-dev] [dpdk-stable] " Shahaf Shuler
0 siblings, 1 reply; 3+ messages in thread
From: Nélio Laranjeiro @ 2018-02-27 7:50 UTC (permalink / raw)
To: Yongseok Koh; +Cc: adrien.mazarguil, dev, stable
On Mon, Feb 26, 2018 at 09:50:57AM -0800, Yongseok Koh wrote:
> Adding 'txq_inline=0' to PMD parameter should disable Tx packet inlining
> but it doesn't work properly for Enhanced Multi-Packet Send.
>
> Fixes: 6ce84bd88919 ("net/mlx5: add enhanced multi-packet send for ConnectX-5")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index dc4ead934..049f7e6c1 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -1382,7 +1382,7 @@ txq_burst_empw(struct mlx5_txq_data *txq, struct rte_mbuf **pkts,
> (!txq->mpw_hdr_dseg ||
> mpw.total_len >= MLX5_WQE_SIZE);
> }
> - if (do_inline) {
> + if (max_inline && do_inline) {
> /* Inline packet into WQE. */
> unsigned int max;
>
> --
> 2.11.0
>
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix disabling Tx packet inlining
2018-02-27 7:50 ` Nélio Laranjeiro
@ 2018-03-11 13:19 ` Shahaf Shuler
0 siblings, 0 replies; 3+ messages in thread
From: Shahaf Shuler @ 2018-03-11 13:19 UTC (permalink / raw)
To: Nélio Laranjeiro, Yongseok Koh; +Cc: Adrien Mazarguil, dev, stable
Tuesday, February 27, 2018 9:51 AM, Nélio Laranjeiro
> On Mon, Feb 26, 2018 at 09:50:57AM -0800, Yongseok Koh wrote:
> > Adding 'txq_inline=0' to PMD parameter should disable Tx packet
> > inlining but it doesn't work properly for Enhanced Multi-Packet Send.
> >
> > Fixes: 6ce84bd88919 ("net/mlx5: add enhanced multi-packet send for
> > ConnectX-5")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> > Acked-by: Shahaf Shuler <shahafs@mellanox.com>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied to next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-11 13:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-26 17:50 [dpdk-dev] [PATCH] net/mlx5: fix disabling Tx packet inlining Yongseok Koh
2018-02-27 7:50 ` Nélio Laranjeiro
2018-03-11 13:19 ` [dpdk-dev] [dpdk-stable] " Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).