Re: [dpdk-dev] [PATCH 08/10] event/octeontx: add option to use fpavf as chunk pool

[Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>]

Hi Gabriel,

On Fri, Feb 23, 2018 at 08:17:07PM +0000, Carrillo, Erik G wrote:
> Hi Pavan,
>
> > -----Original Message-----
> > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> > Sent: Friday, February 16, 2018 3:37 PM
> > To: jerin.jacob@caviumnetworks.com;
> > santosh.shukla@caviumnetworks.com; Carrillo, Erik G
> > <erik.g.carrillo@intel.com>
> > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH 08/10] event/octeontx: add option to use fpavf
> > as chunk pool
> >
> > Add compile-time configurable option to force TIMvf to use Octeontx FPAvf
> > pool manager as its chunk pool.
> > When FPAvf is used as pool manager the TIMvf automatically frees the
> > chunks to FPAvf through gpool-id.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
>
> <...snipped...>
>
> > @@ -241,7 +243,16 @@ timvf_add_entry_brst(struct timvf_ring *timr, const
> > uint16_t rel_bkt,
> >  				bkt->first_chunk = (uint64_t) chunk;
> >  			}
> >  		} else {
> > +#ifndef RTE_PMD_OCTEONTX_TIMVF_USE_FPAVF
> >  			chunk = timr_clr_bkt(timr, bkt);
> > +#else
> > +			if (unlikely(rte_mempool_get(timr-
> > >meta.chunk_pool,
> > +							(void **)&chunk))) {
> > +				timr_bkt_set_rem(bkt, 0);
> > +				tim[index]->state =
> > RTE_EVENT_TIMER_ERROR;
> > +				return -ENOMEM;
>
> You return a negative errno value here, but in this case the caller was expecting the number that succeeded.

Agreed, will add a check in `timvf_timer_reg_brst`[1] to check if call to
timvf_add_entry_brst has failed.

[1]http://dpdk.org/dev/patchwork/patch/35206/

>
> Regards,
> Gabriel

Thanks,
Pavan.

>
> > +			}
> > +#endif
> >  			bkt->first_chunk = (uint64_t) chunk;
> >  		}
> >  		*(uint64_t *)(chunk + nb_chunk_slots) = 0; @@ -355,7
> > +366,18 @@ timvf_add_entry_sp(struct timvf_ring *timr, const uint32_t
>
> <...snipped...>
>