From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0084.outbound.protection.outlook.com [104.47.41.84]) by dpdk.org (Postfix) with ESMTP id 4E66E126B for ; Mon, 26 Feb 2018 20:25:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Tz9djAnQlevvKIvxkj56EZp1llcP9KFh1HWS0mZfPyM=; b=mJUwpHdrIb24QhWSggjc0xDnqv0ocvGmaHP4GS4MsQnRE+4BVuj7EI7M0eWFp+Bu+kE9L9UlBcpqqEq7sStqutEFpLRANOzVWFQckCGin4AW7+BmtYTGf8p8AP6fII20Uiow/rCyn8MQeosAzVeygAoQx87NlIcApgzPH54JUt4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (111.93.218.67) by MWHPR07MB3470.namprd07.prod.outlook.com (2603:10b6:301:63::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.527.15; Mon, 26 Feb 2018 19:25:25 +0000 Date: Tue, 27 Feb 2018 00:55:05 +0530 From: Pavan Nikhilesh To: "Carrillo, Erik G" , "jerin.jacob@caviumnetworks.com" , "santosh.shukla@caviumnetworks.com" Cc: dev@dpdk.org Message-ID: <20180226192504.GA10695@ltp-pvn> References: <20180216213700.3415-1-pbhagavatula@caviumnetworks.com> <20180216213700.3415-9-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: KL1PR0601CA0001.apcprd06.prod.outlook.com (2603:1096:802:1::11) To MWHPR07MB3470.namprd07.prod.outlook.com (2603:10b6:301:63::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f5064483-9039-4e47-fb96-08d57d4eb0a9 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:MWHPR07MB3470; X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3470; 3:Lk+4cTwKSTeZMZ9Xs83EsGp6MxQytjjU+rGEXW35uqQAP2QgAPBPgBkqwN7FdYh+/38PkJFgRGuS9twx5qqX4rdbmYfURuOe2jHILQus1tbLjSIGuR/lGc8R4725iqNGVWEADP38aeb8SMd6HyBa4PjcKXC/P/TIZnVRlJu36C5HMx2d2B7IKlTpoALOZuegCwLrzquqmISfVjSoC2gKxjPXIfTQY/j5ELMKzBwOQOxhTBfNGPhbhDfXak5Llxxx; 25:UEi8cJCwvfhVuNL7L+EzUEIE4YZ3bnFK//fTq3k9Fl2G+vqAQHmX1O6IAvFK1nOFTDwfKH/XJNtAmSMU7rJQ6ApJO4fpWE81NMN+0o3q7taDWkb2PEqi/hSwx1P4nT7lnvI2CeSDXho+Orck+IOzl+T2eedi8f0zFIVsGUnTXydCfgvL4aJ2cYOSWNFh0DS2uMPvxkqpCspB7v8zlcnv7F1M3Bxsz9/xqVTtIXi5egxmrpdCBIMyPHb5n15zBcvGVzEG0lfyNL8IrFTTvHd4Bri550NqRx5+zRXC4g+KJhtLkF8Y624SiSSISqWvSacctWnTrl8nz6rOLNNwvOEUJQ==; 31:zrnokW8ToJ5NyxEX0sI5cIZYVPpcEczPKjs2T69bWSNJ/043xpQDLMwb88b7MCd1lP4rPY9LsYZbkB5BuM+uYEnuugEcFUDtyNoYP9Z/fSAU3mDwjwfjw9RqRTwflTxprW+WBA35422awpDoMDf64lAHHbGjCJiKjAQVMdB8Tkz4My0AdHSLvqe80gski0sC7klNMGh8tZdZs+Xsp15owND8cgVam7UrB2Jgu2TVin0= X-MS-TrafficTypeDiagnostic: MWHPR07MB3470: X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3470; 20:h2npQCJSf1EJI1Soiu4EKjxt5iPlxEdySiSgw3gSnAB5pySerCdPO8dab2dyj8Jo2FVw+DVF6NtzgKICYPLwBjgB9ObTBTuHoSjuLzhADa5JHswnpuFKljssmfttE0gufwBUH5yMtcWSJzDPiMoGXV0GWVtf9hXTIqODsAiv9vB9lpeS8ajgDFrNpjieQGhrc2ah3fdrr8FM/ym8WYFPiSI6mmr9wNag2IW+kPSE4a8+jqoMyMArxR5uxjDEkPc/al9jBvuio6ilkRtY76Ce4as4+wbxDu5DL+xzdigoXBEiQWr3RhhU0gx0j2xnO+I2zGTogaug8Qbb0tmtY6Ec0+l65uHZOkZo0b/C4vfXOvGPIGP65xvCxiFckWfH2bjoAzq8lxtU3KF7ao4of9ksYoCAG2cmM/MdmaDbqrudgB+fhY1SYXd1FSd9aoo0M4J8vuGmSYgzuG7Fc4buQu11aqcs0rp2xCaPlCK17XE0mw+EFf9sTNSaNxEdA5jEsjMisbp/w3gBc0GuKQGHmjokE4EpJvPOGI6wDT3B5yUetCkx61+Ib3n5K8ON4TAvwiVf5CmfWJVOysrBGNlAGxB8vKZTBX9nPXOK1cRfu03AJFw=; 4:f63g0gctBOAJZIP+UnKo6n2p3OCDpSEV8U3jM0pKg/DmRtEMzt8Ugdqc7CXlV7xuqY+OGGFLWRGzHcBETOZ3y4e+sLAIDyT/D0tkW2W7kR9/8NMbDDnqMo9xy9oJTJGdQAW4zwafYczKaVQptgNe21H2EdwXXjREyz/SbEXmUaClaWYaN7kgd47CgOXUH5a8DkImepxVa3cLy5uVO07l06jQ8zga0GogHI1U308RSS+Ra4wo9qBf1RY/MB1Ibm88xjRYfGEV2KmGyDg8WrIY74AfBqm0KcxSwtwO+i392j8+9t38vsQwNC09glOqAPSk X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(8121501046)(5005006)(3002001)(3231220)(944501161)(93006095)(10201501046)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:MWHPR07MB3470; BCL:0; PCL:0; RULEID:; SRVR:MWHPR07MB3470; X-Forefront-PRVS: 05954A7C45 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(376002)(396003)(39860400002)(346002)(199004)(189003)(13464003)(58126008)(316002)(68736007)(16586007)(2906002)(26005)(9686003)(66066001)(2501003)(47776003)(6306002)(4326008)(23726003)(53936002)(33656002)(105586002)(8676002)(1076002)(76176011)(8936002)(97736004)(53546011)(81166006)(229853002)(55016002)(7736002)(478600001)(33896004)(5009440100003)(3846002)(25786009)(72206003)(305945005)(110136005)(6116002)(386003)(81156014)(6246003)(52116002)(33716001)(5660300001)(106356001)(6666003)(2950100002)(53376002)(6496006)(6636002)(16526019)(2201001)(42882006)(50466002)(186003)(18370500001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3470; H:ltp-pvn; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR07MB3470; 23:otFPOWaGHtCAIRyqi7LhWUTniQuV9yyLP3CkT+9YX?= =?us-ascii?Q?LRSsTZMStsi3voLtpFqafonzx7w8aLcyTbK4welne68W+f22tLKxMMYSIGnA?= =?us-ascii?Q?12KMJl1AhCe3RCSd2Ogzm6ZqJ1oDpH+iJKWLO7xql62AY5Cnj+O34qfowP7v?= =?us-ascii?Q?Q55RJgtwK4y9TVdviJ3SKGxcv0j4wwuUvPyMPLE0XrqyxuDhGUZEG5IT3ey6?= =?us-ascii?Q?apYXIAE+bcUCkJD1nvdS6FQelLWFzSRTVzD2YIlKWmlt32BMPQVJAVUS0AFq?= =?us-ascii?Q?LaTVtu6WODIgwOdE/yukiUtJzcUpqSLHdH+3lpPV7z+BV7+5Wbb46b36ghI5?= =?us-ascii?Q?dUn5WbD3r3zNChbb1jFCTF9vruYt01jVLZKkp41KNCm8xfvdlaSVBL/NSUxf?= =?us-ascii?Q?39hfSGjiqK8h1TS8alEVipqt6NSXXNikXnQOxu+Wv1yJHmnm2juu8yCHVAHo?= =?us-ascii?Q?LIDkomkbmANxD2Ck1h2gAQy124/IThrna+YAotD+7tp/93MwnDmQlG2rc9qW?= =?us-ascii?Q?h1B1ikVtdvJ2NopQ7TihwFfB2xKdr0w7eBKnjYocvDzXpN2qxHe5arGul8Ms?= =?us-ascii?Q?Qok1KIgl/3IvKpZ+c75KJDQgN4s96Rczs8WJuWpjLWSP984A1AorvkWq5wl9?= =?us-ascii?Q?derDznoZxDD1xXhmkizW4g6wR+YCowSTA0Xoyo8YCYZ7huc4+vclElWOMY2p?= =?us-ascii?Q?Zk9NcP6ZPrHjRKLqFjHxzqt6YVh+3NsR7qXYYmoVKkKjgcuFzcb2c6aSkH3Y?= =?us-ascii?Q?4xCtiJyWVaq+0XFNDIK4aNLhf8jk3/SyJFYNJJS1cQYrX6QExm+cdxwz4oyf?= =?us-ascii?Q?5FBSR2TKWYcP+u+HnGzuMNDmCUk3rKrxNoFVm7eGZPwIF815GVScocla00jb?= =?us-ascii?Q?W7JytX9ZENcTSCw5lEoZ7cFw7pVpjBU0WJIFVIDdV5Q1cNvju/S2z+r6Txdk?= =?us-ascii?Q?9u4GeojZiAVv4ryNIPu+PFHLTVeLbyNM6oGmh1npORH1zSuqHkd7PX3oQwrE?= =?us-ascii?Q?veAHQSo2G/wPViG53YW2TwceLU7OQEtNtS3clfUEGbIXGH48C2adKLwcXff/?= =?us-ascii?Q?9oWXZWjrCUa/jUSCVVug14hOhCjyMLOWaSZ0Dhxd3yXZAo+M6T5GyzSOVB8Z?= =?us-ascii?Q?8Y4NsHLG8hGnHyJHZ8zsXIlwFVTk8jA1Bs2N8I7kETgSPZyf8d21E777E2d1?= =?us-ascii?Q?N5nZZ3SAUJLs0uGShZdrSQEfeeGWZjzW9pRU93FJTK/6P9cIyP+IDXAPdm0x?= =?us-ascii?Q?+4oinSbyVXl77+iAR8gbUZHqVV4PwTqmGvLHq56acbccPACgBCzQkmzO1K+h?= =?us-ascii?Q?CzQKtKZjIzjnWhm0jLdtP2qsfatUglTw/lcPHMOF59foTy0uAv8ejrxvyE7W?= =?us-ascii?Q?uOjgJNBIehRDOT/TunpMFD0tE5sDb7cHTce/6nG65F9dq/t8lVpalmFbdXFJ?= =?us-ascii?Q?zkMbCRvhboBY/D+NiEREKO6+ASwQ1o=3D?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3470; 6:RRZ5bKJL4PEiOBIjvEUdy72tL0QHaBaH3KG1plTK7gen085mq3UW2aPFRir5k1QLsead78Byzj8xHsOWexXQR2zpGxSnBZlV0vYTw7XXis/U6zIDnwW6ZSt79Sl/UKrngS6j31WbRy/4PN6E54NSk6xaKuQp1GNItg/aidR1Op3/4tBCS97yXfXjhucvO5RGFoTZORVTVY3m7ZZZJkqQ0a3HP6Fz0IrvLkOtaq2ymMsaAVWnfw/lpnCyLD8foxcRJakGH6522bOXUuaS+Zl4J6YhdqkS3sDFBvzkxqhVPdPX8GgcZF4pDSPwRm2WbGxOjBXM70OuSXspvEG9GlvZrYM4IhmbaouH7MK4FLgMgPQ=; 5:gXGeVZpUKZq6JHrxqRYTWnWH8bkmNg4OuJSfT+8zcYVJeXJUK01cbjyuT7FGXSjXqxXzYwG5MGPIQDjnVr3azzydHjQLoo5WycTFa04o+iKc1ENJ8ttCgcXWluYji1nkaoM24KJQ4KUXcqxq/9LQOqC+/bH/nj4L6yR7k00tl7g=; 24:eTUf0GTOGPyFf5LdC+6hpLsruvtL0ChUPaiBt0k39kpMfhSmDLgc1OiJNmXXz22I25gujv8GhSAexKpeDNwkCvlmXjYFoVjx5w49b2CWYOM=; 7:SBBVIJNC8KwsYEJFtYPQgdpmhdo8Oi3L1TdYMp2WcDF0eVh4aC0wg62VgTlq77HsXJTlcsvqqoCayk5zXAo3lUvDd/aiIqrJGveydp06XHrqIts7ISamB548unNQGBFmfAEcso4anBLEfPDZ1o/TMr6E9ROy0kT8c12oVpg5l7g+a0k6oBlA69RM0oT735Qd7cFdvDKgSxZMgUrzcPWRDnbxSpmSKNqzhreic81z9vQI/zgAYvALjSWnaZD4zOoK SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2018 19:25:25.2644 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f5064483-9039-4e47-fb96-08d57d4eb0a9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3470 Subject: Re: [dpdk-dev] [PATCH 08/10] event/octeontx: add option to use fpavf as chunk pool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Feb 2018 19:25:28 -0000 Hi Gabriel, On Fri, Feb 23, 2018 at 08:17:07PM +0000, Carrillo, Erik G wrote: > Hi Pavan, > > > -----Original Message----- > > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > > Sent: Friday, February 16, 2018 3:37 PM > > To: jerin.jacob@caviumnetworks.com; > > santosh.shukla@caviumnetworks.com; Carrillo, Erik G > > > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subject: [dpdk-dev] [PATCH 08/10] event/octeontx: add option to use fpavf > > as chunk pool > > > > Add compile-time configurable option to force TIMvf to use Octeontx FPAvf > > pool manager as its chunk pool. > > When FPAvf is used as pool manager the TIMvf automatically frees the > > chunks to FPAvf through gpool-id. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > <...snipped...> > > > @@ -241,7 +243,16 @@ timvf_add_entry_brst(struct timvf_ring *timr, const > > uint16_t rel_bkt, > > bkt->first_chunk = (uint64_t) chunk; > > } > > } else { > > +#ifndef RTE_PMD_OCTEONTX_TIMVF_USE_FPAVF > > chunk = timr_clr_bkt(timr, bkt); > > +#else > > + if (unlikely(rte_mempool_get(timr- > > >meta.chunk_pool, > > + (void **)&chunk))) { > > + timr_bkt_set_rem(bkt, 0); > > + tim[index]->state = > > RTE_EVENT_TIMER_ERROR; > > + return -ENOMEM; > > You return a negative errno value here, but in this case the caller was expecting the number that succeeded. Agreed, will add a check in `timvf_timer_reg_brst`[1] to check if call to timvf_add_entry_brst has failed. [1]http://dpdk.org/dev/patchwork/patch/35206/ > > Regards, > Gabriel Thanks, Pavan. > > > + } > > +#endif > > bkt->first_chunk = (uint64_t) chunk; > > } > > *(uint64_t *)(chunk + nb_chunk_slots) = 0; @@ -355,7 > > +366,18 @@ timvf_add_entry_sp(struct timvf_ring *timr, const uint32_t > > <...snipped...> >