From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 29BCC4C9F for ; Tue, 27 Feb 2018 08:51:22 +0100 (CET) Received: by mail-wr0-f194.google.com with SMTP id o76so23792575wrb.7 for ; Mon, 26 Feb 2018 23:51:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=v+eRk1T9DJzi4Lu6q/OzACfnQsyIGluRtnHLzv9oI1Y=; b=geJ88vVb9s/bEC/kZjc0mOVbCJlr4ylSaqctj4GlPQhiegGhegPNh5Je4NfoAbPJ50 QlHgbONtNMFoRZZgfwQvr8svB71hZynx+XT1U7R5fL6ZzWe1BWVNz0Z7hDNuw0eY3PuO 01fx8bAsHE/+P8nTvEFWn/nu8I5/6jJItNiWfI1nMDw29AfpPjndSIZnD6r41A7NRUzd UtZulTjpRxVg1KGELE2wTDM8VIlbLzlv/tovBxp0AZ/QEpuK5FEshFedHj8LomdymzLO sj90ql2Djf+SHGZXfQEipW33e5Zdm/zqpjavPNBNV3HksRp4zwQt5dWAeKWKPKHMT+2c 2BeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=v+eRk1T9DJzi4Lu6q/OzACfnQsyIGluRtnHLzv9oI1Y=; b=SzNcWwKHve3B4PLhQhgbiLDc1815xfXbw+FvmpsSuhAvNsPHZQv61sfyJHcPlMCgOK io8cik867zlgbbqdW5Wu/MXlfHgDSotvtkB/LYkNoklT+5lBulH8B4XX+PvITvzOSunT qE8QyTTMJhPDM/euZWs1UfA9P89wdDpxLmyrcksLFiNT7bZDnWdRGMr4ZZ4gc9wV8QU8 Yi7SP2gfWvmwyJPz2vgSFT18pL6DfH4oZsn8nvwaPW6YJIwdpX5TFGRqZuUi3CaCBaXY JBkrpTMxoWR5AWlezRRd+e8Q1uRP3hjab4xnNqsmjiz3T3Nz2CzDt2cqUl3FChtYNdsX h3tw== X-Gm-Message-State: APf1xPBhA8L8zjvEYaAu6yiwjko1L1EcrcvsuICuY1Bd1WIj2VWcDT/7 ife6e8z7fmxM+EtBhtZzq/vt X-Google-Smtp-Source: AH8x227Y8xtjXijRlCmMBd4pEvNUa8u28NM0NxKN6BX6+CUftK8XQanZX/1mg5arJSyl+0eobAN1uA== X-Received: by 10.223.187.19 with SMTP id r19mr11258092wrg.110.1519717881820; Mon, 26 Feb 2018 23:51:21 -0800 (PST) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id w195sm3317913wmw.29.2018.02.26.23.51.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Feb 2018 23:51:21 -0800 (PST) Date: Tue, 27 Feb 2018 08:50:42 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Yongseok Koh Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20180227075042.nmjaif4rgnx2eoka@laranjeiro-vm.dev.6wind.com> References: <20180226175057.27565-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180226175057.27565-1-yskoh@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix disabling Tx packet inlining X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2018 07:51:22 -0000 On Mon, Feb 26, 2018 at 09:50:57AM -0800, Yongseok Koh wrote: > Adding 'txq_inline=0' to PMD parameter should disable Tx packet inlining > but it doesn't work properly for Enhanced Multi-Packet Send. > > Fixes: 6ce84bd88919 ("net/mlx5: add enhanced multi-packet send for ConnectX-5") > Cc: stable@dpdk.org > > Signed-off-by: Yongseok Koh > Acked-by: Shahaf Shuler Acked-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_rxtx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index dc4ead934..049f7e6c1 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -1382,7 +1382,7 @@ txq_burst_empw(struct mlx5_txq_data *txq, struct rte_mbuf **pkts, > (!txq->mpw_hdr_dseg || > mpw.total_len >= MLX5_WQE_SIZE); > } > - if (do_inline) { > + if (max_inline && do_inline) { > /* Inline packet into WQE. */ > unsigned int max; > > -- > 2.11.0 > -- Nélio Laranjeiro 6WIND