From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stephen@networkplumber.org> Received: from mail-pl0-f65.google.com (mail-pl0-f65.google.com [209.85.160.65]) by dpdk.org (Postfix) with ESMTP id 31D805681 for <dev@dpdk.org>; Fri, 2 Mar 2018 01:18:22 +0100 (CET) Received: by mail-pl0-f65.google.com with SMTP id 61-v6so4636821plf.3 for <dev@dpdk.org>; Thu, 01 Mar 2018 16:18:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vPvwCbU9iXxNJkaGQsuTT9bJE8ojJjet3DBmT67iXcs=; b=az5yyKGJuFrwl2uR4R+sAjjM1uv407uWLYKow0GuYZYmgaOxVNBtuAcd63rYOh4DJH 2mKHRH11jFdr+wirHU60+xiromkxICkuUGBHnG5MW0+6vjnh973dLz0wyTKg+RZNP35e rPytpx9zsT1vbj2VGxf0HQKgULYt0k1HSNgBVlwtod2v2yqKxKNaDl3K79QaRGT7zTRF 0gWWRpq3O8Ytz9OXAycunlOecP2JN1y75+sWG8/N3YZ1oZWYpyC5DFpZbmtkfaPtnoL3 N5GWAuSVtmqiuFK5ddOjqsd+rwxr03KPNWxi8czZtqdCqzvMHR8LOyEvYlBC1JTfT6pZ MeUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vPvwCbU9iXxNJkaGQsuTT9bJE8ojJjet3DBmT67iXcs=; b=gF58dfSdkk8Sk2QntNYn4hH4XMB6U0Sl82ZTiDNtyil0/lAplwmGF5RhlUTdWX6ZMh JfOc+T0qx1TEWQI7rSP2QHl1Ek2BUzGQ8jVz/gg9dfMB9Dm8NTmBLZkGc4+6w0pxbjCq 3FvldvuIqqMJgto6Ws5sXl7N5wrPAGa84/acCSwFhzywKasP0j2Gzdfc2VijljpE3XUT 0Lvfz3qDFWR9YlgGUSluOhKN8qIAxn+U6klWKAMx8i4E/IZZdvQw+4XGof2/NlkN17b7 liDxAYQ6CE51hMnTK/Sv3pFihCV1+W8/BwMDCWbJhzG81GGmuzE6nKbq8EYWjH9g6Xya DMDQ== X-Gm-Message-State: APf1xPCbAATrJeER38GCURjSJhK2m6goH4IN+aLcPMsyA+zdsXJxqTdp QoA3vd/mu+ee6+vZxfKHTdIBdg== X-Google-Smtp-Source: AG47ELvAPSoQEP9x3OL7LGbzM/M4FpK7iXB1CjckkLZgdi+N6ZP4NvmDXbKqFXSufl9zowEDriYAtQ== X-Received: by 2002:a17:902:710f:: with SMTP id a15-v6mr3432208pll.87.1519949901277; Thu, 01 Mar 2018 16:18:21 -0800 (PST) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id c18sm10611973pfd.100.2018.03.01.16.18.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Mar 2018 16:18:20 -0800 (PST) Date: Thu, 1 Mar 2018 16:18:15 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Lee Roberts <lee.roberts@hpe.com> Cc: ferruh.yigit@intel.com, dev@dpdk.org Message-ID: <20180301161815.6c7771a6@xeon-e3> In-Reply-To: <1519946435-3574-1-git-send-email-lee.roberts@hpe.com> References: <1519946435-3574-1-git-send-email-lee.roberts@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 02 Mar 2018 00:18:22 -0000 On Thu, 1 Mar 2018 16:20:35 -0700 Lee Roberts <lee.roberts@hpe.com> wrote: > Fix kni compilation under RHEL 7.5. > > Signed-off-by: Lee Roberts <lee.roberts@hpe.com> > --- > lib/librte_eal/linuxapp/kni/compat.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/lib/librte_eal/linuxapp/kni/compat.h b/lib/librte_eal/linuxapp/kni/compat.h > index 3f8c0bc..6a6968d 100644 > --- a/lib/librte_eal/linuxapp/kni/compat.h > +++ b/lib/librte_eal/linuxapp/kni/compat.h > @@ -101,6 +101,11 @@ > #undef NET_NAME_UNKNOWN > #endif > > +#if (defined(RHEL_RELEASE_CODE) && \ > + (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5))) > +#define ndo_change_mtu ndo_change_mtu_rh74 > +#endif > + > #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 11, 0) > #define HAVE_SIGNAL_FUNCTIONS_OWN_HEADER > #endif Do we really want upstream DPDK trying to track every vendor kernel compatibility wart? Should Redhat be owning this in their own DPDK package?