From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <johndale@cisco.com>
Received: from rcdn-iport-7.cisco.com (rcdn-iport-7.cisco.com [173.37.86.78])
by dpdk.org (Postfix) with ESMTP id 482911B53
for <dev@dpdk.org>; Tue, 6 Mar 2018 02:46:42 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=cisco.com; i=@cisco.com; l=1859; q=dns/txt; s=iport;
t=1520300802; x=1521510402;
h=from:to:cc:subject:date:message-id:in-reply-to: references;
bh=BO6cLbFGDnlsJtyQ9uSkO23BdRCTZA2z8ybVet6FhC0=;
b=iQGFJjANRbk1e10qr9qPUjHqP90sBPL03tDEpW4F1t7TItHYF+WdttJ0
Uo6gc4zYgy+bEb1xJtRFma0xeBjffIxaJxsJgg00bsRCEaB/wMIEs8fxZ
PpckhapbfiqSVNS5XQ7FF4XB03nTnGs90Sa6KCKotJEnv+dzjvq69mxo+ I=;
X-IronPort-AV: E=Sophos;i="5.47,429,1515456000"; d="scan'208";a="362189304"
Received: from alln-core-10.cisco.com ([173.36.13.132])
by rcdn-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
06 Mar 2018 01:46:40 +0000
Received: from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48])
by alln-core-10.cisco.com (8.14.5/8.14.5) with ESMTP id w261kevv023280;
Tue, 6 Mar 2018 01:46:40 GMT
Received: by cisco.com (Postfix, from userid 392789)
id 715E420F200A; Mon, 5 Mar 2018 17:46:40 -0800 (PST)
From: John Daley <johndale@cisco.com>
To: ferruh.yigit@intel.com
Cc: dev@dpdk.org, Hyong Youb Kim <hyonkim@cisco.com>
Date: Mon, 5 Mar 2018 17:46:33 -0800
Message-Id: <20180306014634.28398-10-johndale@cisco.com>
X-Mailer: git-send-email 2.16.2
In-Reply-To: <20180306014634.28398-1-johndale@cisco.com>
References: <20180224191748.20908-10-johndale@cisco.com>
<20180306014634.28398-1-johndale@cisco.com>
Subject: [dpdk-dev] [PATCH v2 09/10] net/enic: use memcpy to avoid strict
aliasing warnings
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Mar 2018 01:46:42 -0000
From: Hyong Youb Kim <hyonkim@cisco.com>
Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
Reviewed-by: John Daley <johndale@cisco.com>
---
drivers/net/enic/enic_clsf.c | 21 ++++++++-------------
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/drivers/net/enic/enic_clsf.c b/drivers/net/enic/enic_clsf.c
index 3ef1d0832..9d95201ec 100644
--- a/drivers/net/enic/enic_clsf.c
+++ b/drivers/net/enic/enic_clsf.c
@@ -111,7 +111,6 @@ copy_fltr_v2(struct filter_v2 *fltr, struct rte_eth_fdir_input *input,
struct rte_eth_fdir_masks *masks)
{
struct filter_generic_1 *gp = &fltr->u.generic_1;
- int i;
fltr->type = FILTER_DPDK_1;
memset(gp, 0, sizeof(*gp));
@@ -273,18 +272,14 @@ copy_fltr_v2(struct filter_v2 *fltr, struct rte_eth_fdir_input *input,
ipv6_mask.proto = masks->ipv6_mask.proto;
ipv6_val.proto = input->flow.ipv6_flow.proto;
}
- for (i = 0; i < 4; i++) {
- *(uint32_t *)&ipv6_mask.src_addr[i * 4] =
- masks->ipv6_mask.src_ip[i];
- *(uint32_t *)&ipv6_val.src_addr[i * 4] =
- input->flow.ipv6_flow.src_ip[i];
- }
- for (i = 0; i < 4; i++) {
- *(uint32_t *)&ipv6_mask.dst_addr[i * 4] =
- masks->ipv6_mask.src_ip[i];
- *(uint32_t *)&ipv6_val.dst_addr[i * 4] =
- input->flow.ipv6_flow.dst_ip[i];
- }
+ memcpy(ipv6_mask.src_addr, masks->ipv6_mask.src_ip,
+ sizeof(ipv6_mask.src_addr));
+ memcpy(ipv6_val.src_addr, input->flow.ipv6_flow.src_ip,
+ sizeof(ipv6_val.src_addr));
+ memcpy(ipv6_mask.dst_addr, masks->ipv6_mask.dst_ip,
+ sizeof(ipv6_mask.dst_addr));
+ memcpy(ipv6_val.dst_addr, input->flow.ipv6_flow.dst_ip,
+ sizeof(ipv6_val.dst_addr));
if (input->flow.ipv6_flow.tc) {
ipv6_mask.vtc_flow = masks->ipv6_mask.tc << 12;
ipv6_val.vtc_flow = input->flow.ipv6_flow.tc << 12;
--
2.16.2