From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0077.outbound.protection.outlook.com [104.47.37.77]) by dpdk.org (Postfix) with ESMTP id 13F362C39 for ; Thu, 8 Mar 2018 12:14:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=MKq5cZk0TZZZTg+bdxAjKPRNt5yPdHMnHfDKuIN0tw8=; b=NNN2viinMJjgnehkTbXoKrEawSxlj6TqkUsfrsMQ7ZgXOPxCP7GyBFZmzKYq94GVDhgd/zTl49LmEN7slOTi0c/ZvXmf01bYYkHUYinsfaZiYfyrzQqHlTbGa2y7p1oAv4zye/0D/UzYZlyCm5i7Im4lxmAtFZz1QYwr6F4yhFA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (111.93.218.67) by DM5PR07MB3465.namprd07.prod.outlook.com (2603:10b6:4:67::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Thu, 8 Mar 2018 11:13:58 +0000 Date: Thu, 8 Mar 2018 16:43:38 +0530 From: Pavan Nikhilesh To: "Burakov, Anatoly" , keith.wiles@intel.com, jianfeng.tan@intel.com, andras.kovacs@ericsson.com, laszlo.vadkeri@ericsson.com, benjamin.walker@intel.com, bruce.richardson@intel.com, thomas@monjalon.net, konstantin.ananyev@intel.com, kuralamudhan.ramakrishnan@intel.com, louise.m.daly@intel.com, nelio.laranjeiro@6wind.com, yskoh@mellanox.com, pepperjo@japf.ch, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, olivier.matz@6wind.com Cc: dev@dpdk.org Message-ID: <20180308111337.GA11638@ltp-pvn> References: <20180308101805.GA9526@ltp-pvn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: PN1PR0101CA0006.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:e::16) To DM5PR07MB3465.namprd07.prod.outlook.com (2603:10b6:4:67::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 29c18446-1fa5-443e-bca8-08d584e5b344 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DM5PR07MB3465; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 3:CLRf6uwAAJA6SWg6EZJoxrkDozVoHcsqEnzFCLB0NUn4TYCVNBnNTQ5r/87K5HqWNm1/lwpd/G7Q7npNmPmC790m9ZP2EujJ3ol+gyQarrWsjrcPI2MYXaKxOvx/ebt4wgKQDFV2XQ1Fuoalg3T0TUCKL44zStSAnq16mm1+q7KlfBNEp603N5XmvkShLrxcPmR4z66rUyNnyewMl2E1ANu8Qi2SIAlW7NSzXMoMCY2lO8Z7CquUAzzJbJS58NZa; 25:sbsBPUosQmvzuYSTwvS6GEVAiqrUHvV4evMlEeMHd34cMNbcxKDVB2Yjuanb90xMoofMGpTIrVkML6eOLjeS3EWZFPr4jYkQDaqgUlZkc7zHLuo2REnmdmSS55duyW+GLxlUyaDN07MC8VFD/hO9CDgh+kVYgkemGFOBCkVpem/tzy2TLUeiW6kDHO3iiv1iVzRG8qsS58ILI3Y66QF5FLCmUJv34OQc5Md7u/GYLHZyUx2dGpbzcWIPHoixuF/GFN50P26tkwUd/cSkhSjd34mCN+igRg67+I3DvpONU/dMR+019WxzG1UC6/Ejv2SIb4OZRIZvL3ddiN/Hz8HtbQ==; 31:8g8NTuUc+ytCt+viNQpHbnWCJCHaryEnEel9Jx3TcjIROrK7aFCmw5P1BoRId8dtz5c+IOclCz07N64lnr/Y55He8loNp8T1yDksAkHQD5lPUdIa0u1v5NnF9rpM7PpkhfXVLNH5kKefcdltEQkQOvvl24VSkSizXoZnqHhIb0vMFxAj3xizN3V8emYVN+hd7LXOo3W7nuOQ/pqsMsv0Y8vkbj06Vs2bb1O/nbyHlYM= X-MS-TrafficTypeDiagnostic: DM5PR07MB3465: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 20:gIzOz/yHvFoxMI9Z2qCj7iRNaPo0KHWfNLDeqw2t+3Gp/FEciJLVh5P8TU8j0IsuMSgkawyPTnrG1pqG20xdsjN9ETGDJ7ZFxwTGoKNpj3lCn8HMHzHRNgJlFU8jEddibZmxo1/Cv6hcphfvUycvX8lizc6I/EhX0TK2PiwFGC0a6JAau0R5KbqgmiS0vv7029N+V8m3vY+d1jSsjm/jNC01Cctayt+48a04r/qIu6xYa//MXRdSBlS3uExZ1MlVYQw59tqshDHubbhvuhu30EM6mc7eByME8uU71Y9Y300ZhZK9gJyssVwNWhEQF8QntWHjgbB70CMi7XHJo9oXyXNaD/aYLwiGJ0+ZI+BiD6yh/EOHTJqfFrkk56QyhD/kZcCQSlkpO27j9cDUqFcLD5HeQvc6lNe6mFTNqkVOwHCQ/T6ZDJkYDQaBFgJDwYYmgn05FCZRUGQQAuEAtkN+jzaD5vcBVY7PoUKrTFGwSMtmeFw282wG9nB0m9ZYvkpq0zrZ78Qz/gfML75v54BI7i2fsizNOoobbVzzt3DxfUMZncaig/MauQJfcpC7TnowYHHxrbCdxYb+Fjep4x0IlUc+3BqCBq6fRxznl/XMh18=; 4:UfUX71/x2v0jUmHxyhB8GoXeFqtf869gCz0opAQloEbC+ATyHWcLU/3k8YDY/2Hzcu133uqk2+Gfw3BNtkVY1rlU/tPuH+ha1dYL7W8FxsfchxcOPKeF4TInEc4j+JEh4c7V812tEXeT6QE4dikP2UB93Ay4S4iCBst1CuRlZh/5m6QDw1RtWm3ftRW1heX8VnuHzQIw7opmARinbLHDDWW1K+ltJWVG+7Hw/cNSll3M1PnXHvoMhbmHHKhqKT2rxSmulxOljR4BQJBh95zIKA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3231220)(944501244)(52105095)(3002001)(6041288)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:DM5PR07MB3465; BCL:0; PCL:0; RULEID:; SRVR:DM5PR07MB3465; X-Forefront-PRVS: 060503E79B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39380400002)(39860400002)(346002)(376002)(396003)(189003)(199004)(51914003)(106356001)(58126008)(16586007)(4326008)(316002)(8936002)(33656002)(68736007)(186003)(2906002)(305945005)(16526019)(7736002)(97736004)(53376002)(105586002)(5890100001)(2950100002)(47776003)(66066001)(5009440100003)(6666003)(42882007)(229853002)(52116002)(25786009)(6496006)(81166006)(81156014)(966005)(8656006)(72206003)(8676002)(478600001)(76176011)(6116002)(3846002)(23726003)(6306002)(1076002)(53936002)(50466002)(9686003)(55016002)(33716001)(6246003)(93886005)(7416002)(575784001)(386003)(59450400001)(5660300001)(33896004)(53546011)(26005)(18370500001)(107986001)(921003)(42262002)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3465; H:ltp-pvn; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3465; 23:vsppSQ72d48nrML6uPY2wZhaYmifCm1tKbdkWmCd6?= =?us-ascii?Q?ynQlBjdJvra5ckrtqEwQnjHv+QC6KbBVXeLTdktPRSFS6zfSbiDGngsV2MS+?= =?us-ascii?Q?+TqUP6BTTBYcw2ZNj3X/SlWqto3T+tuoK7joil/gh4Yasg9VhIcosM3CLeY4?= =?us-ascii?Q?MRH0vWlxLBmxOgyCw9FEAw4D4iBAfIEd6aRmnmOs0uZW5W7pRByoDhQAJlG6?= =?us-ascii?Q?IYcuFUztRiAHMx2zsvd0kCfHoOf7bQTxs3LOfbRu+kO84bSqz+uo/0plmRds?= =?us-ascii?Q?uOPIQJEwi4jtqJ0p9I7MWQ9p6WnKzsBzmgFF1xK5w0ovn0eH++536q/mv4oi?= =?us-ascii?Q?vq5S2pyy7AvZ1FLfuMHThTRj7vRCUJT44U5HC1zyUQfV+MDcDFs9MVH7HRec?= =?us-ascii?Q?CuCC7mAimCv14BDx63TYSqVK5XECIFosp54hgUEsIMcULsXuzjjv8wc18Bcn?= =?us-ascii?Q?mMX0Gnq3FHZ3Y+bVMUvqhMed6K4hHPFNA6kIALLwOkMeBt65JYL/iLT9ZIXz?= =?us-ascii?Q?LDB/31uYiomC1IrAEyI/0zx0V17xQnEyqGsv51NptfipwMch2qM9wOBTDR9v?= =?us-ascii?Q?eT6CoRqEv2aVSBplUMCz3tozccIDVuCRsjw2thb/bPaYzWKUWZpH4JICP2Oz?= =?us-ascii?Q?d21sZehvU8Rit4Uj8KCVWwKwj8BN+3p3IrhYZFmNteoFKEpJ6+r46xxiyJlq?= =?us-ascii?Q?BietBcIyD6STDAaojDPKn9rOFPdbC0DldnUiwkjO/I1b718QQaCRssnnWhoD?= =?us-ascii?Q?4z0AlgtPkSi3CDfzBaZ/WbSiMjFaleBYy1AUAML+3P9LaJJed+6ulwG7MTWq?= =?us-ascii?Q?T6aSt0LlhlYF3T/0tEhsHsUzKTm2lkv/lng41NvBl1gaalFSg6c8yp5y2O99?= =?us-ascii?Q?8xrjuUB8Zq6lux4Pr69i6GGqVkmIx6xZlwwFzJqd/Vhsf3d2M5l+ta/rXQci?= =?us-ascii?Q?HXLVNV1UpvJcus/9B531HxaRU/gx4GFvcjoHboGEJaAo+u8jU2747cGMXXDY?= =?us-ascii?Q?SHlXogkMCPaCsOELY491gaadmn7DCxg7EGXpvCEsSj2p9jZArSBED/dKiYK9?= =?us-ascii?Q?mXPCQhjVpDcKdgnqSYKndXiLYXGdENsA3XBwM7GR4n3cfq56xxzqV+5pUdqM?= =?us-ascii?Q?ma8n7oPnzYIJxNdAB8n99ZozmC8wjFujmaikA7ItJz4UenwTcie9Wh5GYMSK?= =?us-ascii?Q?3QcLYt/RHM4YAzqc53/NSr71dEoLjdPXonJaSoVXNZvWNf1dZctw4vHqs/ZK?= =?us-ascii?Q?WU9h+kjI4av0oEJTx4fX4OCiEClztJqTRxaoyNuTT8wyrgxWKG5an33NExep?= =?us-ascii?Q?wrDKEqrj6VUNOt1x9RNCBSWf3ejtfNLfiudaE3bloCbnc19ewH3GzrtK81xz?= =?us-ascii?Q?HgrM31XZCxVXwpEshv/ND8MGi0WHfZpa0G7zAy6TSrFOUlKxJccBDydu7Dol?= =?us-ascii?Q?aqfN/xPwNN0lFhGzI9IaiZaYaYDiSKX1l/ZZKwzE11M+CUdj+4TNuB92F327?= =?us-ascii?Q?D4zJOfuS6Z3GpQP0w7kd5BaY4nGunztdQHM9aD4GlaQxy2wx9LlIo01kOtOv?= =?us-ascii?Q?eEox1iqKhz4E1oIEdeXysPiOZ5Cvt1IxtvQxuI=3D?= X-Microsoft-Antispam-Message-Info: rb44Ff7vGUiKnVLKS0XirOi/kqFSHTa/F4Xq33ITCgW6CtY7dSM0dbBIO4Sw84ehSap3Y/7/Y17P+TxJsqxSAjs2ksrDVYzGq4nMfoJArKN2pHyYwuYYvCLoSjDYTlryeANGm7agon96W6C8P7uPX7RVm1uybXU4xFopEBVCGCbZyEki5Em9KMTlAimK2eOg X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 6:Rd5ycHOOwt5ExRQCv669A+sOLLJtSgx0SX6BC9nQivQFI4hEaYsKN/S+Qmpz4hItz4WiledEPUyhAYhq7xYTwHInyuVaG+7bAcUs6CghrgrbR2N5Vwzh6uxU1ZnAIsRsZ28I6qAUVDHdbdmQCc5P8pTHxi9AsZ7/wausmAmkAoevwNCPpKs4HOJdWdnN+msP42eXodDvbpfpNlUp9LV4gNjN00acnyiexkJcoTMMJmqktKgdlCQAoqVUGePiOIPVy73ZLTS2OcBXpKVRnCS/7PlaaQink+PQb9lDxzIXwLYjKS6kl1Nh+kEwcUXVfjXyeAimIyALukKL+cJ1jzWadbdx7cJL9XT3/+yao1D586k=; 5:U0ZQwVsXlewYOre/U9oyzf4gIJHlSF33t7RguO64qqLfrrGZnE8vJfnsT/17Y0U5PJICvfq9zIJj/MzwZsCKXEJjQd/nQKBowDigA0Hsrju/TD1MD52SIFYmvhYL/rmtNcDMF8YKgIuovElRdXRsrZAzkvXCwOYUDFfZyZOZev0=; 24:VnHZsof8X8NcKkk/OL2FGE3uCmBgqxzuoQvPPFfWVGDa3+p1F51jkpQYhhhB4TAF91n/56sLCqRIzQqt6f1FHmb2hCtxY8lVJ7POiF/I/rU=; 7:82jOtApIE89xGvq+UQ7K7wyosnbNawIM9sON4M9xPTTAuPIiTEQVql7qNujwgxXDLrkslqOvS2/c1tmz/BDay4usfGRf+7QL9Gab7G9z1QW8tjiVHXA8uTXPsE8D9fMZO6XuhYLPgeJwlJ9ZSFl8O6JkmT36n/e7dEKA1i3xzE/J69xVMkOnwAUy0hr/mLnrRZdRsjwnNOL4zW9rtqo6y+kF1E/dvjFxkpblNcX2eD2cdiKxS8ebqWMmsiZACww+ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2018 11:13:58.2484 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 29c18446-1fa5-443e-bca8-08d584e5b344 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3465 Subject: Re: [dpdk-dev] [PATCH v2 00/41] Memory Hotplug for DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2018 11:14:06 -0000 On Thu, Mar 08, 2018 at 10:46:46AM +0000, Burakov, Anatoly wrote: > On 08-Mar-18 10:18 AM, Pavan Nikhilesh wrote: > > Hi Anatoly, > > > > I am trying to verify this patchset and have encountered few issues. > > > > Few -Werror=maybe-uninitialized errors in eal_memalloc.c/eal_memory.c/ > > eal_common_memzone.c files. > > Thanks for the heads up, i'll fix those in the next revision. Out of > curiousity, which compiler version are you using? I'm using gcc 5.3.0. > > > > > diff --git a/lib/librte_eal/common/eal_common_memzone.c b/lib/librte_eal/common/eal_common_memzone.c > > index a7cfdaf03..ad4413507 100644 > > --- a/lib/librte_eal/common/eal_common_memzone.c > > +++ b/lib/librte_eal/common/eal_common_memzone.c > > @@ -321,7 +321,7 @@ rte_memzone_free(const struct rte_memzone *mz) > > struct rte_fbarray *arr; > > struct rte_memzone *found_mz; > > int ret = 0; > > - void *addr; > > + void *addr = NULL; > > unsigned idx; > > > > if (mz == NULL) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp/eal/eal_memalloc.c > > index 1008faed6..32b0d5133 100644 > > --- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c > > +++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c > > @@ -570,7 +570,7 @@ eal_memalloc_alloc_page_bulk(struct rte_memseg **ms, int n, > > unsigned int msl_idx; > > int cur_idx, start_idx, end_idx, i, j, ret = -1; > > #ifdef RTE_EAL_NUMA_AWARE_HUGEPAGES > > - bool have_numa; > > + bool have_numa = false; > > int oldpolicy; > > struct bitmask *oldmask = numa_allocate_nodemask(); > > #endif > > diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c > > index f74291fb6..d37b4a59b 100644 > > --- a/lib/librte_eal/linuxapp/eal/eal_memory.c > > +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c > > @@ -1386,9 +1386,9 @@ eal_legacy_hugepage_attach(void) > > struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config; > > struct hugepage_file *hp = NULL; > > unsigned int num_hp = 0; > > - unsigned int i; > > + unsigned int i = 0; > > int ms_idx, msl_idx; > > - unsigned int cur_seg, max_seg; > > + unsigned int cur_seg, max_seg = 0; > > off_t size = 0; > > int fd, fd_hugepage = -1; > > > > > > > > @Hemanth > > Also, this patchset breaks dpaa/dpaa2 bus drivers (they rely on > > `rte_eal_get_physmem_layout` that is depricated > > http://dpdk.org/dev/patchwork/patch/34002/) > > So, generic arm64 linuxapp build is broken. > > Should the deprecation notice have been accompanied with marking that > function as __rte_deprecated? Yup that's the general sequence. > > > > > Regards, > > Pavan. > > > > On Wed, Mar 07, 2018 at 04:56:28PM +0000, Anatoly Burakov wrote: > > > This patchset introduces dynamic memory allocation for DPDK (aka memory > > > hotplug). Based upon RFC submitted in December [1]. > > > > > > Dependencies (to be applied in specified order): > > > - IPC bugfixes patchset [2] > > > - IPC improvements patchset [3] > > > - IPC asynchronous request API patch [4] > > > - Function to return number of sockets [5] > > > > > > > -- > > > 2.7.4 > > > > > -- > Thanks, > Anatoly